ldap/servers/slapd/back-ldbm/ancestorid.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit cab6a2365b71e81676bafc8b9c7be3ac422b141d
Author: Mark Reynolds <mreynolds(a)redhat.com>
Date: Fri May 9 10:04:34 2014 -0400
Ticket 47756 - fix coverity issues
Description: An unnecessary NULL check caused coverity to complain
12559 Dereference after NULL check
12560 Dereference before NULL check
12561 Dereference before NULL check
12562 Dereference before NULL check
https://fedorahosted.org/389/ticket/47756
Reviewed by: rmeggins(Thanks!)
diff --git a/ldap/servers/slapd/back-ldbm/ancestorid.c
b/ldap/servers/slapd/back-ldbm/ancestorid.c
index c738b6c..b4d8292 100644
--- a/ldap/servers/slapd/back-ldbm/ancestorid.c
+++ b/ldap/servers/slapd/back-ldbm/ancestorid.c
@@ -112,7 +112,7 @@ static int ldbm_get_nonleaf_ids(backend *be, DB_TXN *txn, IDList
**idl, ImportJo
idl_insert(&nodes, id);
}
key_count++;
- if(job && !(key_count % PROGRESS_INTERVAL)){
+ if(!(key_count % PROGRESS_INTERVAL)){
import_log_notice(job, "Gathering ancestorid non-leaf IDs: processed
%d%% (ID count %d)",
(key_count * 100 / job->numsubordinates), key_count);
started_progress_logging = 1;
@@ -286,7 +286,7 @@ static int ldbm_ancestorid_default_create_index(backend *be, ImportJob
*job)
}
key_count++;
- if(job && !(key_count % PROGRESS_INTERVAL)){
+ if(!(key_count % PROGRESS_INTERVAL)){
import_log_notice(job, "Creating ancestorid index: processed %d%% (ID count
%d)",
(key_count * 100 / job->numsubordinates), key_count);
started_progress_logging = 1;
@@ -484,7 +484,7 @@ static int ldbm_ancestorid_new_idl_create_index(backend *be, ImportJob
*job)
}
key_count++;
- if(job && !(key_count % PROGRESS_INTERVAL)){
+ if(!(key_count % PROGRESS_INTERVAL)){
import_log_notice(job, "Creating ancestorid index: progress %d%% (ID
count %d)",
(key_count * 100 / job->numsubordinates), key_count);
started_progress_logging = 1;