This is an automated email from the git hooks/post-receive script.
mreynolds pushed a commit to branch 389-ds-base-1.3.10 in repository 389-ds-base.
The following commit(s) were added to refs/heads/389-ds-base-1.3.10 by this push: new 52df7d9 Issue 49624 - modrdn silently fails if DB deadlock occurs 52df7d9 is described below
commit 52df7d95c6c201f0270a8f9c5b2a5389dc6ed141 Author: Mark Reynolds mreynolds@redhat.com AuthorDate: Thu Aug 22 10:26:24 2019 -0400
Issue 49624 - modrdn silently fails if DB deadlock occurs
Bug Description:
If a DB Deadlock error occurs during a modrdn operation the entry cache gets updated (corrupted), but the update is not applied to the database.
Fix Description:
Looks like there was a copy & paste error, and the wrong attribute was updated during the retry of the modrdn operation.
relates: https://pagure.io/389-ds-base/issue/49624
Reviewed by: lkrispenz (Thanks!) --- ldap/servers/slapd/back-ldbm/ldbm_modrdn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ldap/servers/slapd/back-ldbm/ldbm_modrdn.c b/ldap/servers/slapd/back-ldbm/ldbm_modrdn.c index 65610d6..433ed88 100644 --- a/ldap/servers/slapd/back-ldbm/ldbm_modrdn.c +++ b/ldap/servers/slapd/back-ldbm/ldbm_modrdn.c @@ -251,7 +251,7 @@ ldbm_back_modrdn(Slapi_PBlock *pb) slapi_pblock_get(pb, SLAPI_MODRDN_NEWSUPERIOR_SDN, &dn_newsuperiordn); slapi_sdn_free(&dn_newsuperiordn); slapi_pblock_set(pb, SLAPI_MODRDN_NEWSUPERIOR_SDN, orig_dn_newsuperiordn); - orig_dn_newsuperiordn = slapi_sdn_dup(orig_dn_newsuperiordn); + dn_newsuperiordn = slapi_sdn_dup(orig_dn_newsuperiordn); /* must duplicate ec before returning it to cache, * which could free the entry. */ if ((tmpentry = backentry_dup(original_entry ? original_entry : ec)) == NULL) {
389-commits@lists.fedoraproject.org