Please review: [Bug 514770] GER, Paged Results: remove per-entry response control
by Noriko Hosoi
Summary: GER, Paged Results: remove per-entry response control
https://bugzilla.redhat.com/show_bug.cgi?id=514770
Description of problem:
Currently, Simple Paged Results and GER returns response control per-entry.
Since per entry-response controls (except for persistent search EntryChange
controls) are ignored by the ldapsearch client, we are getting rid of the
unnecessary write_controls calls for Simple Paged Results and GER
[Proposed Fix]
Created an attachment (id=355712)
--> (https://bugzilla.redhat.com/attachment.cgi?id=355712)
git patch file for result.c
File: ldap/servers/slapd/result.c
Fix description: Getting rid of the unnecessary write_controls calls for GER
and Simple Paged Results.
Note: both GER and Simple Paged Results add its control to the result controls
maintained in the "operation" and they are sent to the client via
send_ldap_result.
14 years, 4 months
Please review: Apply SYNTAX_DN to Name And Optional UID
by Noriko Hosoi
>From ff6d5df121f3c1db93a8dac7ffe69c96a14ae74a Mon Sep 17 00:00:00 2001
From: Noriko Hosoi <nhosoi(a)redhat.com>
Date: Wed, 29 Jul 2009 18:28:01 -0700
Subject: [PATCH] Apply SYNTAX_DN to Name And Optional UID
Based on RFC2252, NameAndOptionalUID = DistinguishedName [ "#" bitstring ]
---
ldap/servers/plugins/syntaxes/nameoptuid.c | 13 +++++++------
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/ldap/servers/plugins/syntaxes/nameoptuid.c b/ldap/servers/plugins/syntaxes/nameoptuid.c
index 70b760a..2086aa9 100644
--- a/ldap/servers/plugins/syntaxes/nameoptuid.c
+++ b/ldap/servers/plugins/syntaxes/nameoptuid.c
@@ -112,7 +112,7 @@ nameoptuid_filter_ava(
Slapi_Value **retVal
)
{
- return( string_filter_ava( bvfilter, bvals, SYNTAX_CIS,
+ return( string_filter_ava( bvfilter, bvals, SYNTAX_CIS | SYNTAX_DN,
ftype, retVal ) );
}
@@ -126,7 +126,8 @@ nameoptuid_filter_sub(
Slapi_Value **bvals
)
{
- return( string_filter_sub( pb, initial, any, final, bvals, SYNTAX_CIS ) );
+ return( string_filter_sub( pb, initial, any, final, bvals,
+ SYNTAX_CIS | SYNTAX_DN ) );
}
static int
@@ -137,7 +138,7 @@ nameoptuid_values2keys(
int ftype
)
{
- return( string_values2keys( pb, vals, ivals, SYNTAX_CIS,
+ return( string_values2keys( pb, vals, ivals, SYNTAX_CIS | SYNTAX_DN,
ftype ) );
}
@@ -150,7 +151,7 @@ nameoptuid_assertion2keys_ava(
)
{
return(string_assertion2keys_ava( pb, val, ivals,
- SYNTAX_CIS, ftype ));
+ SYNTAX_CIS | SYNTAX_DN, ftype ));
}
static int
@@ -163,7 +164,7 @@ nameoptuid_assertion2keys_sub(
)
{
return( string_assertion2keys_sub( pb, initial, any, final, ivals,
- SYNTAX_CIS ) );
+ SYNTAX_CIS | SYNTAX_DN ) );
}
static int nameoptuid_compare(
@@ -171,7 +172,7 @@ static int nameoptuid_compare(
struct berval *v2
)
{
- return value_cmp(v1, v2, SYNTAX_CIS, 3 /* Normalise both values */);
+ return value_cmp(v1, v2, SYNTAX_CIS | SYNTAX_DN, 3 /* Normalise both values */);
}
static int
--
1.6.2.5
14 years, 4 months
AUTO: Samuel Graenacher is out of the office. (returning 08/10/2009)
by Samuel Graenacher
I am out of the office until 08/10/2009.
For very urgent matters you may contact Mr. Andre Krutein or Mr. Dominik
Baumeler. Otherwise I will respond soon after I get back.
Note: This is an automated response to your message "Re: [389-devel]
Please review: LDAP Dereference Control support" sent on 30.07.2009
02:28:42.
This is the only notification you will receive while this person is away.
14 years, 4 months
Bug in windows replication
by Peter Sandström
The entry is added before the check for wierd values, causing it to fail.
The following patch fixes it.
diff -ru fedora-ds-base-1.2.0-orig/ldap/servers/plugins/replication/windows_connection.c
fedora-ds-base-1.2.0/ldap/servers/plugins/replication/windows_connection.c
--- fedora-ds-base-1.2.0-orig/ldap/servers/plugins/replication/windows_connection.c
2008-12-05 17:41:52.000000000 -0500
+++ fedora-ds-base-1.2.0/ldap/servers/plugins/replication/windows_connection.c
2009-07-28 05:13:40.564546527 -0400
@@ -542,7 +542,6 @@
for ( a = ldap_first_attribute( ld, msg, &ber ); a!=NULL;
a=ldap_next_attribute( ld, msg, ber ) )
{
struct berval ** aVal = ldap_get_values_len( ld, msg, a);
- slapi_entry_add_values(rawentry, a, aVal);
if (0 == strcasecmp(a,"dnsRecord") || 0 ==
strcasecmp(a,"dnsproperty") ||
0 == strcasecmp(a,"dscorepropagationdata"))
@@ -556,6 +555,7 @@
;
} else
{
+ slapi_entry_add_values(rawentry, a, aVal);
if (attrsonly)
{
slapi_entry_add_value(e, a,
(Slapi_Value *)NULL);
--
Peter Sandström
Head of Operations, Stardoll AB
phone: +46 (0)70 456 05 28
e-mail: peter(a)stardoll.com | stardoll: pj0tr
mail/visit: Hudiksvallsgatan 8, 113 30 Stockholm, Sweden
www.stardoll.com - Fame, fashion and friends
14 years, 4 months
Re: Please Review: Change aci attribute syntax to Directory String (Nathan Kinder)
by Howard Chu
> The aci attribute is currently defined with a syntax of IA5 String.
> This syntax only allows 7-bit characters. Now that the server has
> support for syntax validation, this would prevent one from using
> international characters in aci rules. This patch defines the aci
> attribute with the Directory String syntax, which allows any valid
> UTF8 character.
Y'know, LDAP/X.500 requires that existing schema items must never be changed
once they're in use. When you want to change something like this, usually you
must define a new attributeType with a new OID for the purpose. Probably not
so important given the history of schema checking in this code, but an fyi...
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/
14 years, 4 months