389-devel September 2009

389-devel@lists.fedoraproject.org

5 participants
37 discussions

Please review: Bug 518279 - logs created at startup can get wrong file mode
by Rich Megginson 22 Sep '09

22 Sep '09

logs created at startup can get wrong file mode https://bugzilla.redhat.com/show_bug.cgi?id=518279 Resolves: bug 518279 Bug Description: logs created at startup can get wrong file mode Reviewed by: ??? Fix Description: Try to apply the mode using chmod() if a log file has been Platforms tested: RHEL5 x86_64 Flag Day: no Doc impact: no https://bugzilla.redhat.com/attachment.cgi?id=362149&action=diff

1 0

Re: [Bug 495522] Start script hardcodes file permissions mask to 077 (600), so the nsslapd-*log-mode configuration attributes don't work
by Rich Megginson 22 Sep '09

22 Sep '09

bugzilla(a)redhat.com wrote: > Please do not reply directly to this email. All additional > comments should be made in the comments box of this bug. > > > https://bugzilla.redhat.com/show_bug.cgi?id=495522 > > > Nathan Kinder <nkinder(a)redhat.com> changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > CC| |nkinder(a)redhat.com > Devel Whiteboard|comment#1.review? |comment#1.review+nkinder > > Thanks - pushed to master

1 0

Please review: Bug 495522 - Start script hardcodes file permissions mask to 077 (600), so the nsslapd-*log-mode configuration attributes don't work
by Rich Megginson 22 Sep '09

22 Sep '09

Start script hardcodes file permissions mask to 077 (600), so the nsslapd-*l https://bugzilla.redhat.com/show_bug.cgi?id=495522 Resolves: bug 495522 Bug Description: Start script hardcodes file permissions mask to 077 (600), Reviewed by: ??? Fix Description: Use umask 002 for the directory server process Note that I'm not sure why the init script set the umask to 077 in the first place - probably copied from some boilerplate - it's probably ok to use 000, but 002 at least affords some minimal protection. Platforms tested: Fedora 11 x86_64 Flag Day: no Doc impact: no https://bugzilla.redhat.com/attachment.cgi?id=362142&action=diff

1 0

Please Review: Don't build policy module from Makefile
by Nathan Kinder 22 Sep '09

22 Sep '09

2 2

Re: [Bug 520483] setup-ds-admin.pl: Can't call method "getErrorString" on an undefined value at /usr/lib64/dirsrv/perl/AdminUtil.pm line 405.
by Rich Megginson 22 Sep '09

22 Sep '09

bugzilla(a)redhat.com wrote: > Please do not reply directly to this email. All additional > comments should be made in the comments box of this bug. > > > https://bugzilla.redhat.com/show_bug.cgi?id=520483 > > > Nathan Kinder <nkinder(a)redhat.com> changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > CC| |nkinder(a)redhat.com > Devel Whiteboard|comment#2.review? |comment#2.review+nkinder > Thanks - pushed to master.

1 0

Please review: Bug 520483 - setup-ds-admin.pl: Can't call method "getErrorString" on an undefined value at /usr/lib64/dirsrv/perl/AdminUtil.pm line 405.
by Rich Megginson 21 Sep '09

21 Sep '09

https://bugzilla.redhat.com/show_bug.cgi?id=520483 Resolves: bug 520483 Bug Description: setup-ds-admin.pl: Can't call method "getErrorString" on an undefined value at /usr/lib64/dirsrv/perl/AdminUtil.pm line 405. Reviewed by: ??? Files: see diff Fix Description: Just use "unknown" as the error string. Platforms tested: Fedora 11 x86_64 Flag Day: no Doc impact: no https://bugzilla.redhat.com/attachment.cgi?id=362022&action=diff

1 0

Please review: Bug 523476 - 389-ds-base/glibmm24: conflicting perl provides
by Rich Megginson 21 Sep '09

21 Sep '09

Basically just rename Util to DSUtil https://bugzilla.redhat.com/attachment.cgi?id=362019&action=diff https://bugzilla.redhat.com/attachment.cgi?id=362020&action=diff

1 1

Please review: Running setup-ds-admin.pl -u on replica with ldaps chokes on CA cert
by Rich Megginson 21 Sep '09

21 Sep '09

2 2

Re: [389-devel] Please review: Add update code - make setup-ds.pl -u do updates
by Rich Megginson 21 Sep '09

21 Sep '09

Noriko Hosoi wrote: > On 09/17/2009 04:12 PM, Rich Megginson wrote: >> >> ------------------------------------------------------------------------ >> >> -- >> 389-devel mailing list >> 389-devel(a)redhat.com >> https://www.redhat.com/mailman/listinfo/fedora-directory-devel >> > Hi Rich, > > I noticed these 2 minor things. Other than these, your patch looks good. Thanks. Fixed and pushed to master. To ssh://git.fedorahosted.org/git/389/ds.git 2de80f5..cc89083 master -> master commit cc89083f1177606d4cbbb52f8cdc5e34d0d16f70 Author: Rich Megginson <rmeggins(a)redhat.com> Date: Wed Sep 9 17:01:49 2009 -0600 Add update code - make setup-ds.pl -u do updates > > diff --git a/ldap/admin/src/scripts/Setup.pm.in > b/ldap/admin/src/scripts/Setup.pm.in > index 7ad57c1..f314d67 100644 > --- a/ldap/admin/src/scripts/Setup.pm.in > +++ b/ldap/admin/src/scripts/Setup.pm.in > @@ -142,6 +145,7 @@ sub init { > $self->{keep} = $keep; > $self->{preonly} = $preonly; > $self->{update} = $update; > + $self->{force} = *$update;* <== could this be "$force"? > $self->{logfile} = $logfile; > $self->{log} = new SetupLog($self->{logfile}); > # if user supplied inf file, use that to initializ > > > diff --git a/ldap/admin/src/scripts/dsupdate.map.in > b/ldap/admin/src/scripts/dsupdate.map.in > new file mode 100644 > +# Copyright (C) *2007* Red Hat, Inc. <== 2009? :) > +# All rights reserved. > +# END COPYRIGHT BLOCK > > --noriko >

1 0

Please review: Add update code - make setup-ds.pl -u do updates
by Rich Megginson 21 Sep '09

21 Sep '09

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

389-devel September 2009