389-devel November 2013

389-devel@lists.fedoraproject.org

10 participants
51 discussions

please review: Ticket 47599 - Reduce lock scope in retro changelog plug-in
by Mark Reynolds 19 Nov '13

19 Nov '13

https://fedorahosted.org/389/ticket/47599 https://fedorahosted.org/389/attachment/ticket/47599/0001-Ticket-47599-Redu… -- Mark Reynolds 389 Development Team Red Hat, Inc mreynolds(a)redhat.com

1 1

Ticket #47384 (plugin library path validation) and out-of-tree modules
by Nalin Dahyabhai 19 Nov '13

19 Nov '13

Hi, everyone. I was recently adding a couple of changes to slapi-nis, and when I went to run its self-tests, some of the tests that modify the plugin entry started failing with LDAP_UNWILLING_TO_PERFORM. I tracked the denial down to validation code that was added as part of ticket #47384. While the tests don't modify the nsslapd-pluginPath attribute (the entry's added to dse.ldif before the server starts up), some make other changes to the plugin entry, and when they attempt that, check_plugin_path() rejects the modify request. The checks that were added, which ensure that plugins are only loaded from the server's plugin directory, make it kind of difficult to run tests using the copies of plugins in my build tree. The language in the ticket description's pretty firm that this isn't going to be changed, and while I can _probably_ work around it on my end, I figured I'd ask here before going down that route: is there room to expand this check to a whitelist, a search path, or some other method that could be used to provide for my use case? Thanks, Nalin

2 3

Please review: take 2: Ticket #47596 attrcrypt fails to find unlocked key
by Rich Megginson 19 Nov '13

19 Nov '13

This passes continuous integration testing https://fedorahosted.org/389/attachment/ticket/47596/0001-Ticket-47596-attr…

1 0

revised: Ticket 47599 - Reduce lock scope in retro changelog plug-in
by Mark Reynolds 19 Nov '13

19 Nov '13

https://fedorahosted.org/389/ticket/47599 https://fedorahosted.org/389/attachment/ticket/47599/0001-Ticket-47599-Redu… -- Mark Reynolds 389 Development Team Red Hat, Inc mreynolds(a)redhat.com

1 0

please review: Ticket 47598 - Convert ldbm_back_seq code to be transaction aware
by Mark Reynolds 19 Nov '13

19 Nov '13

https://fedorahosted.org/389/ticket/47598 https://fedorahosted.org/389/attachment/ticket/47598/0001-Ticket-47598-Conv… -- Mark Reynolds 389 Development Team Red Hat, Inc mreynolds(a)redhat.com

1 0

Please review ticket 47590 (take #4): add/split functions around replication
by thierry bordaz 19 Nov '13

19 Nov '13

This review takes into account the recommendations of last review: * It creates a checkProperties function This function take properties from a dict. It checks and set the properties into the LDAP entry of the replication agreement. It can checks the coherency of the properties as well as sets default values. This function translates what will be CLI properties into replication agreement parameters. In addition to recommendations of previous reviews * Create a Agreement class in brooker * mv init/status/schedule/create in that new class * mv createDefaultReplMgr into the brooker replica class with the function create_repl_manager() * Handling of error condition with exceptions What is not implemented in that review, that will be implemented with https://fedorahosted.org/389/ticket/47600: * Cleanup of createAgreement (use of exception). This function will likely be replace by agreement.create(). * Cleanup of enableReplication (use of exception, move under replica.create()) https://fedorahosted.org/389/attachment/ticket/47590/0004-Ticket-47590-CI-t…

1 0

Please review: Ticket #47596 attrcrypt fails to find unlocked key
by Rich Megginson 18 Nov '13

18 Nov '13

https://fedorahosted.org/389/attachment/ticket/47596/0001-Ticket-47596-attr…

1 0

please review: Ticket 47597 - Convert retro changelog plug-in to betxn
by Mark Reynolds 18 Nov '13

18 Nov '13

Plug-in was already betxn aware, but the default plugin type was object. https://fedorahosted.org/389/ticket/47597 https://fedorahosted.org/389/attachment/ticket/47597/0001-Ticket-47597-Conv… -- Mark Reynolds 389 Development Team Red Hat, Inc mreynolds(a)redhat.com

1 0

Please review ticket 47590 (take #3): add/split functions around replication
by thierry bordaz 18 Nov '13

18 Nov '13

This review takes into account the recommendations of previous review: * Create a Agreement class in brooker * mv init/status/schedule/create in that new class * mv createDefaultReplMgr into the brooker replica class with the function create_repl_manager() * Handling of error condition with exceptions What is not implemented in that review, that will be implemented with https://fedorahosted.org/389/ticket/47600: * Cleanup of createAgreement (use of exception). This function will likely be replace by agreement.create(). * Cleanup of enableReplication (use of exception, move under replica.create()) https://fedorahosted.org/389/attachment/ticket/47590/0003-Ticket-47590-CI-t…

1 0

Please review ticket 47590 (take #2): add/split functions around replication
by thierry bordaz 18 Nov '13

18 Nov '13

Hi, this is a second review to take into account the recommendation of the first review. Major changes are: * Create a replicaagreement class in brooker * mv init/status/schedule/create in that new class * mv createDefaultReplMgr into the brooker replica class * Handling of error condition with exceptions https://fedorahosted.org/389/attachment/ticket/47590/0002-Ticket-47590-CI-t…

2 2

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

389-devel November 2013