389-devel September 2015

389-devel@lists.fedoraproject.org

10 participants
40 discussions

Git rights for QE team
by Simon Pichugin 09 Oct '15

09 Oct '15

Hi Nathan, Hi Mark, Hi team, as I know, we've decided to make me "gatekeeper" of QE team for managing lib389 and DS git repos. Can you please update the status of this situation? Also, there is two tickets with new reviewed testcases, that need to be pushed. Can you please help me with that? Or if I'll get the rights soon, I do it by myself. :) https://fedorahosted.org/389/ticket/47957 https://fedorahosted.org/389/ticket/48264 Thanks, Simon

2 4

Please review (take 2): [389 Project] #48299: pagedresults - when timed out, search results could have been already freed.
by Noriko Hosoi 30 Sep '15

30 Sep '15

https://fedorahosted.org/389/ticket/48299 https://fedorahosted.org/389/attachment/ticket/48299/0001-Ticket-48299-page… git patch file (master) -- revised; fixed a bug pointed out by Thierry (Thank you!!) and a minor memory leak. On 09/30/2015 01:32 AM, 389 Project wrote: > Comment (by tbordaz): > > Hi noriko, > > The fix looks good, just two remarks > * pagedresults_set_search_result_pb is called each time search result is > freed. Should not it be called in opshared.c:722 (I find this line > suspicious should not it be SLAPI_PAGED_RESULTS_INDEX ?) > * in pagedresults_set_search_result_pb, you call slapi_pblock_set(pb, > SLAPI_PAGED_RESULTS_INDEX, &index); . My understanding it is to reset the > pr_idx (index==-1). But later you test 'index'. Did you mean > slapi_pblock_'''get'''(pb, SLAPI_PAGED_RESULTS_INDEX, &index). >

1 0

Please review (revised): [389 Project] #48298: ns-slapd crash during ipa-replica-manage del
by Noriko Hosoi 30 Sep '15

30 Sep '15

https://fedorahosted.org/389/ticket/48298 https://fedorahosted.org/389/attachment/ticket/48298/0001-Ticket-48298-ns-s… git patch file (master) -- different approach -- revised following the reviews by Rich (Thank you!!)

1 0

Please review (test failed ==> a new approach): [389 Project] #48298: ns-slapd crash during ipa-replica-manage del
by Noriko Hosoi 29 Sep '15

29 Sep '15

https://fedorahosted.org/389/ticket/48298 https://fedorahosted.org/389/attachment/ticket/48298/0001-Ticket-48298-ns-s… On 09/29/2015 08:15 AM, 389 Project wrote: > Comment: > > Unfortunately, it did not pass the IPA tests. > Bug Description: The cause of the problem is rather not a race condition but accessing an already freed agreement in a plug-in: > The crashed thread is deleting an agreement object, which calls mep_pre_op. > It eventually calls op_shared_search with the deleted agreement object with > base scope and filter "(|(objectclass=*)(objectclass=ldapsubentry))" > Since it is a DSE entry it goes to dse_search, in which it calls agmt_get_ > replarea and crashes in slapi_sdn_copy by NULL dereference in from SDN... Fix Description: This patch adds the check to agmt_get_replarea, in which if the agreement is not in the agreement list, it returnes NULL repl area. When the NULL repl area is returned the callers back off with an error. Thanks, --noriko

1 0

Please review: [389 Project] #48299: pagedresults - when timed out, search results could have been already freed.
by Noriko Hosoi 29 Sep '15

29 Sep '15

https://fedorahosted.org/389/ticket/48299 https://fedorahosted.org/389/attachment/ticket/48299/0001-Ticket-48299-page…

1 0

Please review (take 3): [389 Project] #48298: ns-slapd crash during ipa-replica-manage del
by Noriko Hosoi 29 Sep '15

29 Sep '15

https://fedorahosted.org/389/ticket/48298 https://fedorahosted.org/389/attachment/ticket/48298/0001-Ticket-48298-ns-s… git patch file (master) -- merged the 2 patches and revised to avoid the self deadlock.

1 0

Please review (additional fixes - take 2): [389 Project] #48298: ns-slapd crash during ipa-replica-manage del
by Noriko Hosoi 29 Sep '15

29 Sep '15

https://fedorahosted.org/389/ticket/48298 https://fedorahosted.org/389/attachment/ticket/48298/0001-Ticket-48298-ns-s… git patch file (master) -- revised the previous patch following the comments by Rich (take 2)

1 0

Please review (additional fixes): [389 Project] #48298: ns-slapd crash during ipa-replica-manage del
by Noriko Hosoi 28 Sep '15

28 Sep '15

https://fedorahosted.org/389/ticket/48298 https://fedorahosted.org/389/attachment/ticket/48298/0001-Ticket-48298-ns-s… git patch file (master) -- additional fixes (merge them when commit) Thank you, Rich, for the reviews and comments. Do you think (1) is overkill? Description: In addition to the previous patch for #48298, 1) agmt_delete - lock all the agreement deletion in PR_Lock(ra->lock). 2) get_agmt_status - retrieve all the ra contents in PR_Lock(ra->lock) first and use them in the function. --noriko

1 0

Please review: [389 Project] #48298: ns-slapd crash during ipa-replica-manage del
by Noriko Hosoi 28 Sep '15

28 Sep '15

https://fedorahosted.org/389/ticket/48298 https://fedorahosted.org/389/attachment/ticket/48298/0001-Ticket-48298-ns-s…

1 0

please review: Ticket 48204 - Add support for python3 to lib389 and DS
by Mark Reynolds 25 Sep '15

25 Sep '15

https://fedorahosted.org/389/ticket/48204 lib389 patch https://fedorahosted.org/389/attachment/ticket/48204/0001-Ticket-48204-upda… 389-ds-base patch https://fedorahosted.org/389/attachment/ticket/48204/0001-Ticket-48204-upda…

1 2

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

389-devel September 2015