389-devel March 2018

389-devel@lists.fedoraproject.org

5 participants
9 discussions

Please review: Issue 49109 - nsDS5ReplicaTransportInfo should accept StartTLS as an option
by Simon Pichugin 17 Apr '18

17 Apr '18

Hi team, please, review: https://pagure.io/389-ds-base/issue/49109 https://pagure.io/389-ds-base/pull-request/49613 Thanks, Simon

1 3

please review: Ticket 49618 - Fix compiler warnings on arm
by Mark Reynolds 27 Mar '18

27 Mar '18

Note - this did pass coverity scans. https://pagure.io/389-ds-base/pull-request/49621

1 1

Please review: Ticket 49601 - Replace HAVE_SYSTEMD define with WITH_SYSTEMD in svrcore
by Matus Honek 26 Mar '18

26 Mar '18

https://pagure.io/389-ds-base/issue/49601#comment-501820 https://pagure.io/389-ds-base/issue/raw/files/12f4095f8d725d76f60882d2a844a… -- Matus Honek Associate Software Engineer Red Hat Czech

1 0

Please review: 389-ds-base package rebuilt on EPEL can't be installed due to missing dependencies
by Viktor Ashirov 16 Mar '18

16 Mar '18

https://pagure.io/389-ds-base/issue/49603 https://pagure.io/389-ds-base/pull-request/49604

1 0

please review: Ticket 49599 - Revise replication total update status messages
by Mark Reynolds 12 Mar '18

12 Mar '18

https://pagure.io/389-ds-base/issue/49599 https://pagure.io/389-ds-base/issue/raw/files/615a6b5b74bae5d55189fdebd8841…

1 0

Use of int types in the code base,
by William Brown 12 Mar '18

12 Mar '18

Hi there, http://www.port389.org/docs/389ds/development/coding-style.html#types In a few reviews I still see this sometimes. It's pretty important that we keep moving our quality standard higher, and having known type sizes is important to this. Types like int and long are unknown sizes until you compile it depending on platform. As a result, it's really important we use the intX_t and uintX_t types so we have guarantees of our values. I would encourage the use of int64_t and uint64_t, because while they are "larger", it's significantly faster for a modern 64bit system to process these values than their 32bit counterparts. Another note is that arrays index by size_t, not 'int', so we should always keep this in mind. Finally, because we are using c99 now, this means we should avoid: size_t i = 0; for (i = 0; i < cond; i++) { ... } When we really should scope our values. Scoping is good because it limits possibility of data corruption to flow and other mistakes such as re-use of values. This means: for (size_t i = 0; i < cond; i++) { ... } Thanks! -- Thanks, William Brown

2 5

Please review: Issue 49593 - NDN cache stats should be under the global stats
by Simon Pichugin 08 Mar '18

08 Mar '18

Hi team, please, review: https://pagure.io/389-ds-base/pull-request/49595 https://pagure.io/389-ds-base/issue/49593 Thanks, Simon

1 2

please review: Ticket 49596 - repl-monitor.pl fails to find RUV entry
by Mark Reynolds 07 Mar '18

07 Mar '18

master branch only https://pagure.io/389-ds-base/issue/49596 https://pagure.io/389-ds-base/issue/raw/files/f6a2c1a621d1612d23e113bb064d6…

1 0

Please review: Issue 49572 - ns_job_wait race on condvar
by Simon Pichugin 02 Mar '18

02 Mar '18

Hi team, please, review a small fix for nunc-stance tests: https://pagure.io/389-ds-base/issue/49572 https://pagure.io/389-ds-base/pull-request/49592 Thanks, Simon

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

389-devel March 2018