389-devel October 2020

389-devel@lists.fedoraproject.org

6 participants
51 discussions

Roadmap for rust as a requirement in the project
by William Brown 14 Oct '20

14 Oct '20

Hi all, Background: https://pagure.io/389-ds-base/issue/51140 Ludwig and Mark both raised some good points here. First is that features today (EntryUUID, LDAPSsoToken) are both locked behind another language. Rightly so, they shouldn't be hidden here forever. As well, Mark wants to ask what it would take to enable by default. ** Why did I use the fedse.c to load a plugin entry? Because we don't (fully) support startup migrations yet. Mark has privately reminded me that he has reviewed https://pagure.io/389-ds-base/pull-request/49579 and that I should revive it. This v4 plugin adds a stateful assertion of entries allowing better migrations beyond what fedse.c's bootstrap can achieve. IE we can create an entry if it does not exist, and modify it partially if an admin has changed it (ie we can tweak defaults but without affecing say pluginEnabled). There was an issue viktor raised about pbkdf2 where it could not be disabled, and this would resolve it. Most likely, I will break the on startup migrations out from the v4 plugin patch set, and make it it's own change, and move some of the content from fedse.c and friends into this. ** TODO list to get rust enabled by default. I think there is still a bit of work to do to enable by default, but I think we are pretty close. Roughly ordered, this is the list of things that has to happen to let us enable rust by default. - everyone -> test that you can build and run tests with --enable-rust --disable-asan in your development environment so that we can work out and issues that may exist for us as developers. - william -> fix the intentional name leak in the rust slapi plugin interface to use lazy_static. Today this triggers LSAN which breaks basic test suites. - william -> clean up libsds linking and some of the related elements - william -> revive and make on upgrade configs better (see above), potentially break it out from the v4 plugin patch. - william + mark -> check that our respective major distros/releases can build with --enable-rust in release rpms - william + viktor -> check that we can pass with --enable-rust and --enable-asan, especially in CI - anyone interested -> update wiki contributing guide to include rust as a requirement - (optional) anyone interested (but not william) -> add a section to the wiki on using rust in development - team -> agree we are happy, and make configure.ac have --enable-rust by default - team -> after a few weeks / months, remove the ifdefs, duplicate C versions of Rust features, and enable/disable features from configure.ac Does this seem reasonable to everyone? I really want to make sure we do this right as a team, and we are all happy with it (I don't want a repeat of nunc-stans ;) ). If we agree on this, I will open some tickets up, add the relevant blocks/ordering and assign out the work. Thank you all! — Sincerely, William Brown Senior Software Engineer, 389 Directory Server SUSE Labs

2 3

please review: PR 4378 - suffix management in backends is incorrect
by Mark Reynolds 14 Oct '20

14 Oct '20

https://github.com/389ds/389-ds-base/pull/4378 -- 389 Directory Server Development Team

1 0

389 DS nightly 2020-10-14 - 95% PASS
by vashirov＠redhat.com 14 Oct '20

14 Oct '20

https://fedorapeople.org/groups/389ds/ci/nightly/2020/10/14/report-389-ds-b…

1 0

please review: PR 4331 - import ldif2cl task should not close all changelogs
by Mark Reynolds 14 Oct '20

14 Oct '20

https://github.com/389ds/389-ds-base/pull/4331 -- 389 Directory Server Development Team

1 2

Please review : 4372 bindmech not correctly validated in chaining db
by William Brown 12 Oct '20

12 Oct '20

https://github.com/389ds/389-ds-base/pull/4374 — Sincerely, William Brown Senior Software Engineer, 389 Directory Server SUSE Labs, Australia

1 0

389 DS nightly 2020-10-09 - 94% PASS
by vashirov＠redhat.com 09 Oct '20

09 Oct '20

https://fedorapeople.org/groups/389ds/ci/nightly/2020/10/09/report-389-ds-b…

1 0

please review: PR 4369 - ds-replcheck crashes when handling glue entries
by Mark Reynolds 09 Oct '20

09 Oct '20

https://github.com/389ds/389-ds-base/pull/4369 -- 389 Directory Server Development Team

1 0

389 DS nightly 2020-10-08 - 94% PASS
by vashirov＠redhat.com 08 Oct '20

08 Oct '20

https://fedorapeople.org/groups/389ds/ci/nightly/2020/10/08/report-389-ds-b…

1 0

Reminder about git commit headers
by Mark Reynolds 07 Oct '20

07 Oct '20

Hello, Seems like everyone is doing something different with the commit headers, and I've been wanting to address it. I'd prefer we use "Issue ####" and stop using "Ticket ####". Most developers are using "Issue ###", but some are still using "Ticket", so I always have to tweak this when doing upstream builds and writing the release notes. https://www.port389.org/docs/389ds/contributing.html#getting-the-patch-ready We silently switched to using "Issue ####" when we went to Pagure, but it was never officially stated. Moving forward I'd really appreciate it if everyone used "Issue #### - <description>" as the first line in your commits. Note the hyphen before the issue description. Also please don't use colons, just use "Issue 4444 - My description of this patch". It just makes doing upstream releases and wiki updates easier. Thanks, Mark -- 389 Directory Server Development Team

1 0

Please Review: Template --advanced flag
by William Brown 07 Oct '20

07 Oct '20

https://github.com/389ds/389-ds-base/pull/4362 — Sincerely, William Brown Senior Software Engineer, 389 Directory Server SUSE Labs, Australia

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

389-devel October 2020