Send 389-devel mailing list submissions to
389-devel@lists.fedoraproject.orgTo subscribe or unsubscribe via the World Wide Web, visit
https://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.orgor, via email, send a message with subject or body 'help' to
389-devel-request@lists.fedoraproject.orgYou can reach the person managing the list at
389-devel-owner@lists.fedoraproject.orgWhen replying, please edit your Subject line so it is more specific
than "Re: Contents of 389-devel digest..."
Today's Topics:
1. please review: Ticket 48972 - remove old legacy password policy code that used ACI's
(Mark Reynolds)
2. Jenkins build is back to normal : 389-DS-COMMIT #93 (Jenkins)
3. Adding vCard Schema (
kashefi@arissystem.com)
4. Re: Adding vCard Schema (Rich Megginson)
5. Jenkins build is back to normal : 389-DS-CI #63 (Jenkins)
6. Reminder: Please Review: ns + ds tickets (William Brown)
7. Sign compare checking (William Brown)
8. Re: Sign compare checking (William Brown)
----------------------------------------------------------------------
Date: Fri, 26 Aug 2016 18:57:57 -0400
From: Mark Reynolds <
mareynol@redhat.com>
Subject: [389-devel] please review: Ticket 48972 - remove old legacy
password policy code that used ACI's
To: "389 Directory server developer discussion."
<
389-devel@lists.fedoraproject.org>
Message-ID: <
ef84c49e-52dd-27b0-d6eb-60e7b2134186@redhat.com>
Content-Type: text/plain; charset=utf-8
https://fedorahosted.org/389/ticket/48972https://fedorahosted.org/389/attachment/ticket/48972/0001-Ticket-48972-remove-old-pwp-code-that-adds-removes-A.patch------------------------------
Date: Sat, 27 Aug 2016 04:50:00 +0200 (CEST)
From: Jenkins <
mareynol@redhat.com>
Subject: [389-devel] Jenkins build is back to normal : 389-DS-COMMIT
#93
To:
389-devel@lists.fedoraproject.org,
mareynol@redhat.com,
mreynolds@redhat.comMessage-ID: <
770701762.0.1472266200038.JavaMail.jenkins@vm-058-081.abc .idm.lab.eng.brq.redhat.com>
Content-Type: text/plain; charset=UTF-8
See <
http://vm-058-081.abc.idm.lab.eng.brq.redhat.com:8080/job/389-DS-COMMIT/93/>
------------------------------
Date: Sat, 27 Aug 2016 11:49:19 -0000
From:
kashefi@arissystem.comSubject: [389-devel] Adding vCard Schema
To:
389-devel@lists.fedoraproject.orgMessage-ID:
<
20160827114919.10245.90701@mailman01.phx2.fedoraproject.org>
Content-Type: text/plain; charset="utf-8"
Hello,
Is it possible for you to include vCard schema in 389ds by default?
https://tools.ietf.org/html/draft-gryphon-ldap-schema-vcard4-00Best Regards
Kianoosh Kashefi
------------------------------
Date: Sat, 27 Aug 2016 08:17:52 -0600
From: Rich Megginson <
rmeggins@redhat.com>
Subject: [389-devel] Re: Adding vCard Schema
To: "389 Directory server developer discussion."
<
389-devel@lists.fedoraproject.org>
Message-ID: <
78d805bd-ba1d-ed7e-b14f-07a41fa7a755@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
On 08/27/2016 05:49 AM,
kashefi@arissystem.com wrote:
> Hello,
>
> Is it possible for you to include vCard schema in 389ds by default?
>
>
https://tools.ietf.org/html/draft-gryphon-ldap-schema-vcard4-00Please file a ticket at
https://fedorahosted.org/389/newticket>
> Best Regards
> Kianoosh Kashefi
> --
> 389-devel mailing list
>
389-devel@lists.fedoraproject.org>
https://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org------------------------------
Date: Sun, 28 Aug 2016 04:30:31 +0200 (CEST)
From: Jenkins <
mareynol@redhat.com>
Subject: [389-devel] Jenkins build is back to normal : 389-DS-CI #63
To:
389-devel@lists.fedoraproject.orgMessage-ID: <
59090307.1.1472351431643.JavaMail.jenkins@vm-058-081.abc. idm.lab.eng.brq.redhat.com>
Content-Type: text/plain; charset=UTF-8
See <
http://vm-058-081.abc.idm.lab.eng.brq.redhat.com:8080/job/389-DS-CI/63/>
------------------------------
Date: Mon, 29 Aug 2016 09:34:59 +1000
From: William Brown <
wibrown@redhat.com>
Subject: [389-devel] Reminder: Please Review: ns + ds tickets
To: 389-devel <
389-devel@lists.fedoraproject.org>
Message-ID: <
1472427299.28186.18.camel@redhat.com>
Content-Type: multipart/signed; micalg="pgp-sha1";
protocol="application/pgp-signature";
boundary="=-c34B3GxGrKZ3Mb6sVsh+"
--=-c34B3GxGrKZ3Mb6sVsh+
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Hi,
Nunc-stans, These have been waiting for a while:
https://fedorahosted.org/nunc-stans/ticket/57https://fedorahosted.org/nunc-stans/attachment/ticket/57/0001-Ticket-57-Abi=lity-to-disarm-a-persistent-job-from-wi.patch
https://fedorahosted.org/nunc-stans/ticket/58https://fedorahosted.org/nunc-stans/attachment/ticket/58/0001-Ticket-58-Add=-stress-test.2.patch
Directory Server
https://fedorahosted.org/389/ticket/397https://fedorahosted.org/389/attachment/ticket/397/0001-Ticket-397-Implemen=t-scrypt-hashing-mechanism-for-DS.2.patch
--=20
Sincerely,
William Brown
Software Engineer
Red Hat, Brisbane
--=-c34B3GxGrKZ3Mb6sVsh+
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
iQIcBAABAgAGBQJXw3UjAAoJEISUiynM+PAgl1QQAIeV+zDZy/kv5rM3J5xBJe0f
gVQWANTT0QC9/oCpl9GLCRVHbmzJlribgdoEhmtF0ji+x2o2q2hBEg46GHAzjNQG
6XaBuQvve9U6VB0AcMXxFhH2hT2YFzEhXGF128G9zwO9QXIKkrY6QOH1PujbP7ZK
MiOPzo2bQ9uX0oRWNAGGVi31Jq1IMhuea2xi5YNRm2X5FCGuk2rpceHXb8gXKFJh
D86eKvkU4u8NTjMdkMhRu3aP777jyVRD3EUng+BcVzb46Ok7z0Su8DmO25diWJQe
Icp5j14qSgdClx68uz33RrtUAJdSx0cabHMgHdvqSVvU+x+MBt0lRS/MaBN82bYV
YxCPb5Aezw0tGUVPIoDqBqpcBH81N5P96DymBp87QqO4GHnS2BvNh+Ra3SMJCw6x
3jBFT5/qv7lzsFXYunIwmbryF8wR+FAh2wQOopIzqFiHo7JNFSQ/QIyXo3BOqHZW
mnj9WW+AkQCLHcj4n/3LzccWe7y1VKohsvXulNhwHfGVUR4VIEmJWbmt+SfhDpAS
7B+3y4pI5OjtEA5077lbygcjloOT8eHCwZW1hcujYHHSbUy1VyMJOwS9DsQjCE8W
au8GhEJNkAwUjiHoHFjRVFS+jGXzwJ8GTjC/YeAcb7d7FRGHykYk2/gJZ5o1SIn7
+wHPNcbn7G2ZH+DZwttM
=uGLD
-----END PGP SIGNATURE-----
--=-c34B3GxGrKZ3Mb6sVsh+--
------------------------------
Date: Mon, 29 Aug 2016 14:36:27 +1000
From: William Brown <
wibrown@redhat.com>
Subject: [389-devel] Sign compare checking
To: 389-devel <
389-devel@lists.fedoraproject.org>
Message-ID: <
1472445387.28186.21.camel@redhat.com>
Content-Type: multipart/signed; micalg="pgp-sha1";
protocol="application/pgp-signature";
boundary="=-HwetbhPf/V4gaBe4aI6x"
--=-HwetbhPf/V4gaBe4aI6x
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Hi,
I'm going through the list of sign-compare errors from gcc, and putting
in the appropriate casts (uint -> int normally).
I found in filter.c:
/* openldap does not return LBER_END_OF_SEQORSET -
so check for len =3D=3D -1 - openldap ber_next_element will not
set
len if it has reached the end, and -1 is not a valid value
for a real len */
if ( (tag !=3D LBER_END_OF_SEQORSET) && (len !=3D -1) && (*fstr !=
=3D
NULL) ) {
LDAPDebug( LDAP_DEBUG_ANY, " error parsing filter list
\n", 0, 0, 0 );
slapi_ch_free((void**)fstr );
}
However, len is a ber_len_t, which is a typedef uint. It's actually
impossible for this value to hold a -1.
So either, this is a bug in the way openldap uses the ber_len_t type, we
have a mistake in our logic, or something else hokey is going on.=20
I would like to update this to:
if ( (tag !=3D LBER_END_OF_SEQORSET) && (len =3D=3D 0) && (*fstr !=3D NULL)=
)
Or even:
if ( (tag !=3D LBER_END_OF_SEQORSET) && (*fstr !=3D NULL) )
What do you think of this assessment given the ber_len_t type?=20
--=20
Sincerely,
William Brown
Software Engineer
Red Hat, Brisbane
--=-HwetbhPf/V4gaBe4aI6x
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
iQIcBAABAgAGBQJXw7vLAAoJEISUiynM+PAg2WcP/Ayln23mWYUjdDeM14CceLTM
BI7Dx4OOd+6x9HqbeoLA+cwqESluW6+96E8m1Uv13MJANoXpEyb11/ezKN/ooY91
4ImFFsRRZHQO5Ezk2QBEvxQfk0x2fYFHnv1fRp0MvZf0RTdEZ/iSF3eqKPske06V
sfBOh6RWOmK8FKHLXYr+Si1RxSrOojy/8QzSzIn0ojgYqkhSN1TZkylTHd3kEXFZ
n31zhxdweTmfyQvCe5HtBs3urRUAHoUveWBs14ccNnSu36XfPJE5AtKPnXntW+GZ
6J9qrY/zux0jeF8/XDYQt2SThWdMTQmkOlvRxF8p0s2yWLgZ7RLkrG9EAmMfJ2T6
abPFjnbJQ6ZMfXGsmQvXl1iT6x3bsh4Uz1zro55BKK4VE9f8VIvhPtFXtWv9IO7Q
C3IyclFzTvoNyuqF3bKo5Bfva8n/U/1R/oMjOYK9Hr7gDbJ+JgZ9rfaf1DJesuMd
0d4XU0mhmHY/vQ/xWkS+ERxU+/RIzr9fwq0+RhE+CweZWXOcFUZ9TlO03GrFMdMn
NFtzz3sRX5Bm/qzPc5QWdp/h+MmO0Zrm6U0L17Y3Fp69maiR2WITGF/nVjziFmMd
HEc4TXJQgZVjx+Kv9/wYLfST8NhE8CEWdPRtNyFa/lruvJFda6UYEFHazYfeU72f
QdD5sYfVGsIjQnB9FPSX
=RFa8
-----END PGP SIGNATURE-----
--=-HwetbhPf/V4gaBe4aI6x--
------------------------------
Date: Mon, 29 Aug 2016 15:13:39 +1000
From: William Brown <
wibrown@redhat.com>
Subject: [389-devel] Re: Sign compare checking
To: "389 Directory server developer discussion."
<
389-devel@lists.fedoraproject.org>
Message-ID: <
1472447619.28186.24.camel@redhat.com>
Content-Type: multipart/signed; micalg="pgp-sha1";
protocol="application/pgp-signature";
boundary="=-RxNqnIBHeMvqSAwawzLI"
--=-RxNqnIBHeMvqSAwawzLI
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
>=20
> So either, this is a bug in the way openldap uses the ber_len_t type, we
> have a mistake in our logic, or something else hokey is going on.=20
>=20
> I would like to update this to:
>=20
> if ( (tag !=3D LBER_END_OF_SEQORSET) && (len =3D=3D 0) && (*fstr !=3D NUL=
L) )
>=20
> Or even:
>=20
> if ( (tag !=3D LBER_END_OF_SEQORSET) && (*fstr !=3D NULL) )
>=20
> What do you think of this assessment given the ber_len_t type?=20
Looks like it's intentional by the openldap team. There are some other
areas for this problem. Specifically:
int ber_printf(BerElement *ber, const char *fmt, ...);
lber.h:79:#define LBER_ERROR ((ber_tag_t) -1)
We check if (ber_printf(...) !=3D LBER_ERROR)
Of course, we can't satisfy either. We can't cast the LBER_ERROR from
uint -> int without changing the value of it, and we can't cast the
output of ber_printf from int -> uint, again, without potentially
changing the value of it. So it seems that the openldap library may be
impossible to satisfy the gcc type checking with -Wsign-compare.
For now, I may just avoid these in my fixes, as it seems like a whole
set of landmines I want to avoid ...=20
--=20
Sincerely,
William Brown
Software Engineer
Red Hat, Brisbane
--=-RxNqnIBHeMvqSAwawzLI
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
iQIcBAABAgAGBQJXw8SDAAoJEISUiynM+PAgP28P/2wO0bFVtUSZ1jLXmNQCwWJP
85s7vnZ2u0U5Dym8QkPxjz4AIR6LZCZ+Jbk5zRNWkw3+fsdf7j2MTGjTSSiZhZYJ
rWkNJx1YJ8vp9F15ckwLtk2ARLZOjM4AOV4a6v3PiWFoTveUQUp5xRX2j+/P3cou
GCp1/QP4ZjXba76EQ2lrDGvpfJBm1Wb9Vv+86s8w7B9DkSJOwV3OKDoNaZTv4ngK
fbVPaBdTgec6AiqFH66vRre1JMtVcTYPNpf4rOrCYU+hfKR0O7M+tpXGa+VGmFJn
ZdRt/Y9RXkl2veaXYXGIcylmCBmvOTI39YZz7lKBokG+KbdsIB0mVBgyQMg+kaLz
X7Q6QSvuuDgbgRkfqwRzkUJCXf9NArHsmayq3Jx2SVCr5YxK6KtKmP4bchUBuCno
smCHj139+Pbr9hKbHQvg6VATU5XU6zOM0dLJRGFSk3ihT369QmM7pvf9Oh7FGtLq
HIeX7jaqLQpANwPkbsVljNaBZN0bWPpndf5CNT9bHPN/GVUW+Wtlq7WFamme3MHV
dpkpMNi7EKDI2NLAjhjthqvMJMTCO+X/aJ+Fu0i506gtJKUdGnFVMnJSNPcwAAxk
8gv50Oa/I0d0j4HIEqP+jDFUWu7ivV6NDVGApsaU/IqfBx5SX7DHFIqK7jShGQfI
0kKiWsKVnGqorG+Os0xT
=/mYD
-----END PGP SIGNATURE-----
--=-RxNqnIBHeMvqSAwawzLI--
------------------------------
Subject: Digest Footer
--
389-devel mailing list
389-devel@lists.fedoraproject.orghttps://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org------------------------------
End of 389-devel Digest, Vol 134, Issue 9
*****************************************