[Fedora-directory-devel] Please review: [Bug 222918] server crash after deleting supposedly deleted attribute

[Noriko Hosoi]

Summary: server crash after deleting supposedly deleted attribute

https://bugzilla.redhat.com/show_bug.cgi?id=222918

On some configuration, FDS1.0.2 crashes when handling these modify requests:
dn: cuniPersonalId=99853826,ou=people,dc=cuni,dc=cz
changetype: modify
replace: cuniPrincipalName
-

dn: cuniPersonalId=99853826,ou=people,dc=cuni,dc=cz
changetype: modify
delete: cuniPrincipalName


------- Additional Comments From nhosoi(a)redhat.com  2007-09-28 15:52 EST -------
Created an attachment (id=210881)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=210881&action=view)
cvs diffs

Files: servers/plugins/syntaxes/string.c servers/slapd/back-ldbm/index.c

Description: I tried to reproduce the problem, but it failed.
I tried the test under the stress with nsslapd-serial-lock: off, but the
condition was not the key.  My test always catches:
  ldap_modify: No such attribute
at the second deletion, with which it does not take the crash path.
I tried indexed attribute as well as unindexed, but no luck.

Anyway, although I could not reproduce the crash, but the stacktrace in the original
comment indicates even if there is no attribute to delete, it calls 
index_addordel_values_sv with NULL vals, which is not supposed to, I think.

Also, string_values2keys in string.c is not ready to accept NULL bvals.

I changed these two files so that even if the condition is realized, the server
won't crash.