[389-devel] Please review: [Bug 247413] Incorrect error on multiple identical value add

[Noriko Hosoi]

https://bugzilla.redhat.com/show_bug.cgi?id=247413

[Problem Description] Adding multiple identical values returns
"Operations error (LDAP_OPERATIONS_ERROR == 0x1)" instead of
"Type or value exists (LDAP_TYPE_OR_VALUE_EXISTS == 0x14)"
E.g.,
   dn: ou=test,dc=example,dc=com
   changetype: modify
   replace: description
   description: test
   description: test

   modifying entry "ou=test,dc=example,dc=com"
   ldap_modify: Operations error (1)

[Fix Description] API valueset_replace used to override any
error from the lower layer with LDAP_OPERATIONS_ERROR. If
the error is LDAP_TYPE_OR_VALUE_EXISTS, the error is now
returned as is.




[Proposed Fix]
  -->  (https://bugzilla.redhat.com/attachment.cgi?id=387210)
git diff ldap/servers/slapd/valueset.c