The ticket https://fedorahosted.org/389/ticket/47942 was already reviewed by Mark, Rich and pj101.
The new patch is taking into account the following points:
- incorrect indentation
- Window/Pause configuration attribute are common to total and incremental updates
- Improve the logging so that when flow control is triggered it is not too noisy.
With normal logging level, it writes as FATAL the first flow control event (total or incremental).
If there are others during the session it logs the total numbers of flow control.
https://fedorahosted.org/389/attachment/ticket/47942/0004-Ticket-47942-DS-hangs-during-online-total-update.patch
I opened the ticket https://fedorahosted.org/389/ticket/47975 for further improvements of flow control:
- Better default values and procedure to tune them
- Automatic tuning (based on consumer processing rate)
- ability to monitor the flow control events
Thanks
theirry