[Fedora-directory-devel] Please review: [Bug 208672] parameterizing the hardcoded paths (phase 2. db, log, lock, pid dir)

[Noriko Hosoi]

Hello,

This is the phase 2 change proposal for the HFS work.  This time, replacing the hardcoded
db, log, lock and pid paths with the config attribute values...
Your review would be greatly appreciated.
Thanks,
--noriko

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208672

           Summary: parameterizing the hardcoded paths (phase 2. db, log, lock, pid dir)
           Product: Fedora Directory Server
           Version: 1.0.2
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Directory Server
        AssignedTo: nhosoi(a)redhat.com
        ReportedBy: nhosoi(a)redhat.com
         QAContact: ohegarty(a)redhat.com
                CC: ohegarty(a)redhat.com

------- Additional Comments From nhosoi(a)redhat.com  2006-09-29 20:45 EST -------
Created an attachment (id=137456)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=137456&action=...)
cvs diffs (ldapserver)

Files:
  ldap/admin/include/dsalib.h
  ldap/admin/lib/dsalib_db.c
  ldap/admin/lib/dsalib_location.c
  ldap/admin/lib/dsalib_util.c
  ldap/admin/src/create_instance.c
  ldap/admin/src/create_instance.h
  ldap/admin/src/ds_remove.c
  ldap/servers/slapd/libglobs.c
  ldap/servers/slapd/protect_db.c
  ldap/servers/slapd/proto-slap.h
  ldap/servers/slapd/slap.h
  ldap/servers/slapd/snmp_collator.c
  ldap/servers/slapd/back-ldbm/ldbm_config.c

Changes:
1) introduced these 2 config attributes.
+#define CONFIG_LOCKDIR_ATTRIBUTE "nsslapd-lockdir"
+#define CONFIG_DBDIR_ATTRIBUTE "nsslapd-dbdir"
2) replaced the hardcoded paths with the corresponding attribute value in the
   server as well as in the create/remove instance codes.