Hi Thierry,

Although it is globally fine, I have a few comments about the design document: related to the fact that maximum group size and depth are not handled:
- How are membership loop handled (
I mean group A contains group B and group B contains group A
BTW We should probably add a test about that if none already exists )
- How to we prevent memory exhaustion and reasonable response time
( Nothing prevent an entry to be in millions of groups and handling valueset with millions of values will be a nightmare )

IMHO you should add a section, explaining how these two cases are handled.

Regards,
Pierre

On Fri, Dec 16, 2022 at 6:35 PM Thierry Bordaz <tbordaz@redhat.com> wrote:

Hello,

Please find the slapi_memberof design under
https://www.port389.org/docs/389ds/design/slapi_memberof.html

This new slapi_memberof function in plugin API, provides a list of
entries that a given entry is member of, either directly or indirectly.
It could be reused by existing plugins (like memberof or referential
integrity). It can also be used by other component like InChain matching
rule that requires such service.

Any comments are welcome

best regards
thierry
_______________________________________________
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-leave@lists.fedoraproject.org
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue