On 11.06.2016 23:21, William Brown wrote:
On Fri, 2016-06-10 at 12:57 +0200, Martin Basti wrote:
On 10.06.2016 07:21, William Brown wrote:
https://fedorahosted.org/389/ticket/48878

https://fedorahosted.org/389/attachment/ticket/48878/0001-Ticket-48878-pep8-fixes-and-fix-rpm-to-build.patch

https://fedorahosted.org/389/attachment/ticket/48878/0001-Ticket-48878-pep8-fixes-part-2.patch



--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org
Hello, some notes if I can :)

1)
This change is harder to read with PEP8
-    topology.standalone.backends.create(None,
-                                       properties={
-                                            BACKEND_NAME: NEW_BACKEND_1,
-                                            'suffix':NEW_SUFFIX_1,
-                                            })
+    topology.standalone.backends.create(None, properties={
+ BACKEND_NAME: NEW_BACKEND_1,
+ 'suffix': NEW_SUFFIX_1,
+                                                         })
      ents = topology.standalone.backends.list()
      for ent in ents:
          topology.standalone.log.info("List(%d): backend %s" %

I suggest to use
topology.standalone.backends.create(
     None, properties={
         BACKEND_NAME: NEW_BACKEND_1,
         'suffix': NEW_SUFFIX_1,
     })

Same for NEW_BACKEND_2
Done!

https://fedorahosted.org/389/attachment/ticket/48878/0001-Ticket-48878-better-style-for-backend-in-backend_tes.patch

2)
I'm not sure if change in python-lib389.spec belongs to PEP8 related 
patch or if it is related to PEP8

Otherwise LGTM for PEP8 fixes :)

The idea was that basically this is a "house keeping" ticket to get ready for release. That's why I put them there.





--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org

LGTM or ACK if I'm allowed to ACKing patches here :)

Martin Basti @ IPA