Please review: fix compiler warning

[Martin Basti]

Hello all,

the gcc compiler returns warning during compiling of the freeIPA project:

slapi-plugin.h:6149, GNU C Compiler 4 (gcc), Priority: Normal
function declaration isn't a prototype [-Wstrict-prototypes]

6149 int slapi_rwlock_get_size();


Attached patch should fix the issue.
Thank you, Martin.

[Noriko Hosoi]

Thanks for your patch, Martin.  Looks good to me.  "ack".

Which version is your patch supposed to be in?  Just master is fine?
--noriko

On 11/03/2015 10:24 AM, Martin Basti wrote:
>  Hello all,
>
>  the gcc compiler returns warning during compiling of the freeIPA project:
>
>  slapi-plugin.h:6149, GNU C Compiler 4 (gcc), Priority: Normal
>  function declaration isn't a prototype [-Wstrict-prototypes]
>
>  6149 int slapi_rwlock_get_size();
>
>
>  Attached patch should fix the issue.
>  Thank you, Martin.
>
>
>
>  --
>  389-devel mailing list
>  389-devel(a)lists.fedoraproject.org
>  https://admin.fedoraproject.org/mailman/listinfo/389-devel

[Martin Basti]

On 03.11.2015 19:30, Noriko Hosoi wrote:
>  Thanks for your patch, Martin.  Looks good to me.  "ack".
>
>  Which version is your patch supposed to be in?  Just master is fine?
>  --noriko 
Thank you, master is fine.
Martin

>  On 11/03/2015 10:24 AM, Martin Basti wrote:
> > Hello all,
> >
> > the gcc compiler returns warning during compiling of the freeIPA 
> > project:
> >
> > slapi-plugin.h:6149, GNU C Compiler 4 (gcc), Priority: Normal
> > function declaration isn't a prototype [-Wstrict-prototypes]
> >
> > 6149 int slapi_rwlock_get_size();
> >
> >
> > Attached patch should fix the issue.
> > Thank you, Martin.
> >
> >
> >
> > --
> > 389-devel mailing list
> > 389-devel(a)lists.fedoraproject.org
> > https://admin.fedoraproject.org/mailman/listinfo/389-devel
>
>
>
>  --
>  389-devel mailing list
>  389-devel(a)lists.fedoraproject.org
>  https://admin.fedoraproject.org/mailman/listinfo/389-devel

[Noriko Hosoi]

On 11/03/2015 10:42 AM, Martin Basti wrote:
>  On 03.11.2015 19:30, Noriko Hosoi wrote:
> > Thanks for your patch, Martin. Looks good to me.  "ack".
> >
> > Which version is your patch supposed to be in?  Just master is fine?
> > --noriko
>  Thank you, master is fine. 
Pushed to master:
    aff9705..0d1ce9d  master -> master

    commit 0d1ce9de608d582ea2ca0f5e48fe2f2213f0b683
    Author: Martin Basti <mbasti(a)redhat.com&gt;
    Date:   Tue Nov 3 17:32:53 2015 +0100

         Add 'void' to function definition to avoid compiler warnings

Thanks!
--noriko

>  Martin
>
> >
> > On 11/03/2015 10:24 AM, Martin Basti wrote:
> >> Hello all,
> >>
> >> the gcc compiler returns warning during compiling of the freeIPA 
> >> project:
> >>
> >> slapi-plugin.h:6149, GNU C Compiler 4 (gcc), Priority: Normal
> >> function declaration isn't a prototype [-Wstrict-prototypes]
> >>
> >> 6149 int slapi_rwlock_get_size();
> >>
> >>
> >> Attached patch should fix the issue.
> >> Thank you, Martin.
> >>
> >>
> >>
> >> --
> >> 389-devel mailing list
> >> 389-devel(a)lists.fedoraproject.org
> >> https://admin.fedoraproject.org/mailman/listinfo/389-devel
> >
> >
> >
> > --
> > 389-devel mailing list
> > 389-devel(a)lists.fedoraproject.org
> > https://admin.fedoraproject.org/mailman/listinfo/389-devel
>
>
>
>  --
>  389-devel mailing list
>  389-devel(a)lists.fedoraproject.org
>  https://admin.fedoraproject.org/mailman/listinfo/389-devel