Please review: Fix slapi_td_plugin_lock_init prototype

[Petr Viktorin]

Hello,
FreeIPA compilation gives a GCC warning in a 389-ds header:

In file included from ipa_dns.c:54:0:
/usr/include/dirsrv/slapi-plugin.h:5585:1: warning: function declaration 
isn't a prototype [-Wstrict-prototypes]
  int slapi_td_plugin_lock_init();
  ^

The attached patch should fix this.

[Rich Megginson]

On 09/15/2014 05:20 AM, Petr Viktorin wrote:
> diff --git a/ldap/servers/slapd/slapi-plugin.h b/ldap/servers/slapd/slapi-plugin.h
> index f1ecfe8..268e465 100644
> --- a/ldap/servers/slapd/slapi-plugin.h
> +++ b/ldap/servers/slapd/slapi-plugin.h
> @@ -5582,7 +5582,7 @@ void slapi_td_get_val(int indexType, void **value);
>   int slapi_td_dn_init(void);
>   int slapi_td_set_dn(char *dn);
>   void slapi_td_get_dn(char **dn);
> -int slapi_td_plugin_lock_init();
> +int slapi_td_plugin_lock_init(void);
>   int slapi_td_set_plugin_locked(int *value);
>   void slapi_td_get_plugin_locked(int **value);
>
> --

Thanks - https://fedorahosted.org/389/ticket/47899

[Petr Viktorin]

On 09/15/2014 09:06 PM, Rich Megginson wrote:
> On 09/15/2014 05:20 AM, Petr Viktorin wrote:
> > diff --git a/ldap/servers/slapd/slapi-plugin.h
> > b/ldap/servers/slapd/slapi-plugin.h
> > index f1ecfe8..268e465 100644
> > --- a/ldap/servers/slapd/slapi-plugin.h
> > +++ b/ldap/servers/slapd/slapi-plugin.h
> > @@ -5582,7 +5582,7 @@ void slapi_td_get_val(int indexType, void **value);
> >   int slapi_td_dn_init(void);
> >   int slapi_td_set_dn(char *dn);
> >   void slapi_td_get_dn(char **dn);
> > -int slapi_td_plugin_lock_init();
> > +int slapi_td_plugin_lock_init(void);
> >   int slapi_td_set_plugin_locked(int *value);
> >   void slapi_td_get_plugin_locked(int **value);
> > --
>
> Thanks - https://fedorahosted.org/389/ticket/47899

Thanks.

I read the GIT Rules page on the wiki [0], which mentions patches not 
associated with a ticket. If all patches do need a ticket, it would be 
good to update it.

[0] http://www.port389.org/docs/389ds/development/git-rules.html

[Rich Megginson]

On 09/15/2014 07:28 PM, Petr Viktorin wrote:
> On 09/15/2014 09:06 PM, Rich Megginson wrote:
> > On 09/15/2014 05:20 AM, Petr Viktorin wrote:
> > > diff --git a/ldap/servers/slapd/slapi-plugin.h
> > > b/ldap/servers/slapd/slapi-plugin.h
> > > index f1ecfe8..268e465 100644
> > > --- a/ldap/servers/slapd/slapi-plugin.h
> > > +++ b/ldap/servers/slapd/slapi-plugin.h
> > > @@ -5582,7 +5582,7 @@ void slapi_td_get_val(int indexType, void 
> > > **value);
> > >   int slapi_td_dn_init(void);
> > >   int slapi_td_set_dn(char *dn);
> > >   void slapi_td_get_dn(char **dn);
> > > -int slapi_td_plugin_lock_init();
> > > +int slapi_td_plugin_lock_init(void);
> > >   int slapi_td_set_plugin_locked(int *value);
> > >   void slapi_td_get_plugin_locked(int **value);
> > > --
> >
> > Thanks - https://fedorahosted.org/389/ticket/47899
>
> Thanks.
>
> I read the GIT Rules page on the wiki [0], which mentions patches not 
> associated with a ticket.

That is correct.  I just wanted to make sure that this did not get lost.
> If all patches do need a ticket, it would be good to update it.
>
> [0] http://www.port389.org/docs/389ds/development/git-rules.html