Enable quiet build on ds, ns, svrcore

[William Brown]

Hi,

I want to get feedback from the team about a small change I would like
to make to our configure.ac. I want to add the following to
configure.ac.

m4_ifdef([AM_SILENT_RULES], [
     AM_SILENT_RULES([yes])
])

This changes the output from out builds. Current output is:

gcc -DHAVE_CONFIG_H -I. -I/home/william/development/389ds/ds  -g3
-DDEBUG -DMCC_DEBUG -O0 -Wall -Wp,-D_FORITY_SOURCE=2 -fexceptions
-fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches
-Werror=format-security -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
-fsanitize=address -fno-omit-frame-pointer -DBUILD_NUM="2016.299.416"
-DVENDOR=""389 Project"" -DBRAND=""389"" -DCAPBRAND=""389""
-UPACKAGE_VERSION -UPACKAGE_TARNAME -UPACKAGE_STRING -UPACKAGE_BUGREPORT
-I/home/william/development/389ds/ds/ldap/include
-I/home/william/development/389ds/ds/ldap/servers/slapd
-I/home/william/development/389ds/ds/include -I. -I/opt/dirsrv/include
-DLOCALSTATEDIR=""/opt/dirsrv/var"" -DSYSCONFDIR=""/opt/dirsrv/etc""
-DLIBDIR=""/opt/dirsrv/lib"" -DBINDIR=""/opt/dirsrv/bin""
-DDATADIR=""/opt/dirsrv/share""
-DDOCDIR=""/opt/dirsrv/share/doc/389-ds-base""
-DSBINDIR=""/opt/dirsrv/sbin""
-DPLUGINDIR=""/opt/dirsrv/lib/dirsrv/plugins""
-DTEMPLATEDIR=""/opt/dirsrv/share/dirsrv/data""
-I/home/william/development/389ds/ds/lib/ldaputil -I/usr/include
-I/usr/include/nss3 -I/usr/include/nspr4 -I/usr/include/nspr4   -O0
-Wall -Wextra -Wunused -Wno-unused-parameter -Wno-sign-compare
-Wstrict-overflow -fno-strict-aliasing -Wunused-but-set-variable -MT
lib/ldaputil/libldaputil_a-cert.o -MD -MP -MF
lib/ldaputil/.deps/libldaputil_a-cert.Tpo -c -o
lib/ldaputil/libldaputil_a-cert.o `test -f 'lib/ldaputil/cert.c' || echo
'/home/william/development/389ds/ds/'`lib/ldaputil/cert.c
mv -f lib/ldaputil/.deps/libldaputil_a-cert.Tpo
lib/ldaputil/.deps/libldaputil_a-cert.Po
gcc -DHAVE_CONFIG_H -I. -I/home/william/development/389ds/ds  -g3
-DDEBUG -DMCC_DEBUG -O0 -Wall -Wp,-D_FORITY_SOURCE=2 -fexceptions
-fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches
-Werror=format-security -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
-fsanitize=address -fno-omit-frame-pointer -DBUILD_NUM="2016.299.416"
-DVENDOR=""389 Project"" -DBRAND=""389"" -DCAPBRAND=""389""
-UPACKAGE_VERSION -UPACKAGE_TARNAME -UPACKAGE_STRING -UPACKAGE_BUGREPORT
-I/home/william/development/389ds/ds/ldap/include
-I/home/william/development/389ds/ds/ldap/servers/slapd
-I/home/william/development/389ds/ds/include -I. -I/opt/dirsrv/include
-DLOCALSTATEDIR=""/opt/dirsrv/var"" -DSYSCONFDIR=""/opt/dirsrv/etc""
-DLIBDIR=""/opt/dirsrv/lib"" -DBINDIR=""/opt/dirsrv/bin""
-DDATADIR=""/opt/dirsrv/share""
-DDOCDIR=""/opt/dirsrv/share/doc/389-ds-base""
-DSBINDIR=""/opt/dirsrv/sbin""
-DPLUGINDIR=""/opt/dirsrv/lib/dirsrv/plugins""
-DTEMPLATEDIR=""/opt/dirsrv/share/dirsrv/data""
-I/home/william/development/389ds/ds/lib/ldaputil -I/usr/include
-I/usr/include/nss3 -I/usr/include/nspr4 -I/usr/include/nspr4   -O0
-Wall -Wextra -Wunused -Wno-unused-parameter -Wno-sign-compare
-Wstrict-overflow -fno-strict-aliasing -Wunused-but-set-variable -MT
lib/ldaputil/libldaputil_a-certmap.o -MD -MP -MF
lib/ldaputil/.deps/libldaputil_a-certmap.Tpo -c -o
lib/ldaputil/libldaputil_a-certmap.o `test -f 'lib/ldaputil/certmap.c'
|| echo '/home/william/development/389ds/ds/'`lib/ldaputil/certmap.c

Changes to::

make[2]: Entering directory '/home/william/build/ds'
  CC       ldap/servers/slapd/libslapd_la-add.lo
  CC       ldap/servers/slapd/libslapd_la-apibroker.lo
  CC       ldap/servers/slapd/libslapd_la-attr.lo

You can return to "verbose" build with:

./configure --disable-silent-rules

You can read more here:

https://www.gnu.org/software/automake/manual/html_node/Automake-Silent-Rules...

[Lukas Slebodnik]

On (25/10/16 14:23), William Brown wrote:
> Hi,
>
> I want to get feedback from the team about a small change I would like
> to make to our configure.ac. I want to add the following to
> configure.ac.
>
> m4_ifdef([AM_SILENT_RULES], [
>     AM_SILENT_RULES([yes])
> ])

We(sssd) do not use it by default for few reasons.
It need to be expilicitely disabled if you want to see failures
in CI/mock build. Otherwise, it's imposible to check whether
compilation/linking had correct flags on different distributions
fedora/rhel/debian/opensuse and troubleshooting is much harder.

This is a reason why we prefer to explicitely enable it at configure
time or at build time
  ./configure --enable-silent-rules
or at build time
  make V=0 (make V=1)

Both versions are independent.

But I agree that thos posibility is very usefull for development.
IMHO, it might be better not to use "yes" as a default
m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES])

BTW. I can already see silent-rules in configure help.
[root@7380c2d8ecf1 ds]# ./configure --help | grep silent
  -q, --quiet, --silent   do not print `checking ...' messages
  --enable-silent-rules   less verbose build output (undo: "make V=1")
  --disable-silent-rules  verbose build output (undo: "make V=0")

LS

[William Brown]

On Tue, 2016-10-25 at 09:08 +0200, Lukas Slebodnik wrote:
> On (25/10/16 14:23), William Brown wrote:
> > Hi,
> >
> > I want to get feedback from the team about a small change I would like
> > to make to our configure.ac. I want to add the following to
> > configure.ac.
> >
> > m4_ifdef([AM_SILENT_RULES], [
> >     AM_SILENT_RULES([yes])
> > ])
>
> We(sssd) do not use it by default for few reasons.
> It need to be expilicitely disabled if you want to see failures
> in CI/mock build. Otherwise, it's imposible to check whether
> compilation/linking had correct flags on different distributions
> fedora/rhel/debian/opensuse and troubleshooting is much harder.

Hmmm that's a good point. I didn't think of this.
> This is a reason why we prefer to explicitely enable it at configure
> time or at build time
>   ./configure --enable-silent-rules
> or at build time
>   make V=0 (make V=1)

I didn't realise you could do that.
> Both versions are independent.
>
> But I agree that thos posibility is very usefull for development.
> IMHO, it might be better not to use "yes" as a default
> m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES])
>
> BTW. I can already see silent-rules in configure help.
> [root@7380c2d8ecf1 ds]# ./configure --help | grep silent
>   -q, --quiet, --silent   do not print `checking ...' messages
>   --enable-silent-rules   less verbose build output (undo: "make V=1")
>   --disable-silent-rules  verbose build output (undo: "make V=0")

Thanks, I might just leave this one alone then.