Should check for pam_appl.h

[Jan Engelhardt]

The requirement for pam-devel is indeed listed on 
http://port389.org/wiki/Building , though having configure.ac doing a 
gratitious check would be nice (it does not do so as of 1.2.11.12).

[Rich Megginson]

On 09/18/2012 10:44 PM, Jan Engelhardt wrote:
>  The requirement for pam-devel is indeed listed on
>  http://port389.org/wiki/Building , though having configure.ac doing a
>  gratitious check would be nice (it does not do so as of 1.2.11.12). 
Is there a way
to conditionally check headers?  Ideally, we would only 
check for the presence of security/pam_appl.h if --enable-pam-passthru 
is set.
>  --
>  389-devel mailing list
>  389-devel(a)lists.fedoraproject.org
>  https://admin.fedoraproject.org/mailman/listinfo/389-devel

[Jan Engelhardt]

On Wednesday 2012-09-19 14:59, Rich Megginson wrote:

>  On 09/18/2012 10:44 PM, Jan Engelhardt wrote:
> > The requirement for pam-devel is indeed listed on
> > http://port389.org/wiki/Building , though having configure.ac doing a
> > gratitious check would be nice (it does not do so as of 1.2.11.12).
>
>  Is there a way to conditionally check headers?  Ideally, we would only check
>  for the presence of security/pam_appl.h if --enable-pam-passthru is set. 
Would placing AC_CHECK_HEADERS into the AC_ARG_ENABLE's 3rd arg not suffice?

AC_ARG_ENABLE([pam-passthru], [...],
	[AC_CHECK_HEADERS([security/pam_appl.h],
		[],
		[AC_MSG_ERROR([bla])])
	])

Or one can probably also unconditionally check and only error out
when pam-passthru is chosen.

AC_CHECK_HEADERS([security/pam_appl.h])
AC_ARG_ENABLE([pam-passthru], [help text],
	[if test "$ac_cv_header_security_pam_appl_h" = no"; then
         AC_MSG_ERROR([bla])
        ])

[Rich Megginson]

On 09/19/2012 11:03 AM, Jan Engelhardt wrote:
>  Would placing AC_CHECK_HEADERS into the AC_ARG_ENABLE's 3rd arg
> not suffice?
>
>  AC_ARG_ENABLE([pam-passthru], [...],
>  	[AC_CHECK_HEADERS([security/pam_appl.h],
>  		[],
>  		[AC_MSG_ERROR([bla])])
>  	])
>
>  Or one can probably also unconditionally check and only error out
>  when pam-passthru is chosen.
>
>  AC_CHECK_HEADERS([security/pam_appl.h])
>  AC_ARG_ENABLE([pam-passthru], [help text],
>  	[if test "$ac_cv_header_security_pam_appl_h" = no"; then
>            AC_MSG_ERROR([bla])
>           ]) 
https://fedorahosted.org/389/ticket/468