[Fedora-directory-devel] Please review: [Bug 206724] Replacing PR_SetNetAddr with PRLDAP_SET_PORT for IPv6 support

[Noriko Hosoi]

Summary: Replacing PR_SetNetAddr with PRLDAP_SET_PORT for IPv6 support

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206724

Description of problem:
PR_SetNetAddr was used just to set port into PRNetAddr.  The function has a side
effect, which accidentally cleans up the scope_id field.  So, if the purpose of
calling PR_SetNetAddr is to set port, we were suggested to introduce a macro to
achieve the goal.

Fix proposal:
Created an attachment (id=136399)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=136399&action=vie...)
cvs diff slapi-private.h connection.c daemon.c

Files:
  slapi-private.h
  connection.c
  daemon.c

Changes:
slapi-private.h: introduced PRLDAP_SET_PORT to set port to the port field in
PRNetAddr.  A copy of the same macro in LDAP C SDK (v6).  Note: once NSPR
provides an equivalent API, we may want to replace this macro with the one. 
(the NSPR compatibility issue remains, though.)
connection.c, daemon.c: replaced PR_SetNetAddr with PRLDAP_SET_PORT.