Yes they should be! Nice catch.
Committing...
ldap/servers/plugins/replication/cl5_clcache.c | 1 +
.../plugins/replication/repl5_replica_config.c | 29
+++++++++++++-----
ldap/servers/plugins/rootdn_access/rootdn_access.c | 32
++++++++++++--------
ldap/servers/slapd/back-ldbm/cache.c | 24 +++++++++++----
ldap/servers/slapd/back-ldbm/dblayer.c | 5 +--
ldap/servers/slapd/back-ldbm/ldbm_entryrdn.c | 6 +--
6 files changed, 63 insertions(+), 34 deletions(-)
git push origin master
Counting objects: 29, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (15/15), done.
Writing objects: 100% (15/15), 1.92 KiB, done.
Total 15 (delta 12), reused 0 (delta 0)
To
ssh://git.fedorahosted.org/git/389/ds.git
8f21ac8..c446a69 master -> master
On 06/13/2012 06:22 PM, Noriko Hosoi wrote:
Hi Mark,
diff --git a/ldap/servers/plugins/rootdn_access/rootdn_access.c
b/ldap/servers/p
lugins/rootdn_access/rootdn_access.c
index 7fb5615..23e33dd 100644
--- a/ldap/servers/plugins/rootdn_access/rootdn_access.c
+++ b/ldap/servers/plugins/rootdn_access/rootdn_access.c
[...]
static int
rootdn_load_config(Slapi_PBlock *pb)
{
Slapi_Entry *e = NULL;
*char *openTime, *closeTime;* <== These variables should be initialized?
char hour[3], min[3];
The other fixes look good to me.
--noriko
Mark Reynolds wrote:
> Attached...
>
> Thanks,
> Mark
>
>
>
> --
> 389-devel mailing list
> 389-devel(a)lists.fedoraproject.org
>
https://admin.fedoraproject.org/mailman/listinfo/389-devel
--
389-devel mailing list
389-devel(a)lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel
--
Mark Reynolds
Senior Software Engineer
Red Hat, Inc
mreynolds(a)redhat.com