Please review: [389 Project] #47839: 389-ds production segfault: __memcpy_sse2_unaligned () at ../sysdeps/x86_64/multiarch/memcpy-sse2-unaligned.S:144

[Noriko Hosoi]

https://fedorahosted.org/389/ticket/47839

https://fedorahosted.org/389/attachment/ticket/47839/0001-Ticket-47839-38...

Bug description: modrdn2reple (retrocl_po.c) sets the given mods
to the changelog entry with "changes" attribute type if it includes
modifiersname, modifytimestamp, creatorsname, createtimestamp. When
the modrdn is internally initiated and passed mods do not include
the attributes (modifiersname, etc.), make_changes_string returns
empty lenstr.  There were 2 issues:
1) there was nothing to add if lenstr was empty, but it was added.
2) there was a bug to set the length +1 even though the length was 0.

Fix description:
1) If there is nothing to add to the change attribute, skip calling
    slapi_entry_add_values.
2) Remove adding "+1" for '\0' from the value length: val.bv_len.