https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239765 Resolves: bug #239765 Bug Description: Allow mimimum schema in ds_newinst.pl Reviewed by: ??? Files:https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=155069
Branch: HEAD Fix Description: Patch to add an option for installing partial/full schema
This patch implements a new configuration option [slapd] install_full_schema= 1
Setting this to 0 will only install 00core.ldif
Platforms tested: Fedora Core 5 (with Samba4 as testing client) Flag Day: no Doc impact: yes - wiki on install inf settings needs update
Thanks,
Andrew Bartlett
Noriko Hosoi wrote:
Your fix looks good.
It'd be taken care in the ds_newinst script or setuputil (I mean, not in create_instance.c, thus it won't affect your proposal), but following the current info file format: e.g., SecurityOn= Yes DisableSchemaChecking= No it'd be better supporting the same value set. install_full_schema= Yes / No
And by default, the value should be Yes? Looking at this coding, if InstallFullSchema does not exist in the info file, it's set NULL (install_full_schema=NULL). @@ -4490,6 +4504,7 @@ return 1; } cf->start_server = ds_a_get_cgi_var("start_server", NULL, NULL);
- cf->install_full_schema = ds_a_get_cgi_var("install_full_schema", NULL, NULL); cf->secserv = ds_a_get_cgi_var("secserv", NULL, NULL);
As being done for start_server, we could force to set 1 in the install script by default (as follows in ds_newinst.pl), but it'd be straightforward for the front-end scripts and the back-end program (create_instance.c) to agree on the default value, I think.
# if for some reason you do not want the server started after instance creation # the following line can be commented out - NOTE that if you are creating the # Configuration DS, it will be started anyway if (defined($table{"slapd"}->{"start_server"})) { $cgiargs{start_server} = $table{"slapd"}->{"start_server"}; } else { # default is on $cgiargs{start_server} = 1; }
Or just put the logic into create_instance.c to make the default behavior to install the full schema: if ((temp = ds_a_get_cgi_var("install_full_schema", NULL, NULL))) { cf->install_full_schema = atoi(temp); } else { cf->install_full_schema = 1; /* default - install all schema */ }
This means you have to set install_full_schema = 0 to get only 00core.ldif. If install_full_schema is missing from the install.inf file, the full schema will be installed by default.
Thanks, --noriko
Andrew Bartlett wrote:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239765 Resolves: bug #239765 Bug Description: Allow mimimum schema in ds_newinst.pl Reviewed by: ??? Files:https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=155069
Branch: HEAD Fix Description: Patch to add an option for installing partial/full schema
This patch implements a new configuration option [slapd] install_full_schema= 1
Setting this to 0 will only install 00core.ldif
Platforms tested: Fedora Core 5 (with Samba4 as testing client) Flag Day: no Doc impact: yes - wiki on install inf settings needs update
Thanks,
Andrew Bartlett
-- Fedora-directory-devel mailing list Fedora-directory-devel@redhat.com https://www.redhat.com/mailman/listinfo/fedora-directory-devel
-- Fedora-directory-devel mailing list Fedora-directory-devel@redhat.com https://www.redhat.com/mailman/listinfo/fedora-directory-devel
Richard Megginson wrote:
Noriko Hosoi wrote:
Your fix looks good. It'd be taken care in the ds_newinst script or setuputil (I mean, not in create_instance.c, thus it won't affect your proposal), but following the current info file format: e.g., SecurityOn= Yes DisableSchemaChecking= No it'd be better supporting the same value set. install_full_schema= Yes / No
And by default, the value should be Yes? Looking at this coding, if InstallFullSchema does not exist in the info file, it's set NULL (install_full_schema=NULL). @@ -4490,6 +4504,7 @@ return 1; } cf->start_server = ds_a_get_cgi_var("start_server", NULL, NULL);
- cf->install_full_schema =
ds_a_get_cgi_var("install_full_schema", NULL, NULL); cf->secserv = ds_a_get_cgi_var("secserv", NULL, NULL); As being done for start_server, we could force to set 1 in the install script by default (as follows in ds_newinst.pl), but it'd be straightforward for the front-end scripts and the back-end program (create_instance.c) to agree on the default value, I think.
# if for some reason you do not want the server started after instance creation # the following line can be commented out - NOTE that if you are creating the # Configuration DS, it will be started anyway if (defined($table{"slapd"}->{"start_server"})) { $cgiargs{start_server} = $table{"slapd"}->{"start_server"}; } else { # default is on $cgiargs{start_server} = 1; }Or just put the logic into create_instance.c to make the default behavior to install the full schema: if ((temp = ds_a_get_cgi_var("install_full_schema", NULL, NULL))) { cf->install_full_schema = atoi(temp); } else { cf->install_full_schema = 1; /* default - install all schema */ }
Yep, I prefer this way. Thanks, Rich. --noriko
This means you have to set install_full_schema = 0 to get only 00core.ldif. If install_full_schema is missing from the install.inf file, the full schema will be installed by default.
Thanks, --noriko
Andrew Bartlett wrote:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239765 Resolves: bug #239765 Bug Description: Allow mimimum schema in ds_newinst.pl Reviewed by: ??? Files:https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=155069
Branch: HEAD Fix Description: Patch to add an option for installing partial/full schema
This patch implements a new configuration option [slapd] install_full_schema= 1
Setting this to 0 will only install 00core.ldif
Platforms tested: Fedora Core 5 (with Samba4 as testing client) Flag Day: no Doc impact: yes - wiki on install inf settings needs update
Thanks,
Andrew Bartlett
-- Fedora-directory-devel mailing list Fedora-directory-devel@redhat.com https://www.redhat.com/mailman/listinfo/fedora-directory-devel
-- Fedora-directory-devel mailing list Fedora-directory-devel@redhat.com https://www.redhat.com/mailman/listinfo/fedora-directory-devel
-- Fedora-directory-devel mailing list Fedora-directory-devel@redhat.com https://www.redhat.com/mailman/listinfo/fedora-directory-devel
On Mon, 2007-05-21 at 11:42 -0700, Noriko Hosoi wrote:
Richard Megginson wrote:
Noriko Hosoi wrote:
Your fix looks good. It'd be taken care in the ds_newinst script or setuputil (I mean, not in create_instance.c, thus it won't affect your proposal), but following the current info file format: e.g.,
Or just put the logic into create_instance.c to make the default behavior to install the full schema: if ((temp = ds_a_get_cgi_var("install_full_schema", NULL, NULL))) { cf->install_full_schema = atoi(temp); } else { cf->install_full_schema = 1; /* default - install all schema */ }
Yep, I prefer this way. Thanks, Rich. --noriko
The logic is there now. Can you take a look at https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=155526&action=edi...
Thanks,
Andrew Bartlett
389-devel@lists.fedoraproject.org