[PATCH configure] only drop db corresponding to specified RAILS_ENV

[Mo Morsi]

---
 recipes/deltacloud_recipe/manifests/rails.pp |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/recipes/deltacloud_recipe/manifests/rails.pp b/recipes/deltacloud_recipe/manifests/rails.pp
index 7dfadc7..c5350a1 100644
--- a/recipes/deltacloud_recipe/manifests/rails.pp
+++ b/recipes/deltacloud_recipe/manifests/rails.pp
@@ -4,7 +4,7 @@ define rails::create::db($cwd="", $rails_env=""){
   exec{"create_rails_database":
          cwd         => $cwd,
          environment => "RAILS_ENV=${rails_env}",
-         command     => "/usr/bin/rake db:create:all"}
+         command     => "/usr/bin/rake db:create"}

}

@@ -35,6 +35,6 @@ define rails::drop::db($cwd="", $rails_env=""){
          cwd         => $cwd,
          onlyif      => "/usr/bin/test -f ${cwd}/Rakefile",
          environment => "RAILS_ENV=${rails_env}",
-         command     => "/usr/bin/rake db:drop:all"}
+         command     => "/usr/bin/rake db:drop"}
 }

[Mike Orazi]

ACK.

Note that cleanup will fail because we can't drop dcloud in the current 
database.pg/database.yml that is part of aggregator because both 
development and production are owned by the same role.  Your patch does 
what it is intending to do, but I wanted to call out the error 
explicitly because it is desired behavior but my first reaction was to 
look for what was failing.

On 02/09/2011 03:46 PM, Mohammed Morsi wrote:
> recipes/deltacloud_recipe/manifests/rails.pp |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/recipes/deltacloud_recipe/manifests/rails.pp b/recipes/deltacloud_recipe/manifests/rails.pp
> index 7dfadc7..c5350a1 100644
> --- a/recipes/deltacloud_recipe/manifests/rails.pp
> +++ b/recipes/deltacloud_recipe/manifests/rails.pp
> @@ -4,7 +4,7 @@ define rails::create::db($cwd="", $rails_env=""){
>     exec{"create_rails_database":
>            cwd         =>  $cwd,
>            environment =>  "RAILS_ENV=${rails_env}",
>     command     =>  "/usr/bin/rake db:create:all"}
>     command     =>  "/usr/bin/rake db:create"}
>
> }
>
> @@ -35,6 +35,6 @@ define rails::drop::db($cwd="", $rails_env=""){
>            cwd         =>  $cwd,
>            onlyif      =>  "/usr/bin/test -f ${cwd}/Rakefile",
>            environment =>  "RAILS_ENV=${rails_env}",
>     command     =>  "/usr/bin/rake db:drop:all"}
>     command     =>  "/usr/bin/rake db:drop"}
> }

[Mike Orazi]

On 02/10/2011 02:58 PM, Mike Orazi wrote:
> ACK.
>
> Note that cleanup will fail because we can't drop dcloud in the current
> database.pg/database.yml that is part of aggregator because both
> development and production are owned by the same role.  Your patch does
> what it is intending to do, but I wanted to call out the error
> explicitly because it is desired behavior but my first reaction was to
> look for what was failing.

I should amend my comment to say that is only the case if I"m working in 
a dual setup environment where I install the rpms and create production, 
then do some work against a created development database.

This would not happen if I were only working in production mode.

m
> On 02/09/2011 03:46 PM, Mohammed Morsi wrote:
> > recipes/deltacloud_recipe/manifests/rails.pp |    4 ++--
> >    1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/recipes/deltacloud_recipe/manifests/rails.pp b/recipes/deltacloud_recipe/manifests/rails.pp
> > index 7dfadc7..c5350a1 100644
> > --- a/recipes/deltacloud_recipe/manifests/rails.pp
> > +++ b/recipes/deltacloud_recipe/manifests/rails.pp
> > @@ -4,7 +4,7 @@ define rails::create::db($cwd="", $rails_env=""){
> >      exec{"create_rails_database":
> >             cwd         =>   $cwd,
> >             environment =>   "RAILS_ENV=${rails_env}",
> >     command     =>   "/usr/bin/rake db:create:all"}
> >     command     =>   "/usr/bin/rake db:create"}
> >
> > }
> >
> > @@ -35,6 +35,6 @@ define rails::drop::db($cwd="", $rails_env=""){
> >             cwd         =>   $cwd,
> >             onlyif      =>   "/usr/bin/test -f ${cwd}/Rakefile",
> >             environment =>   "RAILS_ENV=${rails_env}",
> >     command     =>   "/usr/bin/rake db:drop:all"}
> >     command     =>   "/usr/bin/rake db:drop"}
> > }
>
> aeolus-devel mailing list
> [e-mail]
> https://fedorahosted.org/mailman/listinfo/aeolus-devel