We could place some of this stuff in the puppet config file, but we would still need to override log for separation of each service log.
Do we still need to log to console? In my opinion we do not. However, I have kept logging to console in, since there is no mention of removing it
We might want to revisit how we treat logging, when puppet is responsible for configuring aeolus on >1 machine. We may need to do some puppet reporting magic, however, I think basic logging is sufficient.
Cheers,
Martyn
From: Martyn Taylor mtaylor@redhat.com
--- bin/aeolus-cleanup | 4 +++- bin/aeolus-configure | 4 +++- bin/aeolus-services | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/bin/aeolus-cleanup b/bin/aeolus-cleanup index 4106703..a280390 100644 --- a/bin/aeolus-cleanup +++ b/bin/aeolus-cleanup @@ -3,4 +3,6 @@ export FACTER_AEOLUS_ENABLE_SECURITY=false export FACTER_AEOLUS_ENABLE_PACKAGES=false puppet /usr/share/aeolus-configure/aeolus_uninstall.pp \ - --modulepath=/usr/share/aeolus-configure/modules/ + --modulepath=/usr/share/aeolus-configure/modules/ \ + --logdest=/var/log/aeolus-configure/aeolus-cleanup.log \ + --logdest=console diff --git a/bin/aeolus-configure b/bin/aeolus-configure index 5360260..96cfc60 100644 --- a/bin/aeolus-configure +++ b/bin/aeolus-configure @@ -3,4 +3,6 @@ export FACTER_AEOLUS_ENABLE_SECURITY=false export FACTER_AEOLUS_ENABLE_PACKAGES=true puppet /usr/share/aeolus-configure/aeolus_recipe.pp \ - --modulepath=/usr/share/aeolus-configure/modules/ + --modulepath=/usr/share/aeolus-configure/modules/ \ + --logdest=/var/log/aeolus-configure/aeolus-configure.log \ + --logdest=console diff --git a/bin/aeolus-services b/bin/aeolus-services index 72cd2bb..895a34a 100644 --- a/bin/aeolus-services +++ b/bin/aeolus-services @@ -1,4 +1,6 @@ #!/bin/sh
puppet /usr/share/aeolus-configure/aeolus_stop_services.pp \ - --modulepath=/usr/share/aeolus-configure/modules/ + --modulepath=/usr/share/aeolus-configure/modules/ \ + --logdest=/var/log/aeolus-configure/aeolus-services.log \ + --logdest=console
Ack'd seems working smoothly and logs are without the fancy ANSI colors, so its perfect.
Cheers, -Francesco
On Tue, Apr 12, 2011 at 11:56:59AM +0100, mtaylor@redhat.com wrote:
From: Martyn Taylor mtaylor@redhat.com
bin/aeolus-cleanup | 4 +++- bin/aeolus-configure | 4 +++- bin/aeolus-services | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/bin/aeolus-cleanup b/bin/aeolus-cleanup index 4106703..a280390 100644 --- a/bin/aeolus-cleanup +++ b/bin/aeolus-cleanup @@ -3,4 +3,6 @@ export FACTER_AEOLUS_ENABLE_SECURITY=false export FACTER_AEOLUS_ENABLE_PACKAGES=false puppet /usr/share/aeolus-configure/aeolus_uninstall.pp \
--modulepath=/usr/share/aeolus-configure/modules/
--modulepath=/usr/share/aeolus-configure/modules/ \
--logdest=/var/log/aeolus-configure/aeolus-cleanup.log \
--logdest=console
diff --git a/bin/aeolus-configure b/bin/aeolus-configure index 5360260..96cfc60 100644 --- a/bin/aeolus-configure +++ b/bin/aeolus-configure @@ -3,4 +3,6 @@ export FACTER_AEOLUS_ENABLE_SECURITY=false export FACTER_AEOLUS_ENABLE_PACKAGES=true puppet /usr/share/aeolus-configure/aeolus_recipe.pp \
--modulepath=/usr/share/aeolus-configure/modules/
--modulepath=/usr/share/aeolus-configure/modules/ \
--logdest=/var/log/aeolus-configure/aeolus-configure.log \
--logdest=console
diff --git a/bin/aeolus-services b/bin/aeolus-services index 72cd2bb..895a34a 100644 --- a/bin/aeolus-services +++ b/bin/aeolus-services @@ -1,4 +1,6 @@ #!/bin/sh
puppet /usr/share/aeolus-configure/aeolus_stop_services.pp \
--modulepath=/usr/share/aeolus-configure/modules/
--modulepath=/usr/share/aeolus-configure/modules/ \
--logdest=/var/log/aeolus-configure/aeolus-services.log \
--logdest=console
-- 1.7.4
aeolus-devel mailing list aeolus-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/aeolus-devel
Thanks for the patch Martyn
On 04/12/2011 06:56 AM, mtaylor@redhat.com wrote:
We could place some of this stuff in the puppet config file, but we would still need to override log for separation of each service log.
I think this is fine, when we split the components up so that they are able to be separately installable (I think we're pretty close to this now anyways), this should fall in line with the other bits that need to be made disparate.
Do we still need to log to console? In my opinion we do not. However, I have kept logging to console in, since there is no mention of removing it
We can always add a flag to enable / disable the console output. Actually there are a few flags that need to be added to the binaries (aeolus-configure and aeolus-cleanup) which themselves should be updated to be ruby scripts using optparse, as opposed to bash scripts. In addition to the log destination flag, we should be able to toggle package installation / removal from the command line, enable / disable security features, enable / disable specific seed data, among other things.
We might want to revisit how we treat logging, when puppet is responsible for configuring aeolus on>1 machine. We may need to do some puppet reporting magic, however, I think basic logging is sufficient.
Agreed, again thanks alot for this patch.
-Mo
aeolus-devel@lists.fedorahosted.org