Thanks for the patch Martyn
On 04/12/2011 06:56 AM, mtaylor@redhat.com wrote:
We could place some of this stuff in the puppet config file, but we would still need to override log for separation of each service log.
I think this is fine, when we split the components up so that they are able to be separately installable (I think we're pretty close to this now anyways), this should fall in line with the other bits that need to be made disparate.
Do we still need to log to console? In my opinion we do not. However, I have kept logging to console in, since there is no mention of removing it
We can always add a flag to enable / disable the console output. Actually there are a few flags that need to be added to the binaries (aeolus-configure and aeolus-cleanup) which themselves should be updated to be ruby scripts using optparse, as opposed to bash scripts. In addition to the log destination flag, we should be able to toggle package installation / removal from the command line, enable / disable security features, enable / disable specific seed data, among other things.
We might want to revisit how we treat logging, when puppet is responsible for configuring aeolus on>1 machine. We may need to do some puppet reporting magic, however, I think basic logging is sufficient.
Agreed, again thanks alot for this patch.
-Mo