On 08/05/11 - 12:57:55AM, Simon Harris wrote:
Hey Mark,
Thanks for the quick reply.
On 05/08/2011, at 12:53 AM, Mark McLoughlin wrote:
yet at the same time feel compelled to call 'Legless Turkey'. In my experience, a system that involves pull requests is easier to monitor, easier to review, easier to merge, etc.
Do you specifically mean pull requests on github, or pull requests in general?
I suppose I mean ala GitHub but it's also predicated on limited commit rights which you address further on. That said, to open up development to a wider community, GitHub style pull requests is a marvellous mechanism for doing so.
To be fair, I think pretty much everyone has commit rights to the repository. There are a couple of exceptions, but we can fix that if we want a really low barrier to entry. And as Mark said, even those with commit rights need to submit patches for review.
Finally, we should write down exactly what our process is and use the same process across the various projects in Aeolus.
+a bazillion :)
I pretty much agree with everything else Mark said, as we come from the same school of thought. I really think the review process is valuable, but we should write it down.