On Thu, Aug 04, 2011 at 06:12:25PM +0200, Tomas Sedovic wrote:
I do agree that we should give commit access to wider audience. It's not the case now (or at least it wasn't a few months back) and I think we should change that.
Is there an actual policy here, or is it just informal? (I'm just curious.) I had always assumed that basically anyone who contributes was given commit access.
This may stem from me being very young and inexperienced, but I have found incredible value in others' feedback to my patches. And thanks to me not pushing everything I've sent to the list, the git log looks much saner.
I'm also young and inexperienced, but I totally agree with this. The other advantage is that it makes it easier to see what's going on -- if there are patches that need to be reviewed, I more or less *need* to pay attention to patches and thus (a) keep abreast of what's going on around me, and (b) have an opportunity to see others' work.
As for the "you ack mine, I'll ack yours" situation: anecdotally, I've never seen the pathological version of this happen here. It may become an issue as we grow but I haven't seen any evidence that it is one now.
I think it's more "review for a review" than "ACK for an ACK". It's certainly not ideal, but sometimes patches do built up and teaming up with someone else who has patches waiting is the most expedient way to get someone to look over a patch.
-- Matt