Mea culpa on this. It appears that a subtle and seemingly-fine change of mine a while back broke dbomatic.
Within a couple controllers where we needed it, I was able to do "require 'lib/image'" which appeared to look in the correct place (Rails root) and include lib/image.rb. Conductor worked fine, so life was peachy, I got an ACK, and committed the code last month.
It seems that, for reasons I can't quite figure out, dbomatic chokes on this: it is unable to find the file when I reference it this way and thus fails to start. Feeling like I was swimming against the tide, I just fixed this by moving the reference into application.rb and referencing it by a full path. (Though I wonder if we should be using Rails.root, but it works fine as-is, so I don't want to change it now.)
-- Matt
Resolves https://bugzilla.redhat.com/show_bug.cgi?id=771505 --- src/app/controllers/api/images_controller.rb | 2 -- src/app/controllers/images_controller.rb | 1 - src/config/application.rb | 1 + 3 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/src/app/controllers/api/images_controller.rb b/src/app/controllers/api/images_controller.rb index 18d0908..e7d58f5 100644 --- a/src/app/controllers/api/images_controller.rb +++ b/src/app/controllers/api/images_controller.rb @@ -19,8 +19,6 @@
module Api class ImagesController < ApplicationController - require "lib/image" - before_filter :require_user_api
respond_to :xml diff --git a/src/app/controllers/images_controller.rb b/src/app/controllers/images_controller.rb index 018929c..2730e5b 100644 --- a/src/app/controllers/images_controller.rb +++ b/src/app/controllers/images_controller.rb @@ -16,7 +16,6 @@
class ImagesController < ApplicationController before_filter :require_user - require "lib/image"
def index set_admin_environments_tabs 'images' diff --git a/src/config/application.rb b/src/config/application.rb index dfc1273..be838b3 100644 --- a/src/config/application.rb +++ b/src/config/application.rb @@ -91,6 +91,7 @@ module Conductor config.encoding = "utf-8"
require File.dirname(__FILE__) + '/../lib/exceptions' + require File.dirname(__FILE__) + '/../lib/image'
# Configure sensitive parameters which will be filtered from the log file. config.filter_parameters += [:password, :password_confirmation]
On 01/03/2012 11:46 PM, Matt Wagner wrote:
Mea culpa on this. It appears that a subtle and seemingly-fine change of mine a while back broke dbomatic.
Within a couple controllers where we needed it, I was able to do "require 'lib/image'" which appeared to look in the correct place (Rails root) and include lib/image.rb. Conductor worked fine, so life was peachy, I got an ACK, and committed the code last month.
It seems that, for reasons I can't quite figure out, dbomatic chokes on this: it is unable to find the file when I reference it this way
If dbomatic is started as daemon, CWD is changed to '/', (line 131: Dir.chdir "/"), thus relative paths don't work.
and thus fails to start. Feeling like I was swimming against the tide, I just fixed this by moving the reference into application.rb and referencing it by a full path. (Though I wonder if we should be using Rails.root, but it works fine as-is, so I don't want to change it now.)
-- Matt
On 01/04/2012 09:43 AM, Jan Provaznik wrote:
On 01/03/2012 11:46 PM, Matt Wagner wrote:
Mea culpa on this. It appears that a subtle and seemingly-fine change of mine a while back broke dbomatic.
Within a couple controllers where we needed it, I was able to do "require 'lib/image'" which appeared to look in the correct place (Rails root) and include lib/image.rb. Conductor worked fine, so life was peachy, I got an ACK, and committed the code last month.
It seems that, for reasons I can't quite figure out, dbomatic chokes on this: it is unable to find the file when I reference it this way
If dbomatic is started as daemon, CWD is changed to '/', (line 131: Dir.chdir "/"), thus relative paths don't work.
Hmpf, ignore above, I'm not able to reproduce this bug, so it's apparently not because of changed CWD.
and thus fails to start. Feeling like I was swimming against the tide, I just fixed this by moving the reference into application.rb and referencing it by a full path. (Though I wonder if we should be using Rails.root, but it works fine as-is, so I don't want to change it now.)
-- Matt
On Tue, 2012-01-03 at 17:46 -0500, Matt Wagner wrote:
Mea culpa on this. It appears that a subtle and seemingly-fine change of mine a while back broke dbomatic.
Within a couple controllers where we needed it, I was able to do "require 'lib/image'" which appeared to look in the correct place (Rails root) and include lib/image.rb. Conductor worked fine, so life was peachy, I got an ACK, and committed the code last month.
It seems that, for reasons I can't quite figure out, dbomatic chokes on this: it is unable to find the file when I reference it this way and thus fails to start. Feeling like I was swimming against the tide, I just fixed this by moving the reference into application.rb and referencing it by a full path. (Though I wonder if we should be using Rails.root, but it works fine as-is, so I don't want to change it now.)
Tested locally and appears to resolve the reported problem.
Thanks, James
On 04/01/12 09:35 -0500, James Laska wrote:
On Tue, 2012-01-03 at 17:46 -0500, Matt Wagner wrote:
Mea culpa on this. It appears that a subtle and seemingly-fine change of mine a while back broke dbomatic.
Within a couple controllers where we needed it, I was able to do "require 'lib/image'" which appeared to look in the correct place (Rails root) and include lib/image.rb. Conductor worked fine, so life was peachy, I got an ACK, and committed the code last month.
It seems that, for reasons I can't quite figure out, dbomatic chokes on this: it is unable to find the file when I reference it this way and thus fails to start. Feeling like I was swimming against the tide, I just fixed this by moving the reference into application.rb and referencing it by a full path. (Though I wonder if we should be using Rails.root, but it works fine as-is, so I don't want to change it now.)
Tested locally and appears to resolve the reported problem.
Thanks, James
Same here, works for me.
On Wed, Jan 04, 2012 at 10:08:30AM -0500, Chris Alfonso wrote:
On 04/01/12 09:35 -0500, James Laska wrote:
On Tue, 2012-01-03 at 17:46 -0500, Matt Wagner wrote:
Mea culpa on this. It appears that a subtle and seemingly-fine change of mine a while back broke dbomatic.
Within a couple controllers where we needed it, I was able to do "require 'lib/image'" which appeared to look in the correct place (Rails root) and include lib/image.rb. Conductor worked fine, so life was peachy, I got an ACK, and committed the code last month.
It seems that, for reasons I can't quite figure out, dbomatic chokes on this: it is unable to find the file when I reference it this way and thus fails to start. Feeling like I was swimming against the tide, I just fixed this by moving the reference into application.rb and referencing it by a full path. (Though I wonder if we should be using Rails.root, but it works fine as-is, so I don't want to change it now.)
Tested locally and appears to resolve the reported problem.
Thanks, James
Same here, works for me.
Thanks to both of you for testing this. It appears to fix the problem for those who are encountering it, so I've gone ahead and pushed it.
-- Matt
aeolus-devel@lists.fedorahosted.org
-
Chris Alfonso -
James Laska -
Jan Provazník -
Matt Wagner