Anaconda-devel October 2009

anaconda-devel@lists.fedoraproject.org

29 participants
138 discussions

[f12-branch] & [master] fix "resize failed: 1"
by David Cantrell 30 Oct '09

30 Oct '09

Fixes an install test case that the Fedora QA people are doing and an F12 blocker. Comment on the patch is self-explanatory. -- David Cantrell <dcantrell(a)redhat.com> Red Hat / Honolulu, HI

2 2

[f12, master] Use a "change" event instead of "add" to populate udev db
by David Lehman 29 Oct '09

29 Oct '09

For F12, these go in just as they are. For rawhide, I want to remove the attr_nomatch keyword argument from baseudev.udev_trigger and change the udev_trigger calls to instead specify a "change" event, effectively making master look like f12 after these patches.

3 6

[rhel6-branch] & [master] zerombr for dasdfmt
by David Cantrell 29 Oct '09

29 Oct '09

These patches use 'zerombr' during kickstart installs to force dasdfmt. If the user is doing an interactive kickstart install and zerombr is not present but needs to run, the question is presented just as in a non kickstart install. I've tested this on RHEL-6 Alpha 3 on s390 with kickstart and non kickstart installs. -- David Cantrell <dcantrell(a)redhat.com> Red Hat / Honolulu, HI

3 5

[PATCH] Only try to split proxy commands out if there's actually one specified.
by Peter Jones 29 Oct '09

29 Oct '09

If we try to regexec() on NULL it segfaults, so let's try not to do that... --- loader/urlinstall.c | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/loader/urlinstall.c b/loader/urlinstall.c index cdffab8..b03efce 100644 --- a/loader/urlinstall.c +++ b/loader/urlinstall.c @@ -429,8 +429,12 @@ void setKickstartUrl(struct loaderData_s * loaderData, int argc, loaderData->method = METHOD_URL; } - splitProxyParam(proxy, &loaderData->proxyUser, &loaderData->proxyPassword, - &loaderData->proxy, &loaderData->proxyPort); + if (proxy) { + splitProxyParam(proxy, &loaderData->proxyUser, + &loaderData->proxyPassword, + &loaderData->proxy, + &loaderData->proxyPort); + } logMessage(INFO, "results of url ks, url %s", url); } -- 1.6.5.rc2

2 1

[rhel6-branch] & [master] better text.py detailedMessageWindow
by David Cantrell 29 Oct '09

29 Oct '09

Do what ButtonChoiceWindow does, but an additional row containing a padded/scrolling text box for longText. Not great, but better than using ListboxChoiceWindow. -- David Cantrell <dcantrell(a)redhat.com> Red Hat / Honolulu, HI

2 2

[rhel6-branch] & [master] remove IUCV support
by David Cantrell 29 Oct '09

29 Oct '09

The kernel no longer has CONFIG_NETIUCV set, so remove support for these devices on s390. -- David Cantrell <dcantrell(a)redhat.com> Red Hat / Honolulu, HI

4 4

[PATCH] TypeError: '_ped.DiskType' object is not callable (#531730)
by Hans de Goede 29 Oct '09

29 Oct '09

platform.X86.__init__ did: self.diskLabelType = foo instead of self._diskLabelType = foo. So it was overriding the method from the base class. --- platform.py | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/platform.py b/platform.py index c0cc602..ca4bf9e 100644 --- a/platform.py +++ b/platform.py @@ -257,7 +257,7 @@ class Alpha(Platform): disk = req.disk.format.partedDisk # Check that we're a BSD disk label - if not disk.type == self.diskLabelType.name: + if not disk.type == self._diskLabelType.name: errors.append(_("%s must have a bsd disk label.") % req.disk.name) # The first free space should start at the beginning of the drive and @@ -400,7 +400,7 @@ class NewWorldPPC(PPC): disk = req.disk.format.partedDisk # Check that we're a Mac disk label - if not disk.type == self.diskLabelType.name: + if not disk.type == self._diskLabelType.name: errors.append(_("%s must have a mac disk label.") % req.disk.name) # All of the above just checks the appleboot partitions. We still @@ -460,9 +460,9 @@ class X86(EFI): EFI.__init__(self, anaconda) if self.isEfi: - self.diskLabelType = parted.diskType["gpt"] + self._diskLabelType = parted.diskType["gpt"] else: - self.diskLabelType = parted.diskType["msdos"] + self._diskLabelType = parted.diskType["msdos"] def bootDevice(self): if self.isEfi: -- 1.6.5.1

2 1

[PATCH] FIX: TypeError: '_ped.DiskType' object is not callable (#531730)
by Hans de Goede 29 Oct '09

29 Oct '09

platform.X86.__init__ did: self.diskLabelType = foo instead of self._diskLabelType = foo. So it was overriding the method from the base class. --- platform.py | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/platform.py b/platform.py index c0cc602..8187eb5 100644 --- a/platform.py +++ b/platform.py @@ -460,9 +460,9 @@ class X86(EFI): EFI.__init__(self, anaconda) if self.isEfi: - self.diskLabelType = parted.diskType["gpt"] + self._diskLabelType = parted.diskType["gpt"] else: - self.diskLabelType = parted.diskType["msdos"] + self._diskLabelType = parted.diskType["msdos"] def bootDevice(self): if self.isEfi: -- 1.6.5.1

2 2

[PATCH parted 1/7] libparted: add ped_device_get_xxx_aligment() functions
by Hans de Goede 29 Oct '09

29 Oct '09

Add ped_device_get_minimal_aligment() and ped_device_get_optimal_aligment() functions to libparted. --- include/parted/device.h | 8 ++++++++ include/parted/natmath.h | 1 + libparted/device.c | 43 +++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 52 insertions(+), 0 deletions(-) diff --git a/include/parted/device.h b/include/parted/device.h index 151305f..7c34081 100644 --- a/include/parted/device.h +++ b/include/parted/device.h @@ -92,6 +92,8 @@ struct _PedDevice { void* arch_specific; }; +#include <parted/natmath.h> + /** * List of functions implementing architecture-specific operations. */ @@ -112,6 +114,9 @@ struct _PedDeviceArchOps { PedSector (*check) (PedDevice* dev, void* buffer, PedSector start, PedSector count); void (*probe_all) (); + /* These functions are optional */ + PedAlignment *(*get_minimal_aligment)(const PedDevice *dev); + PedAlignment *(*get_optimal_aligment)(const PedDevice *dev); }; #include <parted/constraint.h> @@ -141,6 +146,9 @@ extern PedSector ped_device_check (PedDevice* dev, void* buffer, PedSector start, PedSector count); extern PedConstraint* ped_device_get_constraint (PedDevice* dev); +extern PedAlignment *ped_device_get_minimal_aligment(const PedDevice *dev); +extern PedAlignment *ped_device_get_optimal_aligment(const PedDevice *dev); + /* private stuff ;-) */ extern void _ped_device_probe (const char* path); diff --git a/include/parted/natmath.h b/include/parted/natmath.h index cd7679d..eaa84d1 100644 --- a/include/parted/natmath.h +++ b/include/parted/natmath.h @@ -31,6 +31,7 @@ typedef struct _PedAlignment PedAlignment; #include <parted/disk.h> #include <parted/device.h> +#include <parted/geom.h> #define PED_MIN(a, b) ( ((a)<(b)) ? (a) : (b) ) #define PED_MAX(a, b) ( ((a)>(b)) ? (a) : (b) ) diff --git a/libparted/device.c b/libparted/device.c index 294fec4..34b8eb5 100644 --- a/libparted/device.c +++ b/libparted/device.c @@ -444,5 +444,48 @@ ped_device_get_constraint (PedDevice* dev) return c; } +/** + * Get an alignment that represents minimum hardware requirements on aligment. + * When for example using media that has a physical sector size that is a + * multiple of the logical sector size, it is desirable to have disk accesses + * (and thus partitions) properly aligned. Having partitions not aligned to + * the minimum hardware requirements may lead to a performance penalty. + * + * The returned alignment describes the aligment for the start sector of the + * partition, the end sector should be aligned too, to get the end sector + * aligment decrease the returned alignment's offset by 1. + * + * \return the minimum alignment of partition start sectors, or NULL if this + * information is not available. + */ +PedAlignment* +ped_device_get_minimal_aligment(const PedDevice *dev) +{ + if (ped_architecture->dev_ops->get_minimal_aligment) + return ped_architecture->dev_ops->get_minimal_aligment(dev); + + return NULL; /* ped_alignment_none */ +} + +/** + * Get an alignment that represents the hardware requirements for optimal + * performance. + * + * The returned alignment describes the aligment for the start sector of the + * partition, the end sector should be aligned too, to get the end sector + * aligment decrease the returned alignment's offset by 1. + * + * \return the optimal alignment of partition start sectors, or NULL if this + * information is not available. + */ +PedAlignment* +ped_device_get_optimal_aligment(const PedDevice *dev) +{ + if (ped_architecture->dev_ops->get_optimal_aligment) + return ped_architecture->dev_ops->get_optimal_aligment(dev); + + return NULL; /* ped_alignment_none */ +} + /** @} */ -- 1.6.5.1

1 6

[rhel6-branch] & [master] updated #528386 patches
by David Cantrell 29 Oct '09

29 Oct '09

Updated patches for #586386. What's here: 1) Converted /dev/dasdX to /dev/disk/by-path/ccw-STUFF for log entries and display in dialog boxes. 2) Use DetailedMessageWindow in iw mode to show the list of all DASDs that need formatting. 3) Fix detailedMessageWindow() in text.py so we get something similar to DetailedMessageWindow from gui.py. Use a ListboxChoiceWindow() and put the longText contents as the list items, broken on new lines. 4) Remove the self._progressBuffer stuff that was still left over. What's not here: 1) Support for kickstart or non-UI installs. Need to discuss this with clumens. 2) Parallel formatting. As stated in the original patch set email, I'm reserving that for a followup patch. -- David Cantrell <dcantrell(a)redhat.com> Red Hat / Honolulu, HI

4 13

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Anaconda-devel October 2009