Anaconda-devel July 2009

anaconda-devel@lists.fedoraproject.org

29 participants
100 discussions

[PATCH] Fix obvious typo in font name
by Jeremy Katz 23 Jul '09

23 Jul '09

--- lang-table | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lang-table b/lang-table index 04e49bd..2378b8d 100644 --- a/lang-table +++ b/lang-table @@ -23,7 +23,7 @@ Hindi hi none hi_IN.UTF-8 us Asia/Kolkata Hungarian hu latarcyrheb-sun16 hu_HU.UTF-8 hu Europe/Budapest Icelandic is latarcyrheb-sun16 is_IS.UTF-8 is-latin1 Atlantic/Reykjavik Iloko ilo latarcyrheb-sun16 ilo_PH.UTF-8 us Asia/Manila -Indonesian id latarcryheb-sun16 id_ID.UTF-8 us Asia/Jakarta +Indonesian id latarcyrheb-sun16 id_ID.UTF-8 us Asia/Jakarta Italian it latarcyrheb-sun16 it_IT.UTF-8 it Europe/Rome Japanese ja none ja_JP.UTF-8 jp106 Asia/Tokyo Kannada kn none kn_IN.UTF-8 us Asia/Kolkata -- 1.6.2.5

2 1

[PATCH] Log non-upgradable upgrade candidate roots.
by Radek Vykydal 23 Jul '09

23 Jul '09

This can be helpful in determining the cause of failed upgrade from log. I used it when working on #499321. Can be kind of corner-case, but can't hurt. --- storage/__init__.py | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/storage/__init__.py b/storage/__init__.py index 2370f0c..348a155 100644 --- a/storage/__init__.py +++ b/storage/__init__.py @@ -1045,6 +1045,9 @@ def findExistingRootDevices(anaconda, upgradeany=False): if upgradeany or \ anaconda.id.instClass.productUpgradable(product, version): rootDevs.append((device, "%s %s" % (product, version))) + else: + log.info("product %s version %s found on %s is not upgradable" + % (product, version, device.name)) # this handles unmounting the filesystem device.teardown(recursive=True) -- 1.6.0.6

2 1

Building anaconda for F11 fix
by Nicholas Veeser 22 Jul '09

22 Jul '09

Sorry to bug you guys on your mailing list, but it seemed related to the development process. Trying to understand how all the pieces of anaconda work to that I can apply a fix for my own setup of F11. Seems there is a fix in Rawhide for the following RAID issue. https://bugzilla.redhat.com/show_bug.cgi?id=503310 I am having the issue in F11 I found this unofficial fix in the bug http://rvykydal.fedorapeople.org/updates.clearpart.img Put the updates.clearpart.img in <repo>/images/updates.img That fixes it ------ For completeness, I would like to be able to reproduce, from source, what Mr. Vykydal did to produce the updates.img - Pulled the source with git - Read the building / packaging instructions - I found info about moving to autoconf here: http://www.linux-archive.org/debian-development/314101-moving-anaconda-auto… http://dcantrel.fedorapeople.org/anaconda/autognu/READ_ME.txt - Can't seem to find the ./bootstrap file mentioned Help? Please don't make me understand the voodoo of autoconf (I have been avoiding it for 10 years..;)

2 1

[PATCH 1/2] Add a method to determine whether a block device is read-only.
by Chris Lumens 22 Jul '09

22 Jul '09

--- isys/isys.c | 24 ++++++++++++++++++++++++ isys/isys.py | 6 ++++++ 2 files changed, 30 insertions(+), 0 deletions(-) diff --git a/isys/isys.c b/isys/isys.c index fcec6fd..90a697c 100644 --- a/isys/isys.c +++ b/isys/isys.c @@ -124,6 +124,7 @@ static PyObject * doGetBiosDisk(PyObject * s, PyObject * args); static PyObject * doSegvHandler(PyObject *s, PyObject *args); static PyObject * doAuditDaemon(PyObject *s); static PyObject * doPrefixToNetmask(PyObject *s, PyObject *args); +static PyObject * doDeviceReadOnly(PyObject *s, PyObject *args); static PyMethodDef isysModuleMethods[] = { { "ejectcdrom", (PyCFunction) doEjectCdrom, METH_VARARGS, NULL }, @@ -180,6 +181,7 @@ static PyMethodDef isysModuleMethods[] = { { "handleSegv", (PyCFunction) doSegvHandler, METH_VARARGS, NULL }, { "auditdaemon", (PyCFunction) doAuditDaemon, METH_NOARGS, NULL }, { "prefix2netmask", (PyCFunction) doPrefixToNetmask, METH_VARARGS, NULL }, + { "deviceIsReadOnly", (PyCFunction) doDeviceReadOnly, METH_VARARGS, NULL }, { NULL, NULL, 0, NULL } } ; @@ -1416,4 +1418,26 @@ static PyObject * doAuditDaemon(PyObject *s) { return Py_None; } +static PyObject * doDeviceReadOnly(PyObject *s, PyObject *args) { + char *diskname = NULL; + int fd, is_ro; + + if (!PyArg_ParseTuple(args, "s", &diskname)) return NULL; + + fd = open(diskname, O_RDONLY); + if (fd == -1) { + Py_INCREF(Py_None); + return Py_None; + } + + if (ioctl(fd, BLKROGET, &is_ro)) { + close(fd); + PyErr_SetFromErrno(PyExc_SystemError); + return NULL; + } + + close(fd); + return PyBool_FromLong(is_ro); +} + /* vim:set shiftwidth=4 softtabstop=4: */ diff --git a/isys/isys.py b/isys/isys.py index 4063130..189a6c1 100644 --- a/isys/isys.py +++ b/isys/isys.py @@ -804,6 +804,12 @@ def driveUsesModule(device, modules): pass return rc +def deviceIsReadOnly(device): + if not device.startswith("/dev/"): + return _isys.deviceIsReadOnly("/dev/" + device) + else: + return _isys.deviceIsReadOnly(device) + def mediaPresent(device): try: fd = os.open("/dev/%s" % device, os.O_RDONLY) -- 1.6.1.3

2 3

[PATCH 1/2] Try to auto-find the CD even if stage2= is specified
by Jeremy Katz 21 Jul '09

21 Jul '09

Try to auto-find the CD even if stage2= is specified; this lets us add stage2= and then the isohybrid'd images can be dd'd to a usb stick and stage2 gets find there as well as on the CD. Next step is to be able to get rid of the auto CD finding by always explicitly specifying stage2= --- loader/loader.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/loader/loader.c b/loader/loader.c index 8d92ed4..b48b0a0 100644 --- a/loader/loader.c +++ b/loader/loader.c @@ -1247,7 +1247,7 @@ static char *doLoaderMain(struct loaderData_s *loaderData, * it. However if stage2= was given, use that value as an override here. * That will also then bypass any method selection UI in loader. */ - if (!FL_ASKMETHOD(flags) && !loaderData->stage2Data) { + if (!FL_ASKMETHOD(flags)) { url = findAnacondaCD("/mnt/stage2"); if (url) { setStage2LocFromCmdline(url, loaderData); @@ -1261,7 +1261,7 @@ static char *doLoaderMain(struct loaderData_s *loaderData, skipLangKbd = 1; flags |= LOADER_FLAGS_NOPASS; - } else if (loaderData->instRepo) { + } else if (!loaderData->stage2Data && loaderData->instRepo) { /* If no CD/DVD with a stage2 image was found and we were given a * repo=/method= parameter, try to piece together a valid setting * for the stage2= parameter based on that. -- 1.6.1

3 3

[PATCH] Remove unresolvable file devices from the devicetree. (#503830)
by David Lehman 21 Jul '09

21 Jul '09

--- storage/__init__.py | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/storage/__init__.py b/storage/__init__.py index efd21a0..18c7645 100644 --- a/storage/__init__.py +++ b/storage/__init__.py @@ -1541,6 +1541,8 @@ class FSSet(object): log.error("cannot determine which device contains " "directory %s" % device.path) device.parents = [] + self.devicetree._removeDevice(device) + continue else: device.parents = [parent] @@ -1616,6 +1618,8 @@ class FSSet(object): log.error("cannot determine which device contains " "directory %s" % device.path) device.parents = [] + self.devicetree._removeDevice(device) + continue else: device.parents = [parent] -- 1.6.0.6

2 2

some patches for rawhide
by David Cantrell 20 Jul '09

20 Jul '09

1) Add support for the --gecos option on the kickstart 'user' command. 2) Move 'make updates' target to script/makeupdates. This script can be run without going through autogen.sh. If you run it standalone, it'll generate an updates.img file containing only Python code that has changed. -- David Cantrell <dcantrell(a)redhat.com> Red Hat / Honolulu, HI

2 3

rhel5-branch fix for 473747
by David Cantrell 20 Jul '09

20 Jul '09

Correct the UI message to say '300' instead of '30' for the upper bound. -- David Cantrell <dcantrell(a)redhat.com> Red Hat / Honolulu, HI

2 2

[PATCH] rhel5-branch completely remove ext4dev
by Joel Granados Moreno 20 Jul '09

20 Jul '09

Hello list Remove leftovers from ext4dev. Regards. Joel Andres Granados Brno, Czech Republic, Red Hat.

2 2

[PATCH] Fix selection of alternative iface in UI after fail (#507084).
by Radek Vykydal 17 Jul '09

17 Jul '09

Make ifcfg configuration files getting parsed properly after update. The used inotify configuration update mechanism (ifcfg-rh NM plugin) requires 1) writing of new files out of /etc/sysconfig/network-scripts dir so that it doesn't trigger parsing of the file too early (before all is written), and more importantly, 2) removing of the old files before moving the new ones in so that the new file gets parsed and the respective connection gets re-read and eventually activated. Also make sure that only device selected in UI has ONBOOT set to yes in case of selection of another device after fail. --- iw/netconfig_dialog.py | 8 ++++++-- network.py | 7 ++++++- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/iw/netconfig_dialog.py b/iw/netconfig_dialog.py index 29afc0e..ea59613 100644 --- a/iw/netconfig_dialog.py +++ b/iw/netconfig_dialog.py @@ -226,8 +226,12 @@ class NetworkConfigurator: combo = self.xml.get_widget("interfaceCombo") active = combo.get_active_iter() val = combo.get_model().get_value(active, 1) - netdev = self.network.available()[val] - netdev.set(('ONBOOT', 'yes')) + for v, dev in self.network.available().items(): + if v == val: + dev.set(('ONBOOT', 'yes')) + netdev = dev + else: + dev.set(('ONBOOT', 'no')) # FIXME: need to do input validation if self.xml.get_widget("dhcpCheckbutton").get_active(): diff --git a/network.py b/network.py index f597c9d..9a8d7d2 100644 --- a/network.py +++ b/network.py @@ -538,7 +538,7 @@ class Network: ipv6autoconf = dev.get('IPV6_AUTOCONF').lower() dhcpv6c = dev.get('DHCPV6C').lower() - newifcfg = "%s/ifcfg-%s.new" % (netscripts, device,) + newifcfg = "/tmp/ifcfg-%s.new" % (device,) f = open(newifcfg, "w") if len(dev.get("DESC")) > 0: f.write("# %s\n" % (dev.get("DESC"),)) @@ -596,6 +596,11 @@ class Network: # move the new ifcfg in place destcfg = "%s/ifcfg-%s" % (netscripts, device,) + try: + os.remove(destcfg) + except OSError as e: + if e.errno != 2: + raise shutil.move(newifcfg, destcfg) # XXX: is this necessary with NetworkManager? -- 1.6.0.6

3 2

← Newer
1
2
3
4
5
6
7
8
9
10
Older →

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Anaconda-devel July 2009