Anaconda-devel July 2009

anaconda-devel@lists.fedoraproject.org

29 participants
100 discussions

[PATCH] Show MAC address of network device in text mode too.
by Radek Vykydal 17 Jul '09

17 Jul '09

I came accross this by the way when working on something different. It adds what was done with commit 2e8dfb72c0c296f24f99512e8fb00c377417a60a (#504216) for GUI to text ui. Althoug BZ suggests that it was already present in text ui, looking into code doesn't (I have no rawhide image to test if it is actually true). --- textw/netconfig_text.py | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/textw/netconfig_text.py b/textw/netconfig_text.py index 8475f00..379bedd 100644 --- a/textw/netconfig_text.py +++ b/textw/netconfig_text.py @@ -103,9 +103,10 @@ class NetworkConfiguratorText: selected_interface = None for dev in devs: - desc = netdevs[dev].get("DESC") - if desc: - desc = "%s - %.50s" % (dev, desc) + hwaddr = netdevs[dev].get("HWADDR") + + if hwaddr: + desc = "%s - %.50s" % (dev, hwaddr) else: desc = dev -- 1.6.0.6

3 2

[PATCH] Stop the cdrom device before ejecting (#505067)
by Martin Sivak 17 Jul '09

17 Jul '09

--- storage/devices.py | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/storage/devices.py b/storage/devices.py index 02c6945..5bfd31f 100644 --- a/storage/devices.py +++ b/storage/devices.py @@ -2993,6 +2993,9 @@ class OpticalDevice(StorageDevice): if not self.exists: raise DeviceError("device has not been created", self.path) + #try to umount and close device before ejecting + self.teardown() + # Make a best effort attempt to do the eject. If it fails, it's not # critical. fd = os.open(self.path, os.O_RDONLY | os.O_NONBLOCK) -- 1.5.4.3

3 2

[PATCH] Add hipersockets to NETTYPE description (BZ 511962)
by Brad Hinson 16 Jul '09

16 Jul '09

Cosmetic issue. Add "hipersockets" to help text for nettype question on s390. --- anaconda-11.1.2.185/loader2/linuxrc.s390.orig +++ anaconda-11.1.2.185/loader2/linuxrc.s390 @@ -1068,7 +1068,7 @@ function question_choices_nettype() { function helptext_nettype() { echo $" Help text for network type:" echo $" qeth: OSA-Express Fast Ethernet, Gigabit Ethernet (including 1000Base-T)," - echo $" High Speed Token Ring, and ATM (running Ethernet LAN emulation)" + echo $" High Speed Token Ring, Hipersockets, and ATM (running Ethernet LAN emulation)" echo $" features in QDIO mode." echo $" [default]" echo $" lcs: OSA-2 Ethernet/Token Ring, OSA-Express Fast Ethernet in non-QDIO mode,"

2 2

Long Formatting Time when Installing from livecd on netbooks- Bug #502771 - Investigation and patch
by Eric Kerin 16 Jul '09

16 Jul '09

I think the approval queue ate my first email, let's try this again... ---------- Forwarded message ---------- From: Eric Kerin <eric_kerin(a)us.jabil.com> Date: Thu, Jul 9, 2009 at 4:18 PM Subject: Installing livecd from USB stick - Bug #502771 - Investigation and patch To: anaconda-devel-list(a)redhat.com Cc: clumens(a)redhat.com I put this in bugzilla in the closed bug - it was marked as a duplicate of another, it was suggested that I post it here. Quick summary - mke2fs will finish it's work quickly, and anaconda will spend quite sometime reading in the output, and updating the progress dialog in certain cases - the attached patch adds a check to the read/progress loop to check to see if the process has finished, and jumps out early if that's the case. Long story - I'm working on a netbook livecd install for Fedora. With the screen size of the machine I have to test on, anaconda goes into full-screen mode, the progress dialog goes full-screen as well (and remains hidden too, have not checked into this yet), it looks like because of this, it takes a long time for the progress pulses to return. (FYI - my machine also happens to be running maximus, but anaconda is excluded from it's maximizing effects) I ran into the same problem as others have, where you can hit next early, and applied the patch to make the progress dialog modal, but still ran into long periods of time where it was "formatting" with no disk IO. A quick check, and mke2fs was defunct, and anaconda was using up CPU nicely. I did some digging, and found that it was still reading the stdout data from mke2fs (it was printed very slowly, one character at a time to /dev/tty5) What I found, was that since iutil.py's execWithPulseProgress method reads one character at a time, in cases where the progress.pulse() method takes a long time to return, it slows up the reading of data, and the eventual reaping of the process. Which manifests as a defunct mke2fs process. If you give it long enough, it will continue the install. Long enough being 10 minutes or so, depending on your system. There's a loop in gui.py that smooths the pulses if it took a long time between calls, that's where a lot of the delay is spent, doing processEvents(), and because of the loop and smoothing it can start to take even longer - the first call to pulse that waits is is for <1s, next one smoothing a delta of 5 seconds, the next call is for 20 s delta, then 80 s delta...Eventually, it reads every character, after this exponentially increasing wait state. The attached patch does two things, only the change to iutil.py is really necessary - it just checks to see if the child process has exited already, and breaks if it is, since we don't need the output of the child process anyway. The patch for gui.py just keeps the delay from getting exponentially longer. Thanks, Eric Kerin

2 1

[PATCH] Multiple fstab entries of a single nodev fstype
by David Lehman 16 Jul '09

16 Jul '09

This patch set handles cases like multiple tmpfs entries in /etc/fstab on upgrade/rescue.

2 4

Fix installation of grub on md raid 1 devices.
by Radek Vykydal 16 Jul '09

16 Jul '09

Comes in two patches. Behaviour is described in comment of 2/2 patch, and corresponds to 3) from https://www.redhat.com/archives/anaconda-devel-list/2009-July/msg00157.html I tested the patches for these configs: disks sda, sdb, sdc /boot: grub target: -> grub was installed on: sdb1 sda (MBR) sda sdb1 sdb1 sdb1 md0 (sda1+sdb1) sda (MBR) sda, sdb md0 (sda1+sdb1) md0 sda1, sdb1 md0 (sdb1+sdc1) sda (MBR) sda, sdb, sdc md0 (sdb1+sdc1) md0 sdb1, sdc1 without /boot partition, /: grub target: -> grub was installed on: md0 (sda1+sdb1) sda sda, sdb md0 (sda1+sdb1) md0 sda1, sdb1 all boot OK, but I didn't tested behaviour after disk removals much (I got grub> prompt in cases I tried) Note: - UI (grub target selection wording) should be perhaps fixed to reflect the changes - Update of grub should be fixed to reflect the changes: up to this patch (f11) boot=/dev/md0 we wrote into /etc/sysconfig/grub or grub.conf meant that bootloader was installed on mbrs, and after patching it would mean that it is on raid device (partitions). We use this value in upgradeGrub.

2 3

[PATCH] Handle editing of LUKS partitions for which we have no key. (#502310)
by David Lehman 16 Jul '09

16 Jul '09

--- iw/partition_dialog_gui.py | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/iw/partition_dialog_gui.py b/iw/partition_dialog_gui.py index d38aa4e..9002175 100644 --- a/iw/partition_dialog_gui.py +++ b/iw/partition_dialog_gui.py @@ -215,7 +215,10 @@ class PartitionEditor: # preexisting partition request = self.origrequest if request.format.type == "luks": - usedev = self.storage.devicetree.getChildren(request)[0] + try: + usedev = self.storage.devicetree.getChildren(request)[0] + except IndexError: + usedev = request else: usedev = request -- 1.6.0.6

2 2

[PATCH] Allow creation of four primary partitions on a disk. (#505269)
by David Lehman 16 Jul '09

16 Jul '09

--- storage/partitioning.py | 15 ++++++++------- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/storage/partitioning.py b/storage/partitioning.py index d5a8ea7..7e7a05a 100644 --- a/storage/partitioning.py +++ b/storage/partitioning.py @@ -706,10 +706,6 @@ def allocatePartitions(disks, partitions): sectorSize = disk.device.physicalSectorSize best = None - # TODO: On alpha we are supposed to reserve either one or two - # MB at the beginning of each disk. Awesome. - # -- maybe we do not care about alpha... - log.debug("checking freespace on %s" % _disk.name) new_part_type = getNextPartitionType(disk) @@ -719,9 +715,14 @@ def allocatePartitions(disks, partitions): continue if _part.req_primary and new_part_type != parted.PARTITION_NORMAL: - # we need a primary slot and none are free on this disk - log.debug("no primary slots available on %s" % _disk.name) - continue + if disk.primaryPartitionCount < disk.maxPrimaryPartitionCount: + # don't fail to create a primary if there are only three + # primary partitions on the disk (#505269) + new_part_type = parted.PARTITION_NORMAL + else: + # we need a primary slot and none are free on this disk + log.debug("no primary slots available on %s" % _disk.name) + continue best = getBestFreeSpaceRegion(disk, new_part_type, -- 1.6.0.6

2 1

[PATCH 1/2] Call mdadm -I with --no-degraded for all disks but the last
by Hans de Goede 15 Jul '09

15 Jul '09

We do not want to bring arrays up (and esp not use, so not scan them) in degraded mode, so add --no-degraded to the mdadm invocation. Note we do not add --no-degraded to the mdadm invocation for the last disk of the set, because doing so assembles the array in an inactive (and thus unusable) state. --- storage/devices.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/storage/devices.py b/storage/devices.py index b46479b..f3f29a4 100644 --- a/storage/devices.py +++ b/storage/devices.py @@ -2426,7 +2426,7 @@ class MDRaidArrayDevice(StorageDevice): device.setup() udev_settle(timeout=10) try: - mdraid.mdadd(device.path) + mdraid.mdadd(device.path, len(self.devices) < self.memberDevices) except MDRaidError as e: log.warning("failed to add member %s to md array %s: %s" % (device.path, self.path, e)) -- 1.6.2.2

4 6

[PATCH 1/3] Call mdadm -I with --no-degraded for all disks but the last
by Hans de Goede 15 Jul '09

15 Jul '09

2 3

← Newer
1
2
3
4
5
6
7
8
9
10
Older →

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Anaconda-devel July 2009