Anaconda-devel October 2011

anaconda-devel@lists.fedoraproject.org

25 participants
57 discussions

[f16-branch] Run grub2-config before grub2-mkconfig (736993)
by Peter Jones 25 Oct '11

25 Oct '11

serial.mod doesn't get created until grub2-install gets run, but grub2-mkconfig needs it. Haven't figured out what the right thing to do is, but running grub2-install once ahead of time seems to fix it, so for f16 that's looking like our best option. --- pyanaconda/bootloader.py | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/pyanaconda/bootloader.py b/pyanaconda/bootloader.py index d187ec7..6250f74 100644 --- a/pyanaconda/bootloader.py +++ b/pyanaconda/bootloader.py @@ -1661,6 +1661,15 @@ class GRUB2(GRUB): if rc: log.error("failed to set default menu entry to %s" % productName) + # serial.mod doesn't exist until grub2-install is run, but + # grub2-mkconfig will fail on some serial-console machines unless + # it is there. So just run grub2-install once to make sure the + # necessary modules are there before configuring. + try: + self.install(install_root = install_root) + except: + pass + # now tell grub2 to generate the main configuration file rc = iutil.execWithRedirect("grub2-mkconfig", ["-o", self.config_file], -- 1.7.6.4

2 1

(no subject)
by Martin Gracik 25 Oct '11

25 Oct '11

cherry-pick from master

1 2

[PATCH][rhel5-branch] fix max lv size calculation
by David Lehman 25 Oct '11

25 Oct '11

Update max lv size to use lvm2's limits instead of lvm1's. Also, when we're validating a new pesize we should be checking the sizes of the lvs clamped using the new pesize, not the old one. Right?

2 2

[PATCH][f16-branch] Don't allow disks containing the live media as boot disk. (#748587)
by David Lehman 25 Oct '11

25 Oct '11

The code to detect the live device's backing device was also broken, partially because the format of the root line changed in /run/initramfs/tmp/root.info. This'll fix it until they change it again next week sometime. --- pyanaconda/iw/cleardisks_gui.py | 2 +- pyanaconda/storage/devicetree.py | 9 +++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/pyanaconda/iw/cleardisks_gui.py b/pyanaconda/iw/cleardisks_gui.py index 4713173..9ab4799 100644 --- a/pyanaconda/iw/cleardisks_gui.py +++ b/pyanaconda/iw/cleardisks_gui.py @@ -162,7 +162,7 @@ class ClearDisksWindow (InstallWindow): if self.anaconda.storage.doAutoPart: use_disks = self.anaconda.storage.config.clearPartDisks else: - use_disks = [d.name for d in disks] + use_disks = [d.name for d in disks if not d.protected] self.addButton.set_sensitive(False) self.removeButton.set_sensitive(False) diff --git a/pyanaconda/storage/devicetree.py b/pyanaconda/storage/devicetree.py index 27827f2..7b411e6 100644 --- a/pyanaconda/storage/devicetree.py +++ b/pyanaconda/storage/devicetree.py @@ -1028,14 +1028,15 @@ class DeviceTree(object): dev_live = "/dev/live" root_path = "" if os.path.exists(dev_live): - root_path = os.readlink(dev_live) + root_path = os.path.realpath(dev_live) elif os.path.exists(root_info): - prefix = "root='block:" + prefix = "root='" for line in open(root_info): - if not line.startswith(prefix): + if not line.startswith(prefix) or \ + (line[6:12] != "block:" and line[6:11] != "live:"): continue - start_idx = len(prefix) - 1 + start_idx = line.index(":") + 1 root_path = os.path.realpath(line[start_idx:-1]) root_name = devicePathToName(root_path) if root_name.startswith("dm-"): -- 1.7.6

2 1

Merging new image building code (treebuilder)
by Will Woods 24 Oct '11

24 Oct '11

The stars have aligned! The time is upon us! Iä! Iä! Treebuilder Fhtagn! I'm planning to merge treebuilder into (or perhaps "over") lorax's "master" branch today or tomorrow. In the next days I'll throw together some Feature pages and/or a roadmap on lorax's Trac instance so we have a clearer idea of what's changed and what's still coming, but here's the New Features: - Faster startup[1]! F15: 25s F16 TC: 25s Treebuilder F16: 15s - Lower memory use[2]! F15: 541MB F16 TC: 320MB Treebuilder F16: 195MB - Normal dracut initrd (21MB! No 'loader'[3]!) - Netboot for PPC works again[4]! - New, expanded template language makes customizing images easy[5]! I've tried to make sure that any bugfixes that went into master got pulled into treebuilder, but it's possible that I've missed some. So if you've fixed bugs in lorax recently (or say the past 6 months) it'd really help if you could check the treebuilder logs to see if the fix got ported. Please let me know if you've got any questions about (or problems with) the plan[7]! -w [appendix: some details on the changes in treebuilder] # Images are built like Live images. This means: * runtime is LiveOS/squashfs.img * initramfs is built by dracut - we do include some special dracut modules (e.g. livenet) * booting requires a correct root=live:XXX arg - written into the bootloader config by lorax - "root=live:/dev/sr0" will work in a pinch - with livenet, "root=live:http://.../squashfs.img" is valid (pass "ip=XXX ..." to set up the network first) # New, expanded template language - Nearly all the image building happens in the templates - New commands to help simplify/clarify the build process: install, mkdir, replace, append, hardlink, symlink, copy, copyif, move, moveif, remove, chmod, gconfset, installpkg, removepkg, removefrom, run_pkg_transaction, treeinfo, installkernel, installinitrd, runcmd - Lorax image build happens in 4 stages: install, postinstall, cleanup, and (per-arch) image build. - More code should move into the templates over time. # Data/config files moved out of anaconda and into lorax - These should actually all move out of lorax and into a separate subpackage, but we need to rework some bits of lorax first. [1] Time to "Starting Anaconda [...]" message in a KVM guest with 768MB RAM. Host system is a MacBookPro7,1 running x86_64 F16. Results were the same for three test runs of each version. [2] Difference of "MemTotal" and "MemFree" lines in /proc/meminfo after running "echo 3 > /proc/sys/vm/drop_caches; sleep 1", after anaconda has started its GUI. Variance between test runs was negligible (~0.1%). [3] 'loader' is still in the anaconda runtime, but we're working on replacing it. [4] netbooting with treebuilder images currently requires different boot arguments than previous versions of Fedora/RHEL [5] Well, OK, this is a matter of opinion; some people think shell is simple and clear enough for any task. (Those people are wrong[5a].) [5a] This is also a matter of opinion, but if you really want to know more about What I Think Is Wrong With Bash I'd be happy to explain my position - using colorful and inventive curse words and possibly obscene hand gestures - after you buy me a beer. [7] Special note for future readers: this would have been the time to bring up the problem(s) you're now having with the plan. Y'know, for future reference. Which I guess is just "reference" for you, since you're in the future. How's it going, by the way? Do you guys have jetpacks yet or what?

2 2

[PATCH] [5.8] We need portmap on all arches because of new NFS
by Martin Sivak 24 Oct '11

24 Oct '11

Resolves: rhbz#742889 --- scripts/upd-instroot | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/upd-instroot b/scripts/upd-instroot index 1f5b9cd..09cf644 100755 --- a/scripts/upd-instroot +++ b/scripts/upd-instroot @@ -124,7 +124,7 @@ PACKAGES="glibc glibc-common setup openssl python python-libs newt slang libseli libselinux-python nss udev keyutils-libs nspr python-iniparse cryptsetup-luks e4fsprogs fipscheck fipscheck-lib libdrm libmlx4 subscription-manager python-dmidecode python-ethtool - python-rhsm python-simplejson PyXML m2crypto" + python-rhsm python-simplejson PyXML m2crypto portmap" if [ $ARCH = i386 -o $ARCH = x86_64 ]; then PACKAGES="$PACKAGES pcmciautils" @@ -141,7 +141,7 @@ fi if [ $ARCH = s390 -o $ARCH = s390x ]; then PACKAGES="$PACKAGES s390utils binutils libgcc tcp_wrappers sed net-tools xinetd openssl openssh openssh-server coreutils - login initscripts XFree86-xauth bash portmap pam + login initscripts XFree86-xauth bash pam telnet-server login mount grep modutils gawk XFree86-libs strace xorg-x11-xauth xorg-x11-libs" fi @@ -374,6 +374,7 @@ sbin/mkswap sbin/parted sbin/pcmcia-socket-startup sbin/pdisk +sbin/portmap sbin/probe sbin/reiserfstune sbin/resize2fs @@ -557,7 +558,6 @@ sbin/cmsfscat sbin/busybox sbin/ifconfig sbin/route -sbin/portmap sbin/fdasd sbin/dasdfmt sbin/swapon -- 1.7.4.4

2 1

[f16-branch] Regenerate tasklist when a repo is removed.
by Ales Kozumplik 24 Oct '11

24 Oct '11

Resolves: rhbz#746573 --- pyanaconda/iw/task_gui.py | 12 ++++++++---- 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/pyanaconda/iw/task_gui.py b/pyanaconda/iw/task_gui.py index 7ff96ab..21b5587 100644 --- a/pyanaconda/iw/task_gui.py +++ b/pyanaconda/iw/task_gui.py @@ -96,7 +96,7 @@ class RepoEditor: def on_mirrorlistCheckbox_toggled(self, widget, *args): pass - def __init__(self, anaconda, repoObj): + def __init__(self, anaconda, repoObj, group_update_cb=lambda:None): self.anaconda = anaconda self.backend = self.anaconda.backend self.intf = self.anaconda.intf @@ -126,6 +126,8 @@ class RepoEditor: self.dialog.set_title(_("Edit Repository")) + self.group_update_cb = group_update_cb + # Remove these until they are actually implemented self.typeComboBox.remove_text(3) @@ -394,6 +396,7 @@ class RepoEditor: # update groups information try: self.anaconda.backend.ayum.doGroupSetup() + self.group_update_cb() except Exception as e: log.debug("unable to reset group information after UI repo edit: %s" % e) @@ -536,7 +539,7 @@ class TaskWindow(InstallWindow): return gtk.RESPONSE_CANCEL - dialog = RepoEditor(self.anaconda, repo) + dialog = RepoEditor(self.anaconda, repo, self._refresh_task_list) dialog.createDialog() dialog.run() @@ -596,11 +599,12 @@ class TaskWindow(InstallWindow): store.set_value(i, 0, not wasChecked) - def _createTaskStore(self): + def _refresh_task_list(self): store = gtk.ListStore(gobject.TYPE_BOOLEAN, gobject.TYPE_STRING, gobject.TYPE_PYOBJECT) tl = self.xml.get_widget("taskList") + map(lambda col: tl.remove_column(col) , tl.get_columns()) tl.set_model(store) cbr = gtk.CellRendererToggle() @@ -697,7 +701,7 @@ class TaskWindow(InstallWindow): else: self.xml.get_widget("customRadio").set_active(False) - self.ts = self._createTaskStore() + self.ts = self._refresh_task_list() self.rs = self._createRepoStore() if len(self.ts.get_model()) == 0: -- 1.7.6.4

2 1

[PATCH] clean up x86 composes
by Dennis Gilmore 22 Oct '11

22 Oct '11

firstaidkit-plugin-grub is no longer installable grub is replaced by grub2 and grub-efi --- share/ramdisk.ltmpl | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/share/ramdisk.ltmpl b/share/ramdisk.ltmpl index 69bebf1..032ba4d 100644 --- a/share/ramdisk.ltmpl +++ b/share/ramdisk.ltmpl @@ -18,8 +18,8 @@ install "kernel" % if basearch == "i386" or basearch == "x86_64": install "biosdevname" install "efibootmgr" - install "firstaidkit-plugin-grub" - install "grub" + install "grub-efi" + install "grub2" install "memtest86+" % endif -- 1.7.6.4

2 2

[f16-branch] only allow GPT boot flag on EFI System partition (#746895)
by Brian C. Lane 21 Oct '11

21 Oct '11

From: "Brian C. Lane" <bcl(a)redhat.com> When parted sets the boot flag on a GPT labeled disk's partition it sets the EFI System GUID type. This results in BIOS systems' boot partition having the wrong GUID type, and EFI systems having multiple EFI System partitions. --- pyanaconda/storage/__init__.py | 11 +++++++++-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/pyanaconda/storage/__init__.py b/pyanaconda/storage/__init__.py index 47c93fe..db84a99 100644 --- a/pyanaconda/storage/__init__.py +++ b/pyanaconda/storage/__init__.py @@ -408,9 +408,16 @@ class Storage(object): p.getFlag(parted.PARTITION_BOOT): skip = True break + + # GPT labeled disks should only have bootable set on the + # EFI system partition (parted sets the EFI System GUID on + # GPT partitions with the boot flag) + if dev.disk.format.partedDisk.type == "gpt" and \ + dev.format.type != "efi": + skip = True + if skip: - log.info("not setting boot flag on %s as there is" - "another active partition" % dev.name) + log.info("not setting boot flag on %s" % dev.name) continue log.info("setting boot flag on %s" % dev.name) dev.bootable = True -- 1.7.6.4

1 0

[master][f16-branch]
by David Lehman 21 Oct '11

21 Oct '11

With this patch we allow users to use fsprofile on preexisting devices.

2 2

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Anaconda-devel October 2011