Anaconda-devel February 2011

anaconda-devel@lists.fedoraproject.org

21 participants
82 discussions

[firstboot] Fix username guessing with unicode chars (#677904)
by Martin Gracik 17 Feb '11

17 Feb '11

--- modules/create_user.py | 13 ++++++++++--- 1 files changed, 10 insertions(+), 3 deletions(-) diff --git a/modules/create_user.py b/modules/create_user.py index d162fad..7628364 100644 --- a/modules/create_user.py +++ b/modules/create_user.py @@ -22,6 +22,7 @@ import libuser import os, string, sys, time import os.path import pwd +import unicodedata from firstboot.config import * from firstboot.constants import * @@ -413,10 +414,16 @@ class moduleClass(Module): try: user = name.split()[0] except IndexError: - user = "" - else: - user = user.encode("ascii", "ascii_transliterate") + user = u"" + + # convert to ascii (try to replace characters) + try: + nfkd = unicodedata.normalize("NFKD", user) + user = u"".join([c for c in nfkd if not unicodedata.combining(c)]) + user = user.encode("ascii", "ignore") user = user.lower() + except: + user = "" self.usernameEntry.handler_block_by_func(self.usernameEntry_changed) self.usernameEntry.set_text(user) -- 1.7.3.2

1 0

[PATCH][f15, master] Don't clear partition 1 from mac disks even if it has no name. (#674105)
by David Lehman 16 Feb '11

16 Feb '11

--- pyanaconda/storage/partitioning.py | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/pyanaconda/storage/partitioning.py b/pyanaconda/storage/partitioning.py index 65902ff..e8f3921 100644 --- a/pyanaconda/storage/partitioning.py +++ b/pyanaconda/storage/partitioning.py @@ -293,8 +293,7 @@ def shouldClear(device, clearPartType, clearPartDisks=None): # Never clear the special first partition on a Mac disk label, as that # holds the partition table itself. if device.disk.format.partedDisk.type == "mac" and \ - device.partedPartition.number == 1 and \ - device.partedPartition.name == "Apple": + device.partedPartition.number == 1: return False # If we got a list of disks to clear, make sure this one's on it -- 1.7.3.5

2 1

[PATCH] Don't show loaderSegvHandler or its glibc entry point in tracebacks.
by Peter Jones 16 Feb '11

16 Feb '11

Since we get things like the traceback in 678086 , we're better off not showing the traceback handler in the traceback. --- loader/loader.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/loader/loader.c b/loader/loader.c index 644c1e8..06ca450 100644 --- a/loader/loader.c +++ b/loader/loader.c @@ -1686,7 +1686,10 @@ void loaderSegvHandler(int signum) { } i = backtrace (array, 30); - backtrace_symbols_fd(array, i, STDERR_FILENO); + if (signum == SIGSEGV) + backtrace_symbols_fd(array+2, i-2, STDERR_FILENO); + else + backtrace_symbols_fd(array+1, i-1, STDERR_FILENO); _exit(1); } -- 1.7.3.4

2 1

[PATCH f15-alpha, etc.] Only check for the addons of enabled repos (#677773).
by Chris Lumens 16 Feb '11

16 Feb '11

This ensures that we will not try to fetch .treeinfo for one of the disabled updates repos on a DVD install, therefore requiring the network. --- pyanaconda/yuminstall.py | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/pyanaconda/yuminstall.py b/pyanaconda/yuminstall.py index d15c6d5..6aa2ca7 100644 --- a/pyanaconda/yuminstall.py +++ b/pyanaconda/yuminstall.py @@ -867,15 +867,14 @@ class AnacondaYum(yum.YumBase): extraRepos.append(repo) initialRepos = self.repos.repos.values() + extraRepos - for repo in initialRepos: + for repo in filter(lambda r: r.isEnabled(), initialRepos): addons = self._getAddons(repo.mirrorlist or repo.baseurl[0], repo.proxy_url) for addon in addons: addonRepo = AnacondaYumRepo(addon[0]) addonRepo.name = addon[1] addonRepo.baseurl = [ addon[2] ] - if repo.isEnabled(): - addonRepo.enable() + addonRepo.enable() if self.anaconda.proxy: self.setProxy(self.anaconda, addonRepo) -- 1.7.1.1

2 1

[PATCH][f15, master] Handle quotes around labels and UUIDs in /etc/fstab. (#670496)
by David Lehman 15 Feb '11

15 Feb '11

--- pyanaconda/storage/devicetree.py | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/pyanaconda/storage/devicetree.py b/pyanaconda/storage/devicetree.py index 05bc3b7..6fac6f5 100644 --- a/pyanaconda/storage/devicetree.py +++ b/pyanaconda/storage/devicetree.py @@ -2013,12 +2013,18 @@ class DeviceTree(object): if devspec.startswith("UUID="): # device-by-uuid uuid = devspec.partition("=")[2] + if ((uuid.startswith('"') and uuid.endswith('"')) or + (uuid.startswith("'") and uuid.endswith("'"))): + uuid = uuid[1:-1] device = self.uuids.get(uuid) if device is None: log.error("failed to resolve device %s" % devspec) elif devspec.startswith("LABEL="): # device-by-label label = devspec.partition("=")[2] + if ((label.startswith('"') and label.endswith('"')) or + (label.startswith("'") and label.endswith("'"))): + label = label[1:-1] device = self.labels.get(label) if device is None: log.error("failed to resolve device %s" % devspec) -- 1.7.3.5

2 1

[PATCH f15-alpha, etc.] Fix loader translations in loader (#677648).
by Chris Lumens 15 Feb '11

15 Feb '11

We need to pass unpack_archive_file the name of the translation archive, then later open a specific file out of the unpacked directory. --- loader/lang.c | 14 ++++++++------ 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/loader/lang.c b/loader/lang.c index f3e00df..651c1a0 100644 --- a/loader/lang.c +++ b/loader/lang.c @@ -143,7 +143,7 @@ int getLangInfo(struct langInfo ** langs) { } void loadLanguage (char * file) { - char filename[200]; + char *filename; int fd, hash, rc; char * key = getenv("LANGKEY"); @@ -166,19 +166,20 @@ void loadLanguage (char * file) { "The Installation will proceed in English.", key); return ; } - - sprintf(filename, "%s.tr", key); - rc = unpack_archive_file(filename, "/tmp/translation"); + + rc = unpack_archive_file("/etc/loader.tr", "/tmp/translation"); if (rc != ARCHIVE_OK || access("/tmp/translation", R_OK) == -1) { newtWinMessage("Error", "OK", "Cannot get translation file %s.\n", filename); return; } - - fd = open("/tmp/translation", O_RDONLY); + + checked_asprintf(&filename, "/tmp/translation/%s.tr", key); + fd = open(filename, O_RDONLY); if (fd < 0) { newtWinMessage("Error", "OK", "Failed to open /tmp/translation: %m\n"); + free(filename); return; } @@ -198,6 +199,7 @@ void loadLanguage (char * file) { } close(fd); + free(filename); unlink("/tmp/translation"); qsort(strings, numStrings, sizeof(*strings), aStringCmp); -- 1.7.1.1

2 1

[PATCH f15-alpha, etc.] Don't always attempt to load updates on kickstart installs (#677131).
by Chris Lumens 15 Feb '11

15 Feb '11

pykickstart ensures that if "updates" is given, url is set to "floppy". Otherwise, you've either provided a URL or skipped the command entirely. In the last case, url is "". --- loader/kickstart.c | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/loader/kickstart.c b/loader/kickstart.c index 69bb8f1..6df3040 100644 --- a/loader/kickstart.c +++ b/loader/kickstart.c @@ -497,10 +497,12 @@ static void setVnc(struct loaderData_s * loaderData, PyObject *handler) { static void setUpdates(struct loaderData_s * loaderData, PyObject *handler) { PyObject *url = getattr(handler, "updates", "url"); - if (!isNotEmpty(url) || objIsStr(url, "floppy")) - flags |= LOADER_FLAGS_UPDATES; - else if (isNotEmpty(url)) - loaderData->updatessrc = strdup(PyString_AsString(url)); + if (isNotEmpty(url)) { + if (objIsStr(url, "floppy")) + flags |= LOADER_FLAGS_UPDATES; + else + loaderData->updatessrc = strdup(PyString_AsString(url)); + } Py_XDECREF(url); } -- 1.7.1.1

2 1

[master][rhel6-branch] prevent large ppc64 images
by David Cantrell 15 Feb '11

15 Feb '11

Safety check until we solve this problem once and for all. For both master and rhel6-branch -- David Cantrell <dcantrell(a)redhat.com> Supervisor, Installer Engineering Team Red Hat, Inc. | Honolulu, HI | UTC-10

2 2

[master] enable firstboot on s390x
by David Cantrell 15 Feb '11

15 Feb '11

SSIA -- David Cantrell <dcantrell(a)redhat.com> Supervisor, Installer Engineering Team Red Hat, Inc. | Honolulu, HI | UTC-10

2 2

[rhel6-branch] enable firstboot on s390x
by David Cantrell 15 Feb '11

15 Feb '11

SSIA -- David Cantrell <dcantrell(a)redhat.com> Supervisor, Installer Engineering Team Red Hat, Inc. | Honolulu, HI | UTC-10

2 2

← Newer
1
2
3
4
5
6
7
8
9
Older →

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Anaconda-devel February 2011