Anaconda-devel September 2011

anaconda-devel@lists.fedoraproject.org

24 participants
81 discussions

[PATCH 1/2] make anaconda-shell.service a template, put it on tty2 & hvc1
by Will Woods 21 Sep '11

21 Sep '11

We're also passing "-l /bin/bash -o '--login'", which does the no-login thing for us, so we can remove the silly hack where we replace /bin/login with a shell script that runs bash. --- data/systemd/anaconda-shell.service | 13 ++++++++----- data/systemd/anaconda.target | 1 + 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/data/systemd/anaconda-shell.service b/data/systemd/anaconda-shell.service index 8d41146..78c07a3 100644 --- a/data/systemd/anaconda-shell.service +++ b/data/systemd/anaconda-shell.service @@ -1,16 +1,19 @@ +# anaconda-shell@.service +# This is roughly equivalent to getty@.service, except with '-n' so we don't +# spawn login [Unit] -Description=Shell on tty2 -BindTo=dev-tty2.device -After=dev-tty2.device +Description=Shell on %I +BindTo=dev-%i.device +After=dev-%i.device [Service] Environment=TERM=linux WorkingDirectory=/ -ExecStart=-/sbin/agetty -n tty2 38400 +ExecStart=-/sbin/agetty -n -l /bin/bash -o '--login' %I 38400 Restart=always RestartSec=0 TimeoutSec=0 -TTYPath=/dev/tty2 +TTYPath=/dev/%i TTYReset=yes TTYVHangup=yes TTYVTDisallocate=yes diff --git a/data/systemd/anaconda.target b/data/systemd/anaconda.target index 1886399..ac6d6e1 100644 --- a/data/systemd/anaconda.target +++ b/data/systemd/anaconda.target @@ -4,3 +4,4 @@ Requires=basic.target Conflicts=rescue.service rescue.target After=basic.target rescue.service rescue.target AllowIsolate=yes +Wants=anaconda-shell(a)tty2.service anaconda-shell(a)hvc1.service -- 1.7.6.2

2 2

[rhel6-branch] don't enable tboot on Xen guests
by David Cantrell 21 Sep '11

21 Sep '11

It doesn't work. And something for master is probably in order too, but not necessarily this patch. -- David Cantrell <dcantrell(a)redhat.com> Supervisor, Installer Engineering Team Red Hat, Inc. | Westford, MA | EST5EDT

3 3

Default repo lines
by Jeremy Sanders 20 Sep '11

20 Sep '11

Hi - While debugging a confusing error caused by different versions of packages being installed on different machines, I see that anaconda includes its own particular repo lines for Fedora installs. We were adding repo lines with the same names pointing to a caching mirror. This didn't give an error for an F14 install. Is it possible to disable the default repos, to ensure that the files come from our own caching mirror? Thanks Jeremy

2 1

[F16 PATCH 1/2] Update test for createUser and createGroup (#739428)
by Brian C. Lane 20 Sep '11

20 Sep '11

From: "Brian C. Lane" <bcl(a)redhat.com> --- tests/pyanaconda_test/users_test.py | 19 ++++++++++++++++--- 1 files changed, 16 insertions(+), 3 deletions(-) diff --git a/tests/pyanaconda_test/users_test.py b/tests/pyanaconda_test/users_test.py index e34bb9e..c7246ea 100644 --- a/tests/pyanaconda_test/users_test.py +++ b/tests/pyanaconda_test/users_test.py @@ -41,9 +41,13 @@ class UsersTest(mock.TestCase): GROUP = 'Group' GID = 100 + group_dict = { "name" : GROUP, + "gid" : GID, + "root" : "" + } usr = pyanaconda.users.Users(self.anaconda) - self.assertTrue(usr.createGroup(GROUP, gid=GID, root='')) + self.assertTrue(usr.createGroup(GROUP, **group_dict)) methods = pyanaconda.users.libuser.admin().method_calls[:] try: @@ -64,13 +68,22 @@ class UsersTest(mock.TestCase): USER = 'TestUser' PASS = 'abcde' + user_dict = { "name" : USER, + "password" : PASS, + "groups" : [], + "homedir" : "", + "isCrypted" : False, + "shell" : "", + "uid" : None, + "root" : "" + } usr = pyanaconda.users.Users(self.anaconda) - self.assertTrue(usr.createUser(USER, password=PASS, root='')) + self.assertTrue(usr.createUser(USER, **user_dict)) self.assertTrue(pyanaconda.users.iutil.mkdirChain.called) - methods = [x[0] for x in pyanaconda.users.libuser.admin().method_calls] + self.assertEqual(methods, ['lookupUserByName', 'initUser', 'initGroup', 'addUser','addGroup', 'setpassUser', 'lookupGroupByName']) -- 1.7.6

3 6

[rhel6-branch] Fix format.majorminor caching.
by Ales Kozumplik 20 Sep '11

20 Sep '11

0edfaf507967f0c1f35b9ce2da12672ec0904948 misses that on rhel6-branch the StorageDevice.teardown() *is not* called by most of the device-specific teardown() methods. Related: rhbz#731973 --- storage/devices.py | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/storage/devices.py b/storage/devices.py index 864d37b..0450ceb 100644 --- a/storage/devices.py +++ b/storage/devices.py @@ -2981,6 +2981,7 @@ class MDRaidArrayDevice(StorageDevice): if self.status: if self.originalFormat.exists: self.originalFormat.teardown() + self.format.cacheMajorminor() if self.format.exists: self.format.teardown() udev_settle() -- 1.7.6

2 1

[f16-branch] Revert "Set debug_package to %{nil} so we don't strip our binaries."
by Ales Kozumplik 20 Sep '11

20 Sep '11

The experiment didn't work, the binaries are stripped anyway. That left us with no way to debug segv tracebacks such as in bug 734967. This reverts commit 50c4ea0a9d02ce878c15cafc5048dcfcdf38b88b. Related: rhbz#734967 --- anaconda.spec.in | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/anaconda.spec.in b/anaconda.spec.in index 562edce..76a782d 100644 --- a/anaconda.spec.in +++ b/anaconda.spec.in @@ -8,8 +8,6 @@ License: GPLv2+ Group: Applications/System URL: http://fedoraproject.org/wiki/Anaconda -%define debug_package %{nil} - # To generate Source0 do: # git clone http://git.fedorahosted.org/git/anaconda.git # git checkout -b archive-branch anaconda-%{version}-%{release} -- 1.7.6

1 0

[PATCH 1/2 master] Do not reactivate network device needlessly on s390 (#739846)
by Radek Vykydal 20 Sep '11

20 Sep '11

On s390, the device is activated when NM is started due to ifcfg file generated by linuxrc.390. There is no need to reactivate it with the same parameters (it would even lead to fail). This condition (2nd part) from kickstartNetworkUp was causing (or perhaps to put it better - not preventing) the ractivation in case of already having been connected: if ((is_nm_connected() == TRUE) && (loaderData->netDev != NULL) && (loaderData->netDev_set == 1)) return 0; To satisfy it, just set the values properly in readNetInfo (the patch). --- loader/loader.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/loader/loader.c b/loader/loader.c index b3048cb..5d2dc01 100644 --- a/loader/loader.c +++ b/loader/loader.c @@ -746,6 +746,10 @@ static void readNetInfo(struct loaderData_s ** ld) { flags |= LOADER_FLAGS_HAVE_CMSCONF; } + loaderData->netDev = device; + loaderData->netDev_set = 1; + + free(cfgfile); g_strfreev(lines); return; -- 1.7.4

2 2

[firstboot] Do not catch exceptions from system-config-date (#737882)
by Martin Gracik 20 Sep '11

20 Sep '11

--- modules/date.py | 11 ++++------- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/modules/date.py b/modules/date.py index 2ce83d9..05601f2 100644 --- a/modules/date.py +++ b/modules/date.py @@ -46,13 +46,10 @@ class moduleClass(Module): if testing: return RESULT_SUCCESS - try: - rc = self.scd.firstboot_apply() - if rc == 0 and self.scd.closeParent: - return RESULT_SUCCESS - else: - return RESULT_FAILURE - except: + rc = self.scd.firstboot_apply() + if rc == 0 and self.scd.closeParent: + return RESULT_SUCCESS + else: return RESULT_FAILURE def createScreen(self): -- 1.7.3.2

1 0

[lorax] syslinux-vesa-splash changed filename (#739345)
by Martin Gracik 19 Sep '11

19 Sep '11

--- src/pylorax/images.py | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/pylorax/images.py b/src/pylorax/images.py index 8f2e16f..a5f4f4c 100644 --- a/src/pylorax/images.py +++ b/src/pylorax/images.py @@ -409,10 +409,10 @@ class X86(object): # splash splash = joinpaths(self.installtree.root, ANABOOTDIR, - "syslinux-vesa-splash.jpg") + "syslinux-splash.png") if not splash: - raise Exception("syslinux-vesa-splash.jpg not present") + raise Exception("syslinux-splash.png not present") self.reqs["splash"] = cpfile(splash, workdir) @@ -459,9 +459,8 @@ class X86(object): dst = cpfile(src, joinpaths(self.outputroot, ISOLINUXDIR)) replace(dst, r"@VERSION@", self.version) - # copy syslinux-vesa-splash.jpg splash = cpfile(self.reqs["splash"], - joinpaths(self.outputroot, ISOLINUXDIR, "splash.jpg")) + joinpaths(self.outputroot, ISOLINUXDIR, "splash.png")) # copy vesamenu.c32 cpfile(self.reqs["vesamenu"], -- 1.7.3.2

1 0

[PATCH][f16-branch] Improve the clarity of the missing bios boot partition error. (#731549)
by David Lehman 19 Sep '11

19 Sep '11

--- pyanaconda/bootloader.py | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/pyanaconda/bootloader.py b/pyanaconda/bootloader.py index 7732169..a3a14d4 100644 --- a/pyanaconda/bootloader.py +++ b/pyanaconda/bootloader.py @@ -1497,8 +1497,11 @@ class GRUB2(GRUB): break if not ret: - self.errors.append(_("You are using a GPT bootdisk on a BIOS " - "system without a BIOS boot partition.")) + self.errors.append(_("Your BIOS-based system needs a special " + "partition to boot with Fedora's new " + "disk label format (GPT). To continue, " + "please create a 1MB 'BIOS Boot' type " + "partition.")) log.debug("_gpt_disk_has_bios_boot(%s) returning %s" % (device.name, ret)) -- 1.7.3.4

2 1

← Newer
1
2
3
4
5
6
7
8
9
Older →

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Anaconda-devel September 2011