Anaconda-devel September 2011

anaconda-devel@lists.fedoraproject.org

24 participants
81 discussions

[PATCH] Fix post-commit lookup of extended partitions. (#737532)
by David Lehman 16 Sep '11

16 Sep '11

Commit 7ccd9ce9d6a907c switched to doing these lookups by sector, but did not take into account the fact that lookups by sector do not work for extended partitions. Another reason to love msdos labels. --- pyanaconda/storage/devices.py | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/pyanaconda/storage/devices.py b/pyanaconda/storage/devices.py index 9aa77a6..a52e464 100644 --- a/pyanaconda/storage/devices.py +++ b/pyanaconda/storage/devices.py @@ -1484,8 +1484,14 @@ class PartitionDevice(StorageDevice): raise def _postCreate(self): - start = self.partedPartition.geometry.start - partition = self.disk.format.partedDisk.getPartitionBySector(start) + if self.isExtended: + partition = self.disk.format.extendedPartition + else: + start = self.partedPartition.geometry.start + partition = self.disk.format.partedDisk.getPartitionBySector(start) + + log.debug("post-commit partition path is %s" % getattr(partition, + "path", None)) self.partedPartition = partition if not self.isExtended: # Ensure old metadata which lived in freespace so did not get -- 1.7.3.4

2 1

[PATCH f16-branch] Don't reboot when closing the live installer via the window decoration.
by Chris Lumens 16 Sep '11

16 Sep '11

Related: rhbz#705189 --- pyanaconda/gui.py | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/pyanaconda/gui.py b/pyanaconda/gui.py index e306852..a8c28bd 100755 --- a/pyanaconda/gui.py +++ b/pyanaconda/gui.py @@ -1333,7 +1333,6 @@ class InstallControlWindow: self._main_loop_running = False def _doExitConfirm (self, win = None, *args): - # FIXME: translate the string win = MessageWindow(_("Exit installer"), _("Are you sure you wish to exit the installer?"), type="custom", custom_icon="question", @@ -1341,7 +1340,7 @@ class InstallControlWindow: parent = win) if win.getrc() == 0: return True - self.close() + sys.exit(0) def createWidgets (self): """ Sets up the widgets in the main installler window. """ -- 1.7.6

2 1

[rhel5-branch] assorted patches
by David Cantrell 16 Sep '11

16 Sep '11

These are all modifications to contributed patches for rhel5-branch. -- David Cantrell <dcantrell(a)redhat.com> Supervisor, Installer Engineering Team Red Hat, Inc. | Westford, MA | EST5EDT

2 7

[PATCH f16-branch] Add a Reboot button to the congrats screen on live (#705189).
by Chris Lumens 16 Sep '11

16 Sep '11

There's no easily discoverable reboot button on the system anymore, so it's up to us to save everyone. --- anaconda | 2 +- pyanaconda/iw/congrats_gui.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/anaconda b/anaconda index c733be5..c891bc6 100755 --- a/anaconda +++ b/anaconda @@ -780,7 +780,7 @@ if __name__ == "__main__": os.system("systemctl --force --no-wall halt") else: # reboot action is KS_REBOOT or None os.system("systemctl --force --no-wall reboot") - elif not flags.livecdInstall and not flags.imageInstall: + elif not flags.imageInstall: os.system("systemctl --force --no-wall reboot") # vim:tw=78:ts=4:et:sw=4 diff --git a/pyanaconda/iw/congrats_gui.py b/pyanaconda/iw/congrats_gui.py index e5a3af3..55db9d5 100644 --- a/pyanaconda/iw/congrats_gui.py +++ b/pyanaconda/iw/congrats_gui.py @@ -46,7 +46,7 @@ class CongratulationWindow (InstallWindow): # this mucks around a bit, but it's the weird case and it's # better than adding a lot of complication to the normal ics.cw.mainxml.get_widget("nextButton").hide() - if flags.livecdInstall or flags.imageInstall: + if flags.imageInstall: ics.cw.mainxml.get_widget("closeButton").show() ics.cw.mainxml.get_widget("closeButton").grab_focus() else: -- 1.7.6

3 2

InfiniBand for 5.8
by Ales Kozumplik 15 Sep '11

15 Sep '11

With the right kind of machine, new kudzu, my own dhcpd and these patches, I have been able to install through an ib interface, address set either statically or through dhcp. Screenshot demonstrating the last patch in the set is here: http://akozumpl.fedorapeople.org/devices.png Ales

2 8

[rhel6-branch 1/2] Fix loadkeys-test (#706099)
by Martin Gracik 15 Sep '11

15 Sep '11

Because of commit 1242005618d209519b1dfe4ce46b37502ac75783 loadkeys should always exit with return code 0, even when loading a non-existing keymap. --- command-stubs/loadkeys-test | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/command-stubs/loadkeys-test b/command-stubs/loadkeys-test index dda718d..d01e127 100644 --- a/command-stubs/loadkeys-test +++ b/command-stubs/loadkeys-test @@ -31,7 +31,7 @@ def loadkeys_test(): # non-existing keymap rc = call(['loadkeys', 'bad-keymap']) - if rc == 0: + if not rc == 0: print('loadkeys: load non-existing keymap test failed') sys.exit(1) -- 1.7.3.2

2 2

Three patches to fix bugs in the hated lvm dialog
by David Lehman 15 Sep '11

15 Sep '11

/me eagerly awaits the UI redesign lvm_dialog_gui.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)

2 4

F16 patches
by David Lehman 14 Sep '11

14 Sep '11

2 4

[master] Patches for ppc64
by Will Woods 13 Sep '11

13 Sep '11

Since RHEL6 (and now F16 yum) basically decree that ppc64 basearch is 'ppc64', we need to make some changes here and there. These two patches allow the ppc64 test builds to actually start anaconda from a DVD image. Here's why: image.py compares the third (basearch) line of .discinfo to to the result of iutil.getArch(). Since yum says basearch is 'ppc64', discinfo needs to match if we're going to start the installer. As noted in the second patch, this breaks our old hack of building one ppc tree/image that has both 32/64-bit kernels. It might make sense to have image.py check if the media's basearch is *compatible with* the kernel basearch rather than *identical to*. What do you all think? -w

2 3

[rhel6-branch] Format.majorminor problems
by Ales Kozumplik 13 Sep '11

13 Sep '11

There seems to be the same problems in 6.1 we had before F15 with Format.majorminor(). I am a bit reluctant to push those before 6.2 (since they are on the risky side) but it looks like there won't be a choice. Tested on a simple lvm-on-raid setup without a traceback. I'll definitely wait for the repoter to report back.

2 5

← Newer
1
2
3
4
5
6
7
8
9
Older →

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Anaconda-devel September 2011