Anaconda-devel January 2012

anaconda-devel@lists.fedoraproject.org

22 participants
63 discussions

[newui] Keyboard layout discussion summary
by Máirín Duffy 17 Jan '12

17 Jan '12

Hi, vpodzime and I had a discussion about the keyboard layout UI and made a couple of decisions about it, so I wanted to post a summary of that so later on we'll be able to look up why we decided to do what we did. (Before & after mockups attached!) So the background of the before mockup is that it is a direct copy of the GNOME control center keyboard layout dialog. For a lot of the screens in the UI redo, there's a lot of copying of the GNOME control center dialogs because we have a theory that having consistent pre- and post-install configuration will make it more usable, rather than having users learn a different interface for pre- and post-install. (Of course there's no reason why we can't tweak or modify the post-install dialogs to suit our users' needs or constraints we have in the install environment, but starting with the same design is a good starting point I think.) The before mockup shows a search filter along the bottom of the list, which will only show layouts whose metadata match the given search term, and hides those layouts that don't. It is not limited to filtering by layout name only: if you search for 'US', for example, the 'Spanish (Latin American) layout pops up, because 'US' is in the metadata even though it's not in the name of the keyboard layout. So vpodzime had a couple of data points about the keyboard layouts: - We have about 500 possible keyboard layouts. As mocked up in the 'before', then, the list has 500 items total to browse through. - We have about 100-150 supported languages with the keyboard layouts. We also have some non-country based layouts (e.g., Dvorak, Macintosh / Sun, etc.) vpodzime's main concern was that we have a list of 500 items, and it's huge. He suggested that we follow a model similar to XFCE, using a treeview, where the parent nodes are the languages, and the child nodes are the layouts under that language. I noted that treeviews generally are less desirable than a flat list because a lot of UIs have only the 16x16 px '+' and '-' icons as a click target, which is physically difficult and frustrating for a lot of users. Vpodzime confirmed that we could implement the treeview such that clicking on the entire parent row would expand or collapse the subtree, however. We came up with a couple of use cases: - An English-speaking American who needs to add an international layout to access accent marks / Euro symbols / whatnot. - This case worked fine. I typed 'English' in the search box, and it filtered down to ~30 English layouts that were completely relevant to English input. If I typed 'English international' in the search filter, it narrowed down to 8 highly relevant results, all international US layouts. Down to 30 and down to 8 from 500 is great. - A French-speaking Swiss who needs a Switzerland-specific French layout. - This case also worked fine. I searched for 'French' in the filter box and got about 30 relevant layouts, including Belgian even though French isn't in the name of the layout. If I typed 'French swi' immediately the list shows all four Swiss French layouts and I don't need to finish typing 'Switzerland.' Down to 30 and 4 from 500 is also great. So it seems the filter box is pretty sufficient to bringing down the 500 entries down to a workable 30 or less. However, if you can only browse the list and cannot use the keyboard (perhaps the input layout is misconfigured and you're in this dialog to fix it, so it is difficult to type your filter terms), you'll have to browse a list of 500 items. Ouch. What to do? So vpodzime asked, well, if we added the tree view, would that help users who can't use the keyboard? Adding the tree view would take us down from a flat list of 500 layouts to a list of 100-150 parent nodes in a tree list. We decided it's pretty difficult to manually browse through 150 items and not much easier than 500, so adding the tree would only marginally improve the experience. (If the tree view cut the list down to 10-20 items, this would be a different story.) So we decided going with a treeview wouldn't really solve the problem for non-keyboard users. So another thing we considered is putting up front the layouts that go along with the language the user selected on the very first screen of Anaconda. E.g., we could pre-fill the filter field with the name of the language they chose, so by default if they spoke English, they'd see only the ~30 layouts relevant to English, and they would have to erase the search filter to see all 500 layouts. We decided that would be inconvenient for a lot of users, e.g., a lot of folks outside of the US like to add English as a keyboard layout, but this would then add an extra few clicks for those folks. Also, multilingual folks who can say speak Spanish, Chinese, and German (hey they exist) and would want input layouts for all three languages, and this would make it difficult for them. It seems more common that someone would speak multiple languages they'd want to input than they'd want more than one layout for a single language, so we decided to not pre-fill the field. However, what about folks who can't use the keyboard at this point? We had an idea to put some GeoIP smarts into place, if we could. So if, for example, the American wants to add US international layout... we know their main language is English from earlier screens. With GeoIP, we could detect they are within the United States. So we could highlight those keyboard layouts in the list that are most relevant to a United States location, so when the user scrolls through the list, a little icon next to the location-relevant layouts would catch their attention, making it a little bit easier for them to find the layouts they are looking for. If the user doesn't have GeoIP, no big deal - it's just a small value add, and not essential. So the 'after' mockups, attached, show how this GeoIP-based layout highlighting might work. So that's what we talked about. The decisions were: - no tree view - the search box works - don't pre-fill the search box with the user's selected language - add highlights to layouts relevant to the user's location via GeoIP if available ~m

3 3

[newui] KeyboardSpoke basic functionality (2nd run)
by Vratislav Podzimek 17 Jan '12

17 Jan '12

This is the new version of the previous patchset. This time rebased and prepared to be pushed and run by you. -- Vratislav Podzimek

2 6

[rhel6-branch] Write isfinal to the buildstamp for sparc too (#740164)
by Martin Gracik 17 Jan '12

17 Jan '12

--- scripts/mk-images.sparc | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/scripts/mk-images.sparc b/scripts/mk-images.sparc index 9525f59..eb6544e 100644 --- a/scripts/mk-images.sparc +++ b/scripts/mk-images.sparc @@ -40,6 +40,11 @@ makeproductfile() { echo $IMAGEUUID > $root/.buildstamp echo $PRODUCT >> $root/.buildstamp echo $VERSION >> $root/.buildstamp + if [ -n "$ISFINAL" ]; then + echo "FINAL=YES" >> $root/.buildstamp + else + echo "FINAL=NO" >> $root/.buildstamp + fi if [ -n "$BUGURL" ]; then echo $BUGURL >> $root/.buildstamp fi -- 1.7.5.4

2 1

[rhel6-branch 1/2] Add productIsFinal variable (#740164)
by Martin Gracik 17 Jan '12

17 Jan '12

This variable is set from .buildstamp. --- product.py | 12 +++++++++--- scripts/buildinstall | 12 ++++++++---- scripts/mk-images | 11 ++++++++++- 3 files changed, 27 insertions(+), 8 deletions(-) diff --git a/product.py b/product.py index 68df00c..896d0d4 100644 --- a/product.py +++ b/product.py @@ -40,13 +40,19 @@ if path is not None: f = open(path, "r") lines = f.readlines() del f - if len(lines) >= 3: + if len(lines) >= 4: productStamp = lines[0][:-1] productArch = productStamp[productStamp.index(".")+1:] productName = lines[1][:-1] productVersion = lines[2][:-1] - if len(lines) >= 4: - bugUrl = lines[3][:-1] + + # set productIsFinal + isfinal = lines[3].strip().lower() + key, sep, isfinal = isfinal.partition("=") + productIsFinal = (key == "final" and isfinal == "yes") + + if len(lines) >= 5: + bugUrl = lines[4][:-1] if os.environ.has_key("ANACONDA_PRODUCTNAME"): productName = os.environ["ANACONDA_PRODUCTNAME"] diff --git a/scripts/buildinstall b/scripts/buildinstall index efacfb5..ae28ccb 100755 --- a/scripts/buildinstall +++ b/scripts/buildinstall @@ -28,7 +28,7 @@ die() { } usage() { - echo "Usage: buildinstall --version <version> --brand <brand> --product <product> --release <comment> [--output outputdir] [--discs <discstring>] <root>" >&2 + echo "Usage: buildinstall --version <version> --brand <brand> --product <product> --release <comment> --final [--output outputdir] [--discs <discstring>] <root>" >&2 exit 1 } @@ -60,6 +60,10 @@ while [ $# -gt 0 ]; do RELEASESTR=$2 shift; shift ;; + --final) + ISFINAL="--final" + shift + ;; --product) PRODUCTSTR=$2 shift; shift @@ -244,11 +248,11 @@ $MK_TREEINFO --family="$PRODUCTSTR" ${VARIANT:+--variant="$VARIANT"} --version=$ # FIXME: need to update mk-images to take the yumconf echo "Making images: $PWD" -echo $MK_IMAGES $DEBUGSTR $NOGRSTR --imgdir $TREEDIR/install --arch $BASEARCH --product "$PRODUCTSTR" --version $VERSION --bugurl "$BUGURL" --output $OUTPUT $yumconf +echo $MK_IMAGES $DEBUGSTR $NOGRSTR --imgdir $TREEDIR/install --arch $BASEARCH --product "$PRODUCTSTR" --version $VERSION $ISFINAL --bugurl "$BUGURL" --output $OUTPUT $yumconf if [ -z "$DEBUGSTR" ]; then - $MK_IMAGES $DEBUGSTR $NOGRSTR --imgdir $TREEDIR/install --arch $BASEARCH --product "$PRODUCTSTR" --version $VERSION --bugurl "$BUGURL" --output $OUTPUT $yumconf || die "image creation failed" + $MK_IMAGES $DEBUGSTR $NOGRSTR --imgdir $TREEDIR/install --arch $BASEARCH --product "$PRODUCTSTR" --version $VERSION $ISFINAL --bugurl "$BUGURL" --output $OUTPUT $yumconf || die "image creation failed" else - /bin/sh -x $MK_IMAGES $DEBUGSTR $NOGRSTR --imgdir $TREEDIR/install --arch $BASEARCH --product "$PRODUCTSTR" --version $VERSION --bugurl "$BUGURL" --output $OUTPUT $yumconf || die "image creation failed" + /bin/sh -x $MK_IMAGES $DEBUGSTR $NOGRSTR --imgdir $TREEDIR/install --arch $BASEARCH --product "$PRODUCTSTR" --version $VERSION $ISFINAL --bugurl "$BUGURL" --output $OUTPUT $yumconf || die "image creation failed" fi echo "Writing .discinfo file" diff --git a/scripts/mk-images b/scripts/mk-images index 1f69959..a9f74a0 100755 --- a/scripts/mk-images +++ b/scripts/mk-images @@ -25,7 +25,7 @@ IMAGEUUID=$(date +%Y%m%d%H%M).$(uname -i) TMPDIR=${TMPDIR:-/tmp} usage () { - echo "usage: mk-images <pkgsrc> <toplevel> <template> <imgdir> <buildarch> <productname> <version> [<productpath>]" + echo "usage: mk-images <pkgsrc> <toplevel> <template> <imgdir> <buildarch> <productname> <version> <final> [<productpath>]" exit 0 } @@ -59,6 +59,10 @@ while [ $# -gt 0 ]; do VERSION=$2 shift; shift ;; + --final) + ISFINAL="yes" + shift + ;; --bugurl) BUGURL=$2 shift; shift @@ -368,6 +372,11 @@ makeproductfile() { echo $IMAGEUUID > $root/.buildstamp echo $PRODUCT >> $root/.buildstamp echo $VERSION >> $root/.buildstamp + if [ -n "$ISFINAL" ]; then + echo "FINAL=YES" >> $root/.buildstamp + else + echo "FINAL=NO" >> $root/.buildstamp + fi if [ -n "$BUGURL" ]; then echo $BUGURL >> $root/.buildstamp fi -- 1.7.5.4

1 1

[rhel6-branch] Make the rhgb and quit kernel arguments appear last (#742169)
by Martin Gracik 17 Jan '12

17 Jan '12

--- booty/bootloaderInfo.py | 13 +++++++++++-- 1 files changed, 11 insertions(+), 2 deletions(-) diff --git a/booty/bootloaderInfo.py b/booty/bootloaderInfo.py index b68e93d..9011886 100644 --- a/booty/bootloaderInfo.py +++ b/booty/bootloaderInfo.py @@ -113,6 +113,15 @@ class KernelArguments: return rest + def _sort_args(self, args): + ordering_dict = {"rhgb": 99, "quiet": 100} + + # sort the elements according to their values in ordering_dict. The + # higher the number the closer to the final string the argument + # gets. The default is 50. + lst = sorted(args, key=lambda s: ordering_dict.get(s, 50)) + return " ".join(lst) + def getDracutStorageArgs(self, devices): args = set() types = {} @@ -164,7 +173,7 @@ class KernelArguments: all_args = self._merge_ip(all_args) - return " ".join(all_args) + return self._sort_args(all_args) def set(self, args): self.args = args @@ -172,7 +181,7 @@ class KernelArguments: def getNoDracut(self): args = " ".join(self.args) + " " + " ".join(self.appendArgs) - return args + return self._sort_args(args.split()) def chandevget(self): return self.cargs -- 1.7.5.4

2 1

[newui] Patches for storage spoke
by David Lehman 17 Jan '12

17 Jan '12

Enable use of storage spoke as non-root users, fix some bugs, and clean some things up in the storage spoke code.

3 9

installation on a second drive
by GATINEAU, ANTOINE (ANTOINE) 17 Jan '12

17 Jan '12

Hello, I am trying to make anaconda install a second RHEL 5 on another drive/partition from a running system. I have been trying and searching the internet for some time now but with no success. I know people managed to do it but not how. I can build the chrooted environment with stage2.img and initrd.img, launch anaconda and configure the installation details. Then I have errors locating repomd.xml or loading the cdrom 2... I guess it is due to the dev management that prevents to access the source path. First question : is it possible using different media source (DVD, NFS , ISO)? Is there some special device management to understand here? Is there a document I missed that would give me those answers? Regards Antoine Gatineau

1 1

[PATCH] only StandaloneSpokes have the register_event_cb method
by Vratislav Podzimek 16 Jan '12

16 Jan '12

--- pyanaconda/ui/gui/tools/run-spoke.py | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/pyanaconda/ui/gui/tools/run-spoke.py b/pyanaconda/ui/gui/tools/run-spoke.py index 5247163..d635957 100755 --- a/pyanaconda/ui/gui/tools/run-spoke.py +++ b/pyanaconda/ui/gui/tools/run-spoke.py @@ -39,8 +39,9 @@ if not spokeClass: sys.exit(1) spoke = spokeClass(ksdata, devicetree, instclass) -spoke.register_event_cb("continue", lambda: Gtk.main_quit()) -spoke.register_event_cb("quit", lambda: Gtk.main_quit()) +if hasattr(spoke, "register_event_cb"): + spoke.register_event_cb("continue", lambda: Gtk.main_quit()) + spoke.register_event_cb("quit", lambda: Gtk.main_quit()) spoke.populate() if not spoke.showable: -- 1.7.4.4

2 1

[PATCH][newui] Make text on disks summary button underlined and blue.
by David Lehman 14 Jan '12

14 Jan '12

--- pyanaconda/ui/gui/spokes/storage.py | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/pyanaconda/ui/gui/spokes/storage.py b/pyanaconda/ui/gui/spokes/storage.py index a531d96..18c9ba1 100644 --- a/pyanaconda/ui/gui/spokes/storage.py +++ b/pyanaconda/ui/gui/spokes/storage.py @@ -371,6 +371,9 @@ class StorageSpoke(NormalSpoke): def populate(self): NormalSpoke.populate(self) + summary_label = self.builder.get_object("summary_button").get_children()[0] + summary_label.set_use_markup(True) + local_disks_box = self.builder.get_object("local_disks_box") #specialized_disks_box = self.builder.get_object("specialized_disks_box") @@ -430,7 +433,9 @@ class StorageSpoke(NormalSpoke): summary = (P_(("%d disk selected; %s capacity; %s free ..."), ("%d disks selected; %s capacity; %s free ..."), count) % (count, size_str(capacity), size_str(free))) - self.builder.get_object("summary_button").set_label(summary) + markup = "<span foreground='blue'><u>%s</u></span>" % summary + summary_label = self.builder.get_object("summary_button").get_children()[0] + summary_label.set_markup(markup) if count == 0: self.window.set_info(Gtk.MessageType.WARNING, _("No disks selected; please select at least one disk to install to.")) -- 1.7.6

2 1

[newui] Some basic functionality for the Keyboard Spoke
by Vratislav Podzimek 14 Jan '12

14 Jan '12

This set of patches adds a basic functionality to the buttons, entries etc. of the Keyboard Spoke. Since Chris in the meantime renamed the files, these patches cannot be pushed and need to be rebased first. Unfortunately I have some problems with it when trying via ssh from home, so I'm sending these patches just for the purpose of FUDcon preview. I will get back to them on Monday and will rebase them. -- Vratislav Podzimek

2 5

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Anaconda-devel January 2012