[PATCH] FC4 cannot load driver disk image on a disk partition

[Akinobu Mita]

Hello,

I tried to load driver disk image on a partition in USB storage device.
(/dev/sda1:dd.img) But It failed.

Steps to Reproduce:
1. create driver disk image (dd.img)
2. put dd.img on USB storage device partition (/dev/sda1)
3. start FC4 installer with "linux dd"
4. select driver disk source as /dev/sda1 and choose the file "dd.img"

Actual results:

anaconda went wrong stage.
  anaconda displays:

---| Insert Driver Disk |---
  Insert your driver disk into /dev/sda and press "OK" to continue.

Expected results:

Successfully load from driver disk image.

I think below patch fixes this problem. but it is untested.

--- anaconda-10.3.0.7/loader2/driverdisk.c.orig 2005-07-27 18:25:13.000000000 +0900
+++ anaconda-10.3.0.7/loader2/driverdisk.c      2005-07-27 18:25:56.000000000 +0900
@@ -380,6 +380,7 @@ int loadDriverFromMedia(int class, modul
                 break;
             }
             stage = DEV_LOAD;
+            break;
         }

case DEV_INSERT: {

[Dan Carpenter]

(On the topic of driver disks).

I've not found really good documentation on driver disks.  To create 
dd.img do you just create a normall driver disk and `cat /dev/fd0 > 
dd.img`?

I've been using FC3.  From the source in driverdisk.c it looks like it 
loop back mounts the image and when I try that it seems to find the files, 
but my installer segfaults.

The driver disk works when you use a floppy.

thanks,
dan

On Thu, 28 Jul 2005, Akinobu Mita wrote:
> Hello,
>
> I tried to load driver disk image on a partition in USB storage device.
> (/dev/sda1:dd.img) But It failed.
>
> Steps to Reproduce:
> create driver disk image (dd.img)
> put dd.img on USB storage device partition (/dev/sda1)
> start FC4 installer with "linux dd"
> select driver disk source as /dev/sda1 and choose the file "dd.img"
>
> Actual results:
>
> anaconda went wrong stage.
>   anaconda displays:
>
> ---| Insert Driver Disk |---
>   Insert your driver disk into /dev/sda and press "OK" to continue.
>
> Expected results:
>
> Successfully load from driver disk image.
>
> I think below patch fixes this problem. but it is untested.
>
> --- anaconda-10.3.0.7/loader2/driverdisk.c.orig 2005-07-27 18:25:13.000000000 +0900
> +++ anaconda-10.3.0.7/loader2/driverdisk.c      2005-07-27 18:25:56.000000000 +0900
> @@ -380,6 +380,7 @@ int loadDriverFromMedia(int class, modul
>                  break;
>              }
>              stage = DEV_LOAD;
>        break;
>    }
>
>    case DEV_INSERT: {
>
> Anaconda-devel-list mailing list
> [e-mail]
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Akinobu Mita]

On Friday 29 July 2005 01:45, Dan Carpenter wrote:
> (On the topic of driver disks).
>
> I've not found really good documentation on driver disks.  To create 
> dd.img do you just create a normall driver disk and `cat /dev/fd0 > 
> dd.img`?

Loading driver disk image on a disk partition is not documented.
But anaconda seems to have the code to do that.
This is why I tried that.
> I've been using FC3.  From the source in driverdisk.c it looks like it 
> loop back mounts the image and when I try that it seems to find the files, 
> but my installer segfaults.

Anyway, If we want to load driver disk, we can create driver disk
(not driver disk *image* on a disk partition) as you mentioned.
And we can load driver disk image over NFS, FTP, and HTTP.
So the problem I reported is minor thing.

dd=http://path/to/dd.img
dd=ftp://path/to/dd.img
dd=nfs:host:/dd.img
> The driver disk works when you use a floppy.
>
> thanks,
> dan
>
> On Thu, 28 Jul 2005, Akinobu Mita wrote:
> > Hello,
> >
> > I tried to load driver disk image on a partition in USB storage device.
> > (/dev/sda1:dd.img) But It failed.
> >
> > Steps to Reproduce:
> > create driver disk image (dd.img)
> > put dd.img on USB storage device partition (/dev/sda1)
> > start FC4 installer with "linux dd"
> > select driver disk source as /dev/sda1 and choose the file "dd.img"
> >
> > Actual results:
> >
> > anaconda went wrong stage.
> >   anaconda displays:
> >
> > ---| Insert Driver Disk |---
> >   Insert your driver disk into /dev/sda and press "OK" to continue.
> >
> > Expected results:
> >
> > Successfully load from driver disk image.
> >
> > I think below patch fixes this problem. but it is untested.
> >
> > --- anaconda-10.3.0.7/loader2/driverdisk.c.orig 2005-07-27 18:25:13.000000000 +0900
> > +++ anaconda-10.3.0.7/loader2/driverdisk.c      2005-07-27 18:25:56.000000000 +0900
> > @@ -380,6 +380,7 @@ int loadDriverFromMedia(int class, modul
> >                  break;
> >              }
> >              stage = DEV_LOAD;
> >        break;
> >    }
> >
> >    case DEV_INSERT: {
> >
> > Anaconda-devel-list mailing list
> > [e-mail]
> > https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Jeremy Katz]

On Thu, 2005-07-28 at 14:14 +0900, Akinobu Mita wrote:
> I tried to load driver disk image on a partition in USB storage device.
> (/dev/sda1:dd.img) But It failed.

[snip]
> I think below patch fixes this problem. but it is untested.

Looks good to me.  Applied to CVS.

Jeremy

[PATCH] load driver disk from initrd

[Dan Carpenter]

Anaconda actually has code for using driver disk images from the initrd 
but it doesn't work because of a bug.  The attached patch fixes that.  
There were some variables that weren't getting initialized early enough.

Take a normal driver disk floppy:
zcat ../initrd.img | cpio -idmv
dd if=/dev/fd0 of=dd.img
find | cpio -oc | gzip -9 > ../initrd.img

You can use this to for loading over the network etc.

regards,
dan carpenter

[PATCH] load driver disk from initrd

[Jeremy Katz]

On Tue, 2005-11-22 at 10:54 -0800, Dan Carpenter wrote:
> Anaconda actually has code for using driver disk images from the initrd 
> but it doesn't work because of a bug.  The attached patch fixes that.  
> There were some variables that weren't getting initialized early enough.

Thanks, applied to CVS

Jeremy