[PATCH] pykickstart, pungi: Allow ignoring of group metadata from repos

[Bill Nottingham]

Right now, pungi automatically uses the comps.xml from any configured
repository. If you want to do severe modifications to the default groups,
you have to mirror all the packages yourself first, otherwise the group
metadata from the base repo you're pulling from will end up overriding your
changes.

The attached patches:
- pykickstart: add a new boolean option for ignoring group metadata in a 'repo' line
- pungi: add code that sets the proper yum flag to ignore the group data
  if it's set for that repo

Tested a s/F11/F10/ version of the patch on F10 w/F10 pungi.

Comments? How much unnecessary cargo-culting did I add to pykickstart?

Bill

[Jesse Keating]

On Mon, 2008-12-22 at 15:20 -0500, Bill Nottingham wrote:
> pungi: add code that sets the proper yum flag to ignore the group data
> if it's set for that repo

This looks fine to me, and I think it's been asked for before, so I'll
add it, if the pykickstart part gets added as well.

[Jerry Vonau]

On Mon, 2008-12-22 at 12:28 -0800, Jesse Keating wrote:
> On Mon, 2008-12-22 at 15:20 -0500, Bill Nottingham wrote:
> > pungi: add code that sets the proper yum flag to ignore the group data
> > if it's set for that repo
>
> This looks fine to me, and I think it's been asked for before, so I'll
> add it, if the pykickstart part gets added as well.

Thank You,

Jerry

[Chris Lumens]

> @@ -146,3 +161,27 @@ class F8_Repo(FC6_Repo):
>          rd = self.handler.RepoData(name=reponame, baseurl=repourl)
>          self.add(rd)
>
> +class F11_Repo(F8_Repo):
> removedKeywords = F8_Repo.removedKeywords
> removedAttrs = F8_Repo.removedAttrs
> def __str__(self):
>    retval = ""
>    for repo in self.repoList:
>        retval += repo.__str__()
>    return retval
> def _getParser(self):
>    op = F8_Repo._getParser(self)
>    op.add_option("--ignoregroups", action="store", type="ksboolean")
>    return op
> def methodToRepo(self):
>    if not self.handler.method.url:
>        raise KickstartError, formatErrorMsg(self.handler.method.lineno, msg=_("Method must be a url to be added to the repo list."))
>    reponame = "ks-method-url"
>    repourl = self.handler.method.url
>    rd = self.handler.RepoData(name=reponame, baseurl=repourl)
>    self.add(rd)

You shouldn't need __str__ or methodToRepo in F11_Repo, since they
should all be inherited.  I should probably remove __str__ from F8_Repo
as well since it's in FC6_Repo.  Other than that, looks fine.  If you've
got commit access to pykickstart, go ahead and commit.  You can also try
running make check in the pykickstart tree after committing but before
pushing, just to make sure.

- Chris

[Bill Nottingham]

Chris Lumens ([e-mail]) said:
> You shouldn't need __str__ or methodToRepo in F11_Repo, since they
> should all be inherited.  I should probably remove __str__ from F8_Repo
> as well since it's in FC6_Repo.  Other than that, looks fine.

Removed.
> If you've
> got commit access to pykickstart, go ahead and commit.  You can also try
> running make check in the pykickstart tree after committing but before
> pushing, just to make sure.

Passed check, pushed.

Thanks for the review,
Bill