[PATCH] Let's not exit from buildinstall.functions, say, ever

[Jeremy Katz]

Background: looking into why we don't have a gtk theme on x86_64 (#513879) and 
everything looks okay... /tmp/keepfile* is correct, etc.  And it works on i386.
In addition to no theme stuff, though, there's also not /sbin/grub.  So maybe
/sbin/grub has some non-static 32bit linkage now and that's tripping up our
shlib stuff.  I haven't tested (my box seems to have killed itself overnight)
but this shouldn't break anything at least and might possibly fix things

Exiting from a function being called could leave things in a
weird state.  The exit makes sense for mkinitrd, maybe less
so when building installer images
---
 scripts/buildinstall.functions |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/scripts/buildinstall.functions b/scripts/buildinstall.functions
index 3b10dff..2afb652 100755
--- a/scripts/buildinstall.functions
+++ b/scripts/buildinstall.functions
@@ -56,11 +56,8 @@ EOF
     while [ $n -lt ${#FILES[*]} ]; do
         FILE="${FILES[$n]}"
         if [ "$FILE" == "not found" ]; then
-            cat 1>&2 <<EOF
-There are missing files on your system.  The dynamic object $bin
-requires ${NAMES[$n]} n order to properly function.  mkinitrd cannot continue.
-EOF
-            exit 1
+            echo "WARNING: The dynamic object $bin requires ${NAMES[$n]} n order to properly function."
+            continue
         fi
        case "$FILE" in
          /lib*)

[Chris Lumens]

> diff --git a/scripts/buildinstall.functions b/scripts/buildinstall.functions
> index 3b10dff..2afb652 100755
> --- a/scripts/buildinstall.functions
> +++ b/scripts/buildinstall.functions
> @@ -56,11 +56,8 @@ EOF
>      while [ $n -lt ${#FILES[*]} ]; do
>          FILE="${FILES[$n]}"
>          if [ "$FILE" == "not found" ]; then
>        cat 1>&2 <<EOF
>
> -There are missing files on your system.  The dynamic object $bin
> -requires ${NAMES[$n]} n order to properly function.  mkinitrd cannot continue.
> -EOF
>        exit 1
>        echo "WARNING: The dynamic object $bin requires ${NAMES[$n]} n order to properly function."
>        continue
>    fi
>   case "$FILE" in
>     /lib*)

This is as good a guess as anything else we've come up with.  Let's see
what happens.

- Chris