anaconda-patches July 2012

anaconda-patches@lists.fedorahosted.org

16 participants
68 discussions

[PATCH] mtu is a string from kickstart, not number (#832332)
by Jesse Keating 18 Jul '12

18 Jul '12

--- dracut/parse-kickstart | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dracut/parse-kickstart b/dracut/parse-kickstart index aa4e0e8..3b6b861 100755 --- a/dracut/parse-kickstart +++ b/dracut/parse-kickstart @@ -195,9 +195,9 @@ def ksnet_to_dracut(args, lineno, net, bootdev=False): if net.mtu: # XXX FIXME: dracut doesn't support mtu= (yet) if net.device: - line.append("mtu=%s:%u" % (net.device, net.mtu)) + line.append("mtu=%s:%s" % (net.device, net.mtu)) else: - line.append("mtu=%u" % net.mtu) + line.append("mtu=%s" % net.mtu) # TODO: nodefroute, noipv[46], nodns: pass along to 'ifcfg' module somehow # TODO FIXME dhcpclass: dracut only uses one dhclient.conf for all ifaces -- 1.7.10.4

2 1

[PATCH rhel5-branch] Fix NFS mounting (#841136)
by Jesse Keating 18 Jul '12

18 Jul '12

Newer nfs-utils and mount.nfs use tcp by default. If we don't in our own mounting code we will not be able to mount the share. This change just duplicates the same change made in busybox to make mounting function again. --- isys/nfsmount.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/isys/nfsmount.c b/isys/nfsmount.c index 21ad20d..ba63e92 100644 --- a/isys/nfsmount.c +++ b/isys/nfsmount.c @@ -355,7 +355,7 @@ int nfsmount(const char *spec, const char *node, int *flags, nolock = 0; noac = 0; retry = 10000; /* 10000 minutes ~ 1 week */ - tcp = 0; + tcp = 1; /* nfs-utils uses tcp per default */ mountprog = MOUNTPROG; mountvers = 0; -- 1.7.10.4

2 1

[newui] Create partitions in the custom ui
by David Lehman 17 Jul '12

17 Jul '12

This adds the ability to create new partitions for swap or mountable filesystem of the default type (currently ext4). Size input is passed directly to Size ctor via spec=, so to get 20GB you enter something like '20GB' or '20 gb'. Entering a size of 0 or no size spec at all will get you the default partition size, which is 500MB. Very basic validation is done on mountpoints as well, but there is no feedback -- we just don't create anything if there's a problem.

2 5

[newui] Get back to python-meh UI in exception handling
by Vratislav Podzimek 17 Jul '12

17 Jul '12

PATCH 1/3 replaces the temporary code for saving the traceback with python-meh's ui invocation. It also adds sys.exit(0) call to the end of the showError method which conforms to the documentation in the pyanaconda/ui/__init__.py (see e6f4db9d93a95ad932bf733c585b336db34c1d56 for the original code) PATCH 2/3 removes the os.kill call that killed anaconda when the pdb session was quit which left no way to report a bug with the python-meh/libreport ui. Moreover it adds an attempt to switch back to tty6 when the pdb session is quit. I believe we have finally settled on the python-meh's main window look and I can build a new version tomorrow. The related libreport patch is going to be pushed soon and a new build of libreport will follow in the end of this week. Once these steps are done, I'd like to push these patches to start using python-meh gui in the newui images. Vratislav Podzimek (3): Get back to python-meh UI in exception handling Just switch back to tty6 when 'c' is used in the post-mortem pdb session Display the hint how to quit the debugger pyanaconda/exception.py | 26 +++++++++++++++----------- pyanaconda/ui/gui/__init__.py | 2 ++ 2 files changed, 17 insertions(+), 11 deletions(-) -- 1.7.4.4

2 4

[PATCH] ARM: clean up the kernel selection to be consistent with the rest of the code
by Dennis Gilmore 16 Jul '12

16 Jul '12

--- pyanaconda/yuminstall.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyanaconda/yuminstall.py b/pyanaconda/yuminstall.py index 63d077d..9ac780b 100644 --- a/pyanaconda/yuminstall.py +++ b/pyanaconda/yuminstall.py @@ -1467,7 +1467,7 @@ reposdir=/etc/anaconda.repos.d,/tmp/updates/anaconda.repos.d,/tmp/product/anacon if not foundkernel and iutil.isARM(): if anaconda.platform.armMachine is not None: - selectKernel("kernel-" + anaconda.platform.armMachine) + selectKernel("kernel-%s" % anaconda.platform.armMachine) foundkernel = True if not foundkernel: -- 1.7.10.4

1 0

[rhel5-branch] New version of the gfs support patch and one more
by Vratislav Podzimek 16 Jul '12

16 Jul '12

First! PATCH 1/2 is the same as the previous attempt for the gfs support. However, the previous version had self.check set to 1 that caused problems on reboot because fsck.gfs failed. I believe 0 is the right value here. PATCH 2/2 adds the unknownFileSystem class that allows us to just comment out the fstab lines with unknown (not supported) filesystem on upgrade. We could just copy such lines, but that may result in non-booting system, because of for example fsck problems (fsck for such filesystem may be not installed or whatever). Ending up in a shell during boot process is a lot worse then fixing the configuration from the running system with all utilities available. -- Vratislav Podzimek

4 14

[newui 1/2] make the proxy url entry wider
by Brian C. Lane 13 Jul '12

13 Jul '12

From: "Brian C. Lane" <bcl(a)redhat.com> --- pyanaconda/ui/gui/spokes/source.ui | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/pyanaconda/ui/gui/spokes/source.ui b/pyanaconda/ui/gui/spokes/source.ui index 509273c..7b92657 100644 --- a/pyanaconda/ui/gui/spokes/source.ui +++ b/pyanaconda/ui/gui/spokes/source.ui @@ -715,6 +715,7 @@ TeXlive 2012 repository</col> <property name="visible">True</property> <property name="can_focus">True</property> <property name="invisible_char">●</property> + <property name="width_chars">40</property> </object> <packing> <property name="left_attach">1</property> -- 1.7.7.6

2 2

[PATCH rhel7] iscsi: fall back to session initiator name for null offload name (#836307)
by Radek Vykydal 12 Jul '12

12 Jul '12

Resolves: rhbz#836307 Tested by reporter to fix the issue. --- pyanaconda/storage/udev.py | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/pyanaconda/storage/udev.py b/pyanaconda/storage/udev.py index 9b1e8da..855ee70 100644 --- a/pyanaconda/storage/udev.py +++ b/pyanaconda/storage/udev.py @@ -585,11 +585,16 @@ def udev_device_get_iscsi_initiator(info): initiator_file = "/sys/class/iscsi_host/%s/initiatorname" % host if os.access(initiator_file, os.R_OK): initiator = open(initiator_file).read().strip() + log.debug("found offload iscsi initiatorname %s in file %s" % + (initiator, initiator_file)) + if initiator.lstrip("(").rstrip(")").lower() == "null": + initiator = None if initiator is None: session = udev_device_get_iscsi_session(info) if session: initiator = open("/sys/class/iscsi_session/%s/initiatorname" % session).read().strip() + log.debug("found iscsi initiatorname %s" % initiator) return initiator -- 1.7.4

4 4

[master/newui] Create default ifcfg files in dracut
by Radek Vykydal 12 Jul '12

12 Jul '12

See commit messages for rationale. (follow-up of https://www.redhat.com/archives/anaconda-devel-list/2012-June/msg00438.html)

2 6

[python-meh] Port to Gtk3 and the new design and some minor changes
by Vratislav Podzimek 12 Jul '12

12 Jul '12

PATCH 3/6 is the key one. It ports python-meh to Gtk3 and changes its look to match the newui design (links to video preview and mockups can be found on the devel list). The major advantage of the PATCH 6/6 is that with it there is no need for the "temporary glue" (see the libreport patch) in libreport. I believe there is no need to have the text only in the file that is read again and again at multiple places. See commit messages for some more details. -- Vratislav Podzimek

3 11

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

anaconda-patches July 2012