anaconda-patches August 2012

anaconda-patches@lists.fedorahosted.org

16 participants
132 discussions

A few patches for parse-kickstart's ksnet_to_dracut()
by Will Woods 07 Sep '12

07 Sep '12

This is roughly the same as my previous patch for supporting kickstart 'network --mtu-...', but broken into a series of smaller patches so you can actually see what's going on. Patch 1-4 are all just cleanups, patch 5 adds --mtu. dracut/parse-kickstart | 44 +++++++++++++++++++++++--------------------- 1 file changed, 23 insertions(+), 21 deletions(-) -w

2 6

Support for enabling multilib
by David Lehman 05 Sep '12

05 Sep '12

--multilib option to ks %packages and also as an anaconda arg Once pykickstart is built I'll also patch anaconda.spec.in to require the appropriate pykickstart version.

3 4

[master] Language-related stuff cleanup
by Vratislav Podzimek 04 Sep '12

04 Sep '12

These two patches remove no longer used/needed files and add few lines for writing language system configuration to the installed system. This part needs one more patch for writing /etc/locale.conf, but I don't know how this file should look. Please not that these patches are not tested as I am sending them from the BaseOS team building without virtualization available. I will test them before pusing tomorrow. Vratislav Podzimek (2): Remove lang-table and localeinfo.py Remove anaconda.instLanguage object and language module anaconda | 3 - data/lang-table | 61 --------- pyanaconda/__init__.py | 10 -- pyanaconda/install.py | 1 + pyanaconda/installclass.py | 1 - pyanaconda/kickstart.py | 6 + pyanaconda/language.py | 216 ------------------------------ pyanaconda/localeinfo.py | 56 -------- pyanaconda/localization.py | 25 ++++ tests/pyanaconda_test/language_test.py | 237 --------------------------------- 10 files changed, 32 insertions(+), 584 deletions(-) delete mode 100644 data/lang-table delete mode 100644 pyanaconda/language.py delete mode 100644 pyanaconda/localeinfo.py delete mode 100644 tests/pyanaconda_test/language_test.py -- 1.7.11.4

2 5

[PATCH] Handle invalid spoke input (#853253)
by Jesse Keating 31 Aug '12

31 Aug '12

--- pyanaconda/ui/tui/spokes/storage.py | 4 ++-- pyanaconda/ui/tui/spokes/time.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pyanaconda/ui/tui/spokes/storage.py b/pyanaconda/ui/tui/spokes/storage.py index 40a167a..d1b85c3 100644 --- a/pyanaconda/ui/tui/spokes/storage.py +++ b/pyanaconda/ui/tui/spokes/storage.py @@ -207,7 +207,7 @@ class StorageSpoke(NormalTUISpoke): self._update_disk_list(self.disks[number -1]) return None - except (ValueError, KeyError): + except (ValueError, KeyError, IndexError): return key def apply(self): @@ -345,5 +345,5 @@ class AutoPartSpoke(NormalTUISpoke): self.close() return False - except (ValueError, KeyError): + except (ValueError, KeyError, IndexError): return key diff --git a/pyanaconda/ui/tui/spokes/time.py b/pyanaconda/ui/tui/spokes/time.py index bac1d0f..2cea1b8 100644 --- a/pyanaconda/ui/tui/spokes/time.py +++ b/pyanaconda/ui/tui/spokes/time.py @@ -99,7 +99,7 @@ class TimeZoneSpoke(NormalTUISpoke): else: self.app.switch_screen(self, self._regions[keyid]) return True - except ValueError: + except (ValueError, IndexError): pass if key.lower() in self._lower_zones: -- 1.7.11.2

2 1

[PATCH] Remove unnecessary (and broken) import (#853576)
by Jesse Keating 31 Aug '12

31 Aug '12

--- pyanaconda/text.py | 1 - 1 file changed, 1 deletion(-) diff --git a/pyanaconda/text.py b/pyanaconda/text.py index c924ae3..f3c9c77 100644 --- a/pyanaconda/text.py +++ b/pyanaconda/text.py @@ -32,7 +32,6 @@ import signal import parted import product import string -from localeinfo import expandLangs from flags import flags from textw.constants_text import * from constants import * -- 1.7.11.2

2 1

[PATCH] Disable the maximize/unmaximize key bindings (#853410).
by Chris Lumens 31 Aug '12

31 Aug '12

--- lorax.spec | 1 + .../common/org.gnome.desktop.wm.keybindings.gschema.override | 4 ++++ share/runtime-postinstall.tmpl | 4 ++++ 3 files changed, 9 insertions(+) create mode 100644 share/config_files/common/org.gnome.desktop.wm.keybindings.gschema.override diff --git a/lorax.spec b/lorax.spec index 6a74e0f..ed473a2 100644 --- a/lorax.spec +++ b/lorax.spec @@ -20,6 +20,7 @@ Requires: e2fsprogs Requires: findutils Requires: gawk Requires: genisoimage +Requires: glib2 Requires: glibc Requires: glibc-common Requires: gzip diff --git a/share/config_files/common/org.gnome.desktop.wm.keybindings.gschema.override b/share/config_files/common/org.gnome.desktop.wm.keybindings.gschema.override new file mode 100644 index 0000000..3b08904 --- /dev/null +++ b/share/config_files/common/org.gnome.desktop.wm.keybindings.gschema.override @@ -0,0 +1,4 @@ +[org.gnome.desktop.wm.keybindings] + maximize=[] + unmaximize=[] + toggle-maximized=[] diff --git a/share/runtime-postinstall.tmpl b/share/runtime-postinstall.tmpl index 95be02b..114e00b 100644 --- a/share/runtime-postinstall.tmpl +++ b/share/runtime-postinstall.tmpl @@ -86,6 +86,10 @@ gconfset /apps/metacity/global_keybindings/switch_windows string disabled gconfset /desktop/gnome/interface/accessibility bool true gconfset /desktop/gnome/interface/at-spi-corba bool true +## Some settings are controlled by gsettings now. +install ${configdir}/org.gnome.desktop.wm.keybindings.gschema.override usr/share/glib-2.0/schemas +runcmd chroot ${root} glib-compile-schemas /usr/share/glib-2.0/schemas + move usr/libexec/anaconda/auditd sbin ## for compatibility with Ancient Anaconda Traditions -- 1.7.10.2

2 1

[pykickstart] Add --multilib option to %packages
by David Lehman 31 Aug '12

31 Aug '12

This changes yum's multilib_policy from the default of "best" to "all".

1 1

[PATCH] Destroy the Add Mountpoint dialog when escape is pressed (#853058).
by Chris Lumens 31 Aug '12

31 Aug '12

--- pyanaconda/ui/gui/spokes/custom.glade | 1 - pyanaconda/ui/gui/spokes/custom.py | 4 +--- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/pyanaconda/ui/gui/spokes/custom.glade b/pyanaconda/ui/gui/spokes/custom.glade index a2e2b64..1a0bf8d 100644 --- a/pyanaconda/ui/gui/spokes/custom.glade +++ b/pyanaconda/ui/gui/spokes/custom.glade @@ -36,7 +36,6 @@ <property name="halign">end</property> <property name="use_action_appearance">False</property> <property name="use_underline">True</property> - <signal name="clicked" handler="on_add_cancel_clicked" swapped="no"/> </object> <packing> <property name="expand">False</property> diff --git a/pyanaconda/ui/gui/spokes/custom.py b/pyanaconda/ui/gui/spokes/custom.py index f0e8d58..5de6c35 100644 --- a/pyanaconda/ui/gui/spokes/custom.py +++ b/pyanaconda/ui/gui/spokes/custom.py @@ -132,9 +132,6 @@ class AddDialog(GUIObject): completion.set_text_column(0) completion.set_popup_completion(True) - def on_add_cancel_clicked(self, button, *args): - self.window.destroy() - def on_add_confirm_clicked(self, button, *args): self.mountpoint = self.builder.get_object("addMountPointEntry").get_text() @@ -948,6 +945,7 @@ class CustomPartitioningSpoke(NormalSpoke, StorageChecker): if rc != 1: # user cancel + dialog.window.destroy() return # create a device of the default type, using any disks, with an -- 1.7.11.2

2 1

[PATCH 1/3] Update runpylint to find newui modules correctly.
by Chris Lumens 31 Aug '12

31 Aug '12

--- tests/pylint/runpylint.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/pylint/runpylint.sh b/tests/pylint/runpylint.sh index 8c3e74b..9b771cd 100755 --- a/tests/pylint/runpylint.sh +++ b/tests/pylint/runpylint.sh @@ -80,7 +80,7 @@ fi # run pylint one file / module at a time, otherwise it sometimes gets # confused > pylint-log -for i in pyanaconda/storage pyanaconda/installclasses/*.py pyanaconda/iw/*.py pyanaconda/textw/*.py pyanaconda/isys/*.py pyanaconda/; do +for i in $(find pyanaconda -type f -name '*py'); do pylint --init-hook='import sys; \ sys.path.insert(1, "pyanaconda/isys/.libs"); \ sys.path.insert(2, "pyanaconda/isys"); \ -- 1.7.11.2

2 3

[PATCH] Keep the current spoke on top of the hub.
by Chris Lumens 31 Aug '12

31 Aug '12

This means you can't alt-tab away from the spoke and do stuff on the hub and really confuse anaconda. --- pyanaconda/ui/gui/TODO | 2 -- pyanaconda/ui/gui/hubs/__init__.py | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pyanaconda/ui/gui/TODO b/pyanaconda/ui/gui/TODO index 6f8dcf9..cb86ca4 100644 --- a/pyanaconda/ui/gui/TODO +++ b/pyanaconda/ui/gui/TODO @@ -13,8 +13,6 @@ Fedora 18 where you go next. - Something causes the up and down arrows to resize the anaconda window. - Wall of anaconda needs to be taken into account. -- When you display a spoke, the hub needs to be hidden so you can't alt-tab. This is especially - bad on liveinst. - Why does the first hub jump left a little bit the first time you use the keyboard to navigate? - In custom storage, it'd be nice to be able to say something like "Use this previous installation as the starting storage configuration for the system diff --git a/pyanaconda/ui/gui/hubs/__init__.py b/pyanaconda/ui/gui/hubs/__init__.py index f5e211f..4d8c6e3 100644 --- a/pyanaconda/ui/gui/hubs/__init__.py +++ b/pyanaconda/ui/gui/hubs/__init__.py @@ -94,6 +94,7 @@ class Hub(GUIObject, common.Hub): action.window.set_beta(self.window.get_beta()) action.window.set_property("distribution", self.window.get_property("distribution")) + action.window.set_transient_for(self.window) action.window.show_all() # Start a recursive main loop for this spoke, which will prevent @@ -101,6 +102,7 @@ class Hub(GUIObject, common.Hub): # prevent the user from switching away. It's up to the spoke's back # button handler to kill its own layer of main loop. Gtk.main() + action.window.set_transient_for(None) if not action.skipTo or (action.skipTo and action.applyOnSkip): action.apply() -- 1.7.11.2

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

anaconda-patches August 2012