anaconda-patches September 2012

anaconda-patches@lists.fedorahosted.org

15 participants
105 discussions

[PATCH] Use the disk's ID for deleting from the shopping cart, not an index (#853798).
by Chris Lumens 04 Sep '12

04 Sep '12

This leaves the index in for now, because we haven't yet decided what identifying information to display instead. --- pyanaconda/ui/gui/spokes/lib/cart.glade | 2 ++ pyanaconda/ui/gui/spokes/lib/cart.py | 13 ++++++++++--- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/pyanaconda/ui/gui/spokes/lib/cart.glade b/pyanaconda/ui/gui/spokes/lib/cart.glade index 92fdfe5..bb45172 100644 --- a/pyanaconda/ui/gui/spokes/lib/cart.glade +++ b/pyanaconda/ui/gui/spokes/lib/cart.glade @@ -12,6 +12,8 @@ <column type="gchararray"/>  <column type="gchararray"/> +  + <column type="gint"/> </columns> </object> <object class="GtkDialog" id="selected_disks_dialog"> diff --git a/pyanaconda/ui/gui/spokes/lib/cart.py b/pyanaconda/ui/gui/spokes/lib/cart.py index 3e77a36..71f831e 100644 --- a/pyanaconda/ui/gui/spokes/lib/cart.py +++ b/pyanaconda/ui/gui/spokes/lib/cart.py @@ -49,7 +49,8 @@ class SelectedDisksDialog(GUIObject): self._store.append([disk.description, size_str(disk.size), size_str(free[disk.name][0]), - str(disks.index(disk))]) + str(disks.index(disk)), + disk.id]) self.disks = disks[:] self._update_summary() @@ -110,8 +111,14 @@ class SelectedDisksDialog(GUIObject): # self._store.remove(itr) model, itr = self._selection.get_selected() if itr: - idx = int(model.get_value(itr, 3)) - disk = self.disks[idx] + disk = None + for d in self.disks: + if d.id == self._store[itr][4]: + disk = d + + if not disk: + return + self._store.remove(itr) self.disks.remove(disk) self._update_summary() -- 1.7.11.2

2 1

[master] Language-related stuff cleanup
by Vratislav Podzimek 04 Sep '12

04 Sep '12

These two patches remove no longer used/needed files and add few lines for writing language system configuration to the installed system. This part needs one more patch for writing /etc/locale.conf, but I don't know how this file should look. Please not that these patches are not tested as I am sending them from the BaseOS team building without virtualization available. I will test them before pusing tomorrow. Vratislav Podzimek (2): Remove lang-table and localeinfo.py Remove anaconda.instLanguage object and language module anaconda | 3 - data/lang-table | 61 --------- pyanaconda/__init__.py | 10 -- pyanaconda/install.py | 1 + pyanaconda/installclass.py | 1 - pyanaconda/kickstart.py | 6 + pyanaconda/language.py | 216 ------------------------------ pyanaconda/localeinfo.py | 56 -------- pyanaconda/localization.py | 25 ++++ tests/pyanaconda_test/language_test.py | 237 --------------------------------- 10 files changed, 32 insertions(+), 584 deletions(-) delete mode 100644 data/lang-table delete mode 100644 pyanaconda/language.py delete mode 100644 pyanaconda/localeinfo.py delete mode 100644 tests/pyanaconda_test/language_test.py -- 1.7.11.4

2 5

[PATCH master] network spoke: require connection only for url and nfs methods (#853899)
by Radek Vykydal 04 Sep '12

04 Sep '12

E.g. allow DVD installs without network. --- pyanaconda/ui/gui/spokes/network.py | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/pyanaconda/ui/gui/spokes/network.py b/pyanaconda/ui/gui/spokes/network.py index 81b2c54..9a862aa 100644 --- a/pyanaconda/ui/gui/spokes/network.py +++ b/pyanaconda/ui/gui/spokes/network.py @@ -926,7 +926,9 @@ class NetworkSpoke(NormalSpoke): @property def completed(self): - return len(self.network_control_box.active_connections()) > 0 + # TODO: check also if source requires updates when implemented + return (self.data.method.method not in ("url", "nfs") or + len(self.network_control_box.active_connections()) > 0) @property def status(self): -- 1.7.4

2 1

[PATCH] Handle invalid spoke input (#853253)
by Jesse Keating 31 Aug '12

31 Aug '12

--- pyanaconda/ui/tui/spokes/storage.py | 4 ++-- pyanaconda/ui/tui/spokes/time.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pyanaconda/ui/tui/spokes/storage.py b/pyanaconda/ui/tui/spokes/storage.py index 40a167a..d1b85c3 100644 --- a/pyanaconda/ui/tui/spokes/storage.py +++ b/pyanaconda/ui/tui/spokes/storage.py @@ -207,7 +207,7 @@ class StorageSpoke(NormalTUISpoke): self._update_disk_list(self.disks[number -1]) return None - except (ValueError, KeyError): + except (ValueError, KeyError, IndexError): return key def apply(self): @@ -345,5 +345,5 @@ class AutoPartSpoke(NormalTUISpoke): self.close() return False - except (ValueError, KeyError): + except (ValueError, KeyError, IndexError): return key diff --git a/pyanaconda/ui/tui/spokes/time.py b/pyanaconda/ui/tui/spokes/time.py index bac1d0f..2cea1b8 100644 --- a/pyanaconda/ui/tui/spokes/time.py +++ b/pyanaconda/ui/tui/spokes/time.py @@ -99,7 +99,7 @@ class TimeZoneSpoke(NormalTUISpoke): else: self.app.switch_screen(self, self._regions[keyid]) return True - except ValueError: + except (ValueError, IndexError): pass if key.lower() in self._lower_zones: -- 1.7.11.2

2 1

[PATCH] Remove unnecessary (and broken) import (#853576)
by Jesse Keating 31 Aug '12

31 Aug '12

--- pyanaconda/text.py | 1 - 1 file changed, 1 deletion(-) diff --git a/pyanaconda/text.py b/pyanaconda/text.py index c924ae3..f3c9c77 100644 --- a/pyanaconda/text.py +++ b/pyanaconda/text.py @@ -32,7 +32,6 @@ import signal import parted import product import string -from localeinfo import expandLangs from flags import flags from textw.constants_text import * from constants import * -- 1.7.11.2

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

anaconda-patches September 2012