anaconda-patches September 2012

anaconda-patches@lists.fedorahosted.org

15 participants
105 discussions

[master] One more "with gdk_threaded():" block
by Vratislav Podzimek 28 Sep '12

28 Sep '12

Now that we have Gdk.threads_init there may appear new issues when whole GUI hangs. Running AddLayout dialog in some cases is the example. Vratislav Podzimek (1): Use gdk_threaded() when running AddLayout dialog pyanaconda/ui/gui/spokes/keyboard.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) -- 1.7.11.4

2 2

cannot find the hard drive for bios disk 80
by B_B_Singh＠DELL.com 27 Sep '12

27 Sep '12

Hi, Implementing a delay algorithm for slow bios storage devices, When I boot anaconda with ks=hd:<dev>:<path> there is an algorithm to retry up to 5 times or 31 seconds for some USB thumb drives and hard drives which are initialized slow. such algorithm is not available in the code path when booted with the option "ks=bd:device:/path/to/ks.cfg". Find a patch in the attachment in which I have added similar algorithm for the slow bios storage devices. Regards Balaji Singh

1 0

Prompt for VNC once more
by Jesse Keating 27 Sep '12

27 Sep '12

-jlk

2 3

[PATCH] Fix bootloader setup on s390. (#857940)
by David Lehman 27 Sep '12

27 Sep '12

--- pyanaconda/bootloader.py | 13 +++++++------ pyanaconda/iutil.py | 2 +- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/pyanaconda/bootloader.py b/pyanaconda/bootloader.py index b0aff48..bc5ea91 100644 --- a/pyanaconda/bootloader.py +++ b/pyanaconda/bootloader.py @@ -1948,6 +1948,10 @@ class ZIPL(BootLoader): image_label_attr = "short_label" preserve_args = ["cio_ignore"] + def __init__(self, platform=None): + super(ZIPL, self).__init__(platform=platform) + self.stage1_name = None + # # configuration # @@ -1993,7 +1997,6 @@ class ZIPL(BootLoader): # def install(self): - # DWL FIXME: resolve the boot device to a StorageDevice from storage buf = iutil.execWithCapture("zipl", [], stderr="/dev/tty5", root=ROOT_PATH, @@ -2005,12 +2008,10 @@ class ZIPL(BootLoader): # Preparing boot device: dasdl. # We want to extract the device name and pass that. name = re.sub(".+?: ", "", line) - name = re.sub("(\s$.+$)?\.$", "", name) - device = self.storage.devicetree.getDeviceByName(name) - if not device: - raise BootLoaderError("could not find IPL device") + self.stage1_name = re.sub("(\s$.+$)?\.$", "", name) - self.stage1_device = device + if not self.stage1_name: + raise BootLoaderError("could not find IPL device") class SILO(YabootSILOBase): name = "SILO" diff --git a/pyanaconda/iutil.py b/pyanaconda/iutil.py index 9d3b433..b39d4f4 100644 --- a/pyanaconda/iutil.py +++ b/pyanaconda/iutil.py @@ -862,7 +862,7 @@ def numeric_type(num): def reIPL(anaconda, loader_pid): try: - ipldev = anaconda.bootloader.stage1_device.name + ipldev = anaconda.storage.bootloader.stage1_name except AttributeError: message = _("Error determining boot device's disk name") log.warning(message) -- 1.7.6.5

2 1

[PATCH 1/2] Add a flag attribute to handle cmdline mode
by Jesse Keating 27 Sep '12

27 Sep '12

cmdline mode means do not prompt for missing kickstart data. We need a way to expose this setting to the interface, so create a flag for it. "cmdline" cannot be used because that already exists as a flag, so "ksprompt" is created as a bool. Defaults to true. --- anaconda | 4 ++++ pyanaconda/flags.py | 2 ++ 2 files changed, 6 insertions(+) diff --git a/anaconda b/anaconda index 627c3a2..a34bb78 100755 --- a/anaconda +++ b/anaconda @@ -882,6 +882,10 @@ if __name__ == "__main__": # now start the interface setupDisplay(anaconda, opts) + # Set flag to prompt for missing ks data + if anaconda.displayMode == 'c': + flags.ksprompt = False + image_count = 0 for image in opts.images: image_spec = image.rsplit(":", 1) diff --git a/pyanaconda/flags.py b/pyanaconda/flags.py index 23bd9c5..2d828dd 100644 --- a/pyanaconda/flags.py +++ b/pyanaconda/flags.py @@ -71,6 +71,8 @@ class Flags(object): self.gpt = False self.leavebootorder = False self.testing = False + # ksprompt is whether or not to prompt for missing ksdata + self.ksprompt = True # parse the boot commandline self.cmdline = BootArgs() # Lock it down: no more creating new flags! -- 1.7.11.4

3 6

[PATCH] fix libuser setup (#855481)
by Brian C. Lane 27 Sep '12

27 Sep '12

From: "Brian C. Lane" <bcl(a)redhat.com> createLuserConf needs to be called before the first use of User(). Also cleaned up some whitespace. --- pyanaconda/install.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/pyanaconda/install.py b/pyanaconda/install.py index d401e2f..b716364 100644 --- a/pyanaconda/install.py +++ b/pyanaconda/install.py @@ -47,7 +47,7 @@ def doConfiguration(storage, payload, ksdata, instClass): from pyanaconda.kickstart import runPostScripts progress.send_init(4) - + # Now run the execute methods of ksdata that require an installed system # to be present first. with progress_report(_("Configuring installed system")): @@ -58,15 +58,14 @@ def doConfiguration(storage, payload, ksdata, instClass): ksdata.keyboard.execute(storage, ksdata, instClass) ksdata.timezone.execute(storage, ksdata, instClass) ksdata.lang.execute(storage, ksdata, instClass) - + with progress_report(_("Writing network configuration")): writeNetworkConf(storage, ksdata, instClass) # Creating users and groups requires some pre-configuration. with progress_report(_("Creating users")): - u = Users() createLuserConf(ROOT_PATH, algoname=getPassAlgo(ksdata.authconfig.authconfig)) - + u = Users() ksdata.rootpw.execute(storage, ksdata, instClass, u) ksdata.group.execute(storage, ksdata, instClass, u) ksdata.user.execute(storage, ksdata, instClass, u) @@ -79,7 +78,7 @@ def doConfiguration(storage, payload, ksdata, instClass): _writeKS(ksdata) progress.send_complete() - + def doInstall(storage, payload, ksdata, instClass): """Perform an installation. This method takes the ksdata as prepared by the UI (the first hub, in graphical mode) and applies it to the disk. -- 1.7.11.4

2 1

[PATCH] Fix the destination path for anaconda.xlog (#860041).
by Chris Lumens 27 Sep '12

27 Sep '12

--- data/post-scripts/95-copy-logs.ks | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/post-scripts/95-copy-logs.ks b/data/post-scripts/95-copy-logs.ks index 7c98662..7343d8a 100644 --- a/data/post-scripts/95-copy-logs.ks +++ b/data/post-scripts/95-copy-logs.ks @@ -3,7 +3,7 @@ mkdir -p /mnt/sysimage/var/log/anaconda [ -e /tmp/anaconda.log ] && cp /tmp/anaconda.log $ANA_INSTALL_PATH/var/log/anaconda/anaconda.log [ -e /tmp/syslog ] && cp /tmp/syslog $ANA_INSTALL_PATH/var/log/anaconda/syslog -[ -e /tmp/X.log ] && cp /tmp/X.log $ANA_INSTALL_PATH/var/log/anaconda.anaconda.xlog +[ -e /tmp/X.log ] && cp /tmp/X.log $ANA_INSTALL_PATH/var/log/anaconda/anaconda.xlog [ -e /tmp/program.log ] && cp /tmp/program.log $ANA_INSTALL_PATH/var/log/anaconda/anaconda.program.log [ -e /tmp/packaging.log ] && cp /tmp/packaging.log $ANA_INSTALL_PATH/var/log/anaconda/anaconda.packaging.log [ -e /tmp/storage.log ] && cp /tmp/storage.log $ANA_INSTALL_PATH/var/log/anaconda/anaconda.storage.log -- 1.7.11.2

3 9

[master] Patches for HW clock saving and restoring
by Vratislav Podzimek 27 Sep '12

27 Sep '12

PATCH 1/3 does only a little and rather cosmetic change and can be omitted. PATCH 2/3 adds a thread that waits for storage initialization, then searches for ntfs partitions and asks bootloader if any of them are bootable. If yes, it sets ksdata.timezone.isUtc to False, otherwise to True. Then it restores system time from HW clock using the guess about UTC. The GUI part waiting for this thread to be finished is more or less copied from the StorageSpoke. PATCH 3/3 adds a code for saving system time to hardware clock as a first step after the "point of no return", i.e. before we do any partitioning and start package installation. This cannot be part of the post-installation steps, because otherwise user could e.g. end up with partitions and data created in future. Unfortunately, I cannot test the dual boot configuration with existing bootable ntfs partition. Vratislav Podzimek (3): Return bool value from the GRUB.has_windows method Set system time from HW clock and guess if it is UTC Save system time to hardware clock anaconda | 11 ++++++++- pyanaconda/bootloader.py | 2 +- pyanaconda/install.py | 18 ++++++++++++++ pyanaconda/timezone.py | 39 ++++++++++++++++++++++++++++++ pyanaconda/ui/gui/spokes/datetime_spoke.py | 25 ++++++++++++++++++- 5 files changed, 92 insertions(+), 3 deletions(-) -- 1.7.11.4

3 8

[PATCH] Remove obsolete requirement on comps-extras.
by Bill Nottingham 26 Sep '12

26 Sep '12

Signed-off-by: Bill Nottingham <notting(a)redhat.com> --- anaconda.spec.in | 1 - 1 file changed, 1 deletion(-) diff --git a/anaconda.spec.in b/anaconda.spec.in index d4902d6..d3d73ef 100644 --- a/anaconda.spec.in +++ b/anaconda.spec.in @@ -100,7 +100,6 @@ Requires: gnome-icon-theme-symbolic Requires: python-meh >= %{mehver} Requires: policycoreutils Requires: rpm-python >= %{rpmpythonver} -Requires: comps-extras Requires: parted >= %{partedver} Requires: pyparted >= %{pypartedver} Requires: yum >= %{yumver} -- 1.7.12

2 1

[PATCH] isys.mount needs to be told when something should be mounted NFS (#860273).
by Chris Lumens 26 Sep '12

26 Sep '12

--- pyanaconda/packaging/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyanaconda/packaging/__init__.py b/pyanaconda/packaging/__init__.py index 3645ccf..c41d06a 100644 --- a/pyanaconda/packaging/__init__.py +++ b/pyanaconda/packaging/__init__.py @@ -507,7 +507,7 @@ class Payload(object): url = "%s:%s" % (server, path) try: - isys.mount(url, mountpoint, options=options) + isys.mount(url, mountpoint, fstype="nfs", options=options) except SystemError as e: log.error("mount failed: %s" % e) exn = PayloadSetupError(str(e)) -- 1.7.11.2

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

anaconda-patches September 2012