anaconda-patches March 2013

anaconda-patches@lists.fedorahosted.org

13 participants
90 discussions

Start a nNew thread

[PATCH] TUI enhancements, refactoring and initial-setup support
by Martin Sivak 13 Mar '13

13 Mar '13

Hi, this is take two of my TUI patch set where I have addressed Chris' and Vrata's comments. Martin

2 13

[PATCH] Add support for vlan (#906272) (anaconda-dracut, pykickstart, pyanacodna)
by Radek Vykydal 13 Mar '13

13 Mar '13

notes: - support for kicstart and GUI is added - dracut's vlan=p4p1.171:171 doesn't seem to work for me - get_*_ifcfg_name functions should be later replaced by reading settings with nm.py when getKSNetworkData and kickstartNetworkData will use nm.py instead of reading ifcfg file - the if branches for various types of devices may suggest using wrapper device objects which is something to be considered later

3 18

[lorax 0/2] log more yum stuff
by Brian C. Lane 13 Mar '13

13 Mar '13

From: "Brian C. Lane" <bcl(a)redhat.com> This outputs yum logs to yum.log, it isn't terribly useful and I can't get script output logs to show up. This also adds a raise so that it won't keep trying to build if there are no initrds. Brian C. Lane (2): Add yum logging to yum.log Raise an error when there are no initrds src/pylorax/treebuilder.py | 7 ++++++- src/sbin/lorax | 17 +++++++++++++++++ 2 files changed, 23 insertions(+), 1 deletion(-) -- 1.8.1.2

2 3

[lorax] Don't remove hmac files for ssh and sshd (#882153)
by Brian C. Lane 13 Mar '13

13 Mar '13

From: "Brian C. Lane" <bcl(a)redhat.com> --- share/runtime-cleanup.tmpl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/share/runtime-cleanup.tmpl b/share/runtime-cleanup.tmpl index 34a0a3a..9dfc021 100644 --- a/share/runtime-cleanup.tmpl +++ b/share/runtime-cleanup.tmpl @@ -286,8 +286,8 @@ removefrom nss-softokn /usr/${libdir}/nss/* removefrom openldap /etc/openldap/* /usr/${libdir}/libldap_r-* removefrom openssh /etc/ssh/* /usr/libexec/* removefrom openssh-clients /etc/ssh/* /usr/bin/slogin /usr/bin/ssh-* -removefrom openssh-clients /usr/${libdir}/* /usr/libexec/* -removefrom openssh-server /etc/ssh/* /usr/${libdir}/* /usr/libexec/* +removefrom openssh-clients /usr/libexec/* +removefrom openssh-server /etc/ssh/* /usr/libexec/* removefrom openssl /etc/pki/* /usr/bin/* /usr/${libdir}/openssl/* removefrom pam /usr/sbin/* /usr/share/locale/* removefrom pciutils /usr/sbin/* -- 1.8.1.2

2 1

[PATCH] Don't pass undefined stdout from execWithCapture.
by Radek Vykydal 13 Mar '13

13 Mar '13

--- pyanaconda/iutil.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyanaconda/iutil.py b/pyanaconda/iutil.py index 05e7753..e459bed 100644 --- a/pyanaconda/iutil.py +++ b/pyanaconda/iutil.py @@ -131,7 +131,7 @@ def execWithCapture(command, argv, stdin=None, stderr=None, root='/', return "" argv = [command] + argv - return _run_program(argv, stdin=stdin, stdout=stdout, root=root)[1] + return _run_program(argv, stdin=stdin, root=root)[1] ## Run a shell. def execConsole(): -- 1.7.11.7

2 1

[blivet] two minor patches
by Radek Vykydal 12 Mar '13

12 Mar '13

I came across these issues when testing iscsi/ibft. (Dave may have better ideas or have them already fixed better)

2 3

[blivet] copy_to_system exceptions when called
by Mark Hamzy 12 Mar '13

12 Mar '13

This fixes two excptions if copy_to_system was called. --- blivet/util.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/blivet/util.py b/blivet/util.py index 495dba1..c27d9f3 100644 --- a/blivet/util.py +++ b/blivet/util.py @@ -1,4 +1,5 @@ import os +import shutil import selinux import subprocess import re @@ -261,6 +262,9 @@ def makedirs(path): os.makedirs(path, 0755) def copy_to_system(source): + # do the import now because enable_installer_mode() has finally been called. + from . import ROOT_PATH + if not os.access(source, os.R_OK): log.info("copy_to_system: source '%s' does not exist." % source) return False -- 1.8.1.2

2 1

[PATCH] Disable grub2-mkconfig's submenus by default.
by Peter Jones 12 Mar '13

12 Mar '13

They are hideous and confusing and serve no useful purpose. Make them go away. Signed-off-by: Peter Jones <pjones(a)redhat.com> --- pyanaconda/bootloader.py | 1 + 1 file changed, 1 insertion(+) diff --git a/pyanaconda/bootloader.py b/pyanaconda/bootloader.py index a8ad105..bf2a921 100644 --- a/pyanaconda/bootloader.py +++ b/pyanaconda/bootloader.py @@ -1439,6 +1439,7 @@ class GRUB2(GRUB): defaults.write("GRUB_TIMEOUT=%d\n" % self.timeout) defaults.write("GRUB_DISTRIBUTOR=\"$(sed 's, release .*$,,g' /etc/system-release)\"\n") defaults.write("GRUB_DEFAULT=saved\n") + defaults.write("GRUB_DISABLE_SUBMENU=true\n") if self.console and self.console.startswith("ttyS"): defaults.write("GRUB_TERMINAL=\"serial console\"\n") defaults.write("GRUB_SERIAL_COMMAND=\"%s\"\n" % self.serial_command) -- 1.8.1.4

2 1

[blivet] collection of unrelated minor patches
by David Lehman 12 Mar '13

12 Mar '13

Patch 1 is for the change summary dialog in anaconda. Patches 2, 5, and 6 are all simple bug fixes. Patch 3 removes a duplicate call to dumpe2fs for every existing ext[234] fs we find and changes non-installer-mode to not run any of the minimum/current fs size code except upon request. Patch 4 allows us to include a blivet version stamp in the log.

2 7

[PATCH 1/4] Add settable quit message to TUI
by Martin Sivak 12 Mar '13

12 Mar '13

--- pyanaconda/ui/tui/__init__.py | 15 +++++++++++++-- pyanaconda/ui/tui/simpleline/base.py | 6 ++++-- 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/pyanaconda/ui/tui/__init__.py b/pyanaconda/ui/tui/__init__.py index 8da9846..d051590 100644 --- a/pyanaconda/ui/tui/__init__.py +++ b/pyanaconda/ui/tui/__init__.py @@ -116,7 +116,9 @@ class TextUserInterface(ui.UserInterface): ENVIRONMENT = "anaconda" - def __init__(self, storage, payload, instclass): + def __init__(self, storage, payload, instclass, + productTitle = u"Anaconda", isFinal = True, + quitMessage = None): """ For detailed description of the arguments see the parent class. @@ -129,12 +131,20 @@ class TextUserInterface(ui.UserInterface): :param instclass: install class reference :type instclass: instance of install class + + :param productTitle: the name of the product + :type productTitle: unicode string + """ ui.UserInterface.__init__(self, storage, payload, instclass) self._app = None self._meh_interface = meh.ui.text.TextIntf() + self.productTitle = productTitle + self.isFinal = isFinal + self.quitMessage = quitMessage + basemask = "pyanaconda.ui.tui" basepath = os.path.dirname(__file__) updatepath = "/tmp/updates/pyanaconda/ui/tui" @@ -171,7 +181,8 @@ class TextUserInterface(ui.UserInterface): """Construct all the objects required to implement this interface. This method must be provided by all subclasses. """ - self._app = tui.App(u"Anaconda", yes_or_no_question=YesNoDialog, queue=communication.hubQ) + self._app = tui.App(self.productTitle, yes_or_no_question = YesNoDialog, + quit_message = self.quitMessage) _hubs = self._list_hubs() # First, grab a list of all the standalone spokes. diff --git a/pyanaconda/ui/tui/simpleline/base.py b/pyanaconda/ui/tui/simpleline/base.py index 131a54a..0dbfa04 100644 --- a/pyanaconda/ui/tui/simpleline/base.py +++ b/pyanaconda/ui/tui/simpleline/base.py @@ -62,7 +62,8 @@ class App(object): STOP_MAINLOOP = False NOP = None - def __init__(self, title, yes_or_no_question = None, width = 80, queue = None): + def __init__(self, title, yes_or_no_question = None, width = 80, queue = None, + quit_message = None): """ :param title: application title for whenever we need to display app name :type title: unicode @@ -78,6 +79,7 @@ class App(object): self._spacer = "\n".join(2*[width*"="]) self._width = width self.quit_question = yes_or_no_question + self.quit_message = quit_message or u"Do you really want to quit?" # async control queue if queue: @@ -433,7 +435,7 @@ class App(object): # global quit command elif self._screens and (key == _('q')): if self.quit_question: - d = self.quit_question(self, _(u"Do you really want to quit?")) + d = self.quit_question(self, _(self.quit_message)) self.switch_screen_modal(d) if d.answer: raise ExitAllMainLoops() -- 1.7.11.7

3 8

← Newer
1
2
3
4
5
6
7
8
9
Older →

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

anaconda-patches March 2013