anaconda-patches April 2013

anaconda-patches@lists.fedorahosted.org

18 participants
101 discussions

[PATCH] Add the "Add FCoE" dialog.
by Chris Lumens 29 Apr '13

29 Apr '13

--- po/POTFILES.in | 1 + pyanaconda/constants.py | 1 + pyanaconda/ui/gui/spokes/advstorage/fcoe.glade | 268 +++++++++++++++++++++++++ pyanaconda/ui/gui/spokes/advstorage/fcoe.py | 121 +++++++++++ pyanaconda/ui/gui/spokes/filter.py | 15 +- 5 files changed, 405 insertions(+), 1 deletion(-) create mode 100644 pyanaconda/ui/gui/spokes/advstorage/fcoe.glade create mode 100644 pyanaconda/ui/gui/spokes/advstorage/fcoe.py diff --git a/po/POTFILES.in b/po/POTFILES.in index 695be87..3b369c3 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -89,6 +89,7 @@ pyanaconda/ui/gui/spokes/source.glade pyanaconda/ui/gui/spokes/welcome.glade pyanaconda/ui/gui/spokes/user.glade pyanaconda/ui/gui/spokes/custom.glade +pyanaconda/ui/gui/spokes/advstorage/fcoe.glade pyanaconda/ui/gui/spokes/advstorage/iscsi.glade pyanaconda/ui/gui/spokes/lib/cart.glade pyanaconda/ui/gui/spokes/lib/detailederror.glade diff --git a/pyanaconda/constants.py b/pyanaconda/constants.py index 4c587d1..7adb9b6 100644 --- a/pyanaconda/constants.py +++ b/pyanaconda/constants.py @@ -122,6 +122,7 @@ THREAD_CHECK_SOFTWARE = "AnaCheckSoftwareThread" THREAD_SOURCE_WATCHER = "AnaSourceWatcher" THREAD_INSTALL = "AnaInstallThread" THREAD_CONFIGURATION = "AnaConfigurationThread" +THREAD_FCOE = "AnaFCOEThread" THREAD_ISCSI_DISCOVER = "AnaIscsiDiscoverThread" THREAD_ISCSI_LOGIN = "AnaIscsiLoginThread" THREAD_GEOLOCATION_REFRESH = "AnaGeolocationRefreshThread" diff --git a/pyanaconda/ui/gui/spokes/advstorage/fcoe.glade b/pyanaconda/ui/gui/spokes/advstorage/fcoe.glade new file mode 100644 index 0000000..a8ad147 --- /dev/null +++ b/pyanaconda/ui/gui/spokes/advstorage/fcoe.glade @@ -0,0 +1,268 @@ +<?xml version="1.0" encoding="UTF-8"?> +<interface> +  + <object class="GtkDialog" id="fcoeDialog"> + <property name="can_focus">False</property> + <property name="border_width">5</property> + <property name="resizable">False</property> + <property name="modal">True</property> + <property name="type_hint">dialog</property> + <property name="decorated">False</property> + <child internal-child="vbox"> + <object class="GtkBox" id="dialog-vbox1"> + <property name="can_focus">False</property> + <property name="orientation">vertical</property> + <property name="spacing">2</property> + <child internal-child="action_area"> + <object class="GtkButtonBox" id="dialog-action_area1"> + <property name="can_focus">False</property> + <property name="layout_style">end</property> + <child> + <object class="GtkButton" id="cancelButton"> + <property name="label">gtk-cancel</property> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="receives_default">True</property> + <property name="use_stock">True</property> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">0</property> + </packing> + </child> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="pack_type">end</property> + <property name="position">0</property> + </packing> + </child> + <child> + <object class="GtkGrid" id="grid1"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="row_spacing">6</property> + <property name="column_spacing">6</property> + <child> + <object class="GtkLabel" id="label1"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="margin_bottom">6</property> + <property name="xalign">0</property> + <property name="label" translatable="yes">Please select the network interface which is connected to your FCoE switch.</property> + <property name="wrap">True</property> + </object> + <packing> + <property name="left_attach">0</property> + <property name="top_attach">0</property> + <property name="width">2</property> + <property name="height">1</property> + </packing> + </child> + <child> + <object class="GtkLabel" id="label2"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="xalign">0</property> + <property name="label" translatable="yes">_NIC:</property> + <property name="use_underline">True</property> + <property name="mnemonic_widget">nicCombo</property> + </object> + <packing> + <property name="left_attach">0</property> + <property name="top_attach">1</property> + <property name="width">1</property> + <property name="height">1</property> + </packing> + </child> + <child> + <object class="GtkComboBoxText" id="nicCombo"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="hexpand">True</property> + <property name="entry_text_column">0</property> + <property name="id_column">1</property> + </object> + <packing> + <property name="left_attach">1</property> + <property name="top_attach">1</property> + <property name="width">1</property> + <property name="height">1</property> + </packing> + </child> + <child> + <object class="GtkCheckButton" id="dcbCheckbox"> + <property name="label" translatable="yes">Use _DCB</property> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="receives_default">False</property> + <property name="use_underline">True</property> + <property name="xalign">0</property> + <property name="draw_indicator">True</property> + </object> + <packing> + <property name="left_attach">0</property> + <property name="top_attach">2</property> + <property name="width">2</property> + <property name="height">1</property> + </packing> + </child> + <child> + <object class="GtkCheckButton" id="autoCheckbox"> + <property name="label" translatable="yes">Use auto _vlan</property> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="receives_default">False</property> + <property name="use_underline">True</property> + <property name="xalign">0</property> + <property name="active">True</property> + <property name="draw_indicator">True</property> + </object> + <packing> + <property name="left_attach">0</property> + <property name="top_attach">3</property> + <property name="width">2</property> + <property name="height">1</property> + </packing> + </child> + <child> + <object class="GtkBox" id="box1"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="spacing">6</property> + <child> + <object class="GtkSpinner" id="addSpinner"> + <property name="can_focus">False</property> + <property name="no_show_all">True</property> + <property name="halign">end</property> + <property name="hexpand">True</property> + <property name="active">True</property> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">0</property> + </packing> + </child> + <child> + <object class="GtkButton" id="addButton"> + <property name="label" translatable="yes">_Add FCoE Disk(s)</property> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="receives_default">True</property> + <property name="use_underline">True</property> + <signal name="clicked" handler="on_add_clicked" swapped="no"/> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="pack_type">end</property> + <property name="position">1</property> + </packing> + </child> + </object> + <packing> + <property name="left_attach">1</property> + <property name="top_attach">4</property> + <property name="width">1</property> + <property name="height">1</property> + </packing> + </child> + <child> + <object class="GtkGrid" id="errorBox"> + <property name="can_focus">False</property> + <property name="no_show_all">True</property> + <property name="row_spacing">6</property> + <property name="column_spacing">6</property> + <child> + <object class="GtkImage" id="image1"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="xalign">1</property> + <property name="stock">gtk-dialog-error</property> + </object> + <packing> + <property name="left_attach">0</property> + <property name="top_attach">0</property> + <property name="width">1</property> + <property name="height">1</property> + </packing> + </child> + <child> + <object class="GtkLabel" id="label3"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="xalign">0</property> + <property name="label" translatable="yes">Error adding FCoE SAN.</property> + <property name="use_markup">True</property> + </object> + <packing> + <property name="left_attach">1</property> + <property name="top_attach">0</property> + <property name="width">1</property> + <property name="height">1</property> + </packing> + </child> + <child> + <object class="GtkLabel" id="errorLabel"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="xalign">0</property> + <property name="label">Error message goes here.</property> + <property name="wrap">True</property> + </object> + <packing> + <property name="left_attach">1</property> + <property name="top_attach">2</property> + <property name="width">1</property> + <property name="height">1</property> + </packing> + </child> + <child> + <object class="GtkLabel" id="label4"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="xalign">0</property> + <property name="label" translatable="yes">The following error occurred while attempting to add an FCoE SAN. Please check your configuration and try again</property> + <property name="wrap">True</property> + </object> + <packing> + <property name="left_attach">1</property> + <property name="top_attach">1</property> + <property name="width">1</property> + <property name="height">1</property> + </packing> + </child> + <child> + <placeholder/> + </child> + <child> + <placeholder/> + </child> + </object> + <packing> + <property name="left_attach">0</property> + <property name="top_attach">5</property> + <property name="width">2</property> + <property name="height">1</property> + </packing> + </child> + <child> + <placeholder/> + </child> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">1</property> + </packing> + </child> + </object> + </child> + <action-widgets> + <action-widget response="0">cancelButton</action-widget> + </action-widgets> + </object> +</interface> diff --git a/pyanaconda/ui/gui/spokes/advstorage/fcoe.py b/pyanaconda/ui/gui/spokes/advstorage/fcoe.py new file mode 100644 index 0000000..9617f6d --- /dev/null +++ b/pyanaconda/ui/gui/spokes/advstorage/fcoe.py @@ -0,0 +1,121 @@ +# FCoE configuration dialog +# +# Copyright (C) 2013 Red Hat, Inc. +# +# This copyrighted material is made available to anyone wishing to use, +# modify, copy, or redistribute it subject to the terms and conditions of +# the GNU General Public License v.2, or (at your option) any later version. +# This program is distributed in the hope that it will be useful, but WITHOUT +# ANY WARRANTY expressed or implied, including the implied warranties of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General +# Public License for more details. You should have received a copy of the +# GNU General Public License along with this program; if not, write to the +# Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA +# 02110-1301, USA. Any Red Hat trademarks that are incorporated in the +# source code or documentation are not subject to the GNU General Public +# License and may only be used or replicated with the express permission of +# Red Hat, Inc. +# +# Red Hat Author(s): Chris Lumens <clumens(a)redhat.com> +# + +# pylint: disable-msg=E0611 +from gi.repository import GLib, Gtk + +from pyanaconda import constants +from pyanaconda.threads import threadMgr, AnacondaThread +from pyanaconda.ui.gui import GUIObject +from pyanaconda import nm + +import gettext +_ = lambda x: gettext.ldgettext("anaconda", x) + +__all__ = ["FCoEDialog"] + +class FCoEDialog(GUIObject): + builderObjects = ["fcoeDialog"] + mainWidgetName = "fcoeDialog" + uiFile = "spokes/advstorage/fcoe.glade" + + def __init__(self, data, storage): + GUIObject.__init__(self, data) + + self._addError = None + + self.storage = storage + self.fcoe = self.storage.fcoe() + + def refresh(self): + self._addButton = self.builder.get_object("addButton") + self._cancelButton = self.builder.get_object("cancelButton") + self._addSpinner = self.builder.get_object("addSpinner") + self._errorBox = self.builder.get_object("errorBox") + + self._nicCombo = self.builder.get_object("nicCombo") + self._nicCombo.remove_all() + + for devname in nm.nm_devices(): + if not nm.nm_device_type_is_ethernet(devname): + continue + + self._nicCombo.append_text("%s - %s" % (devname, nm.nm_device_hwaddress(devname))) + + self._nicCombo.set_active(0) + + def run(self): + rc = self.window.run() + self.window.destroy() + return rc + + @property + def nic(self): + text = self._nicCombo.get_active_text() + return text.split()[0] + + @property + def use_dcb(self): + return self.builder.get_object("dcbCheckbox").get_active() + + @property + def use_auto_vlan(self): + return self.builder.get_object("autoCheckbox").get_active() + + def _add(self): + try: + self.fcoe.addSan(self.nic, self.use_dcb, self.use_auto_vlan) + except Exception as e: + self._addError = str(e) + + def _check_add(self, *args): + if threadMgr.get(constants.THREAD_FCOE): + return True + + # When fcoe discovery is done, update the UI. We don't need to worry + # about the user escaping from the dialog because all the buttons are + # marked insensitive. + self._addSpinner.stop() + self._addSpinner.hide() + + if self._addError: + # Failure. Display some error message and leave the user on the + # dialog to try again. + self.builder.getObject("errorLabel").set_text(self._addError) + self._addError = None + self._addButton.set_sensitive(True) + self._cancelButton.set_sensitive(True) + else: + # Success. There's nothing else the user can do on this dialog. + self.window.response(1) + + def on_add_clicked(self, *args): + # Set some widgets to visible/not while we work. + self._errorBox.hide() + self._addButton.set_sensitive(False) + self._cancelButton.set_sensitive(False) + self._addSpinner.set_visible(True) + self._addSpinner.show() + + self._addSpinner.start() + + threadMgr.add(AnacondaThread(name=constants.THREAD_FCOE, target=self._add)) + GLib.timeout_add(250, self._check_add) diff --git a/pyanaconda/ui/gui/spokes/filter.py b/pyanaconda/ui/gui/spokes/filter.py index 199c8b0..c6840e6 100644 --- a/pyanaconda/ui/gui/spokes/filter.py +++ b/pyanaconda/ui/gui/spokes/filter.py @@ -29,12 +29,14 @@ import itertools from blivet import arch from blivet.devices import DASDDevice, FcoeDiskDevice, iScsiDiskDevice, MultipathDevice, MDRaidArrayDevice, ZFCPDiskDevice +from blivet.fcoe import has_fcoe from pyanaconda.flags import flags from pyanaconda.ui.lib.disks import getDisks, isLocalDisk, size_str from pyanaconda.ui.gui.utils import enlightbox from pyanaconda.ui.gui.spokes import NormalSpoke +from pyanaconda.ui.gui.spokes.advstorage.fcoe import FCoEDialog from pyanaconda.ui.gui.spokes.advstorage.iscsi import ISCSIDialog from pyanaconda.ui.gui.spokes.lib.cart import SelectedDisksDialog from pyanaconda.ui.gui.categories.storage import StorageCategory @@ -441,6 +443,9 @@ class FilterSpoke(NormalSpoke): self._notebook.remove_page(-1) self.builder.get_object("addZFCPButton").destroy() + if not has_fcoe(): + self.builder.get_object("addFCOEButton").destroy() + self._store = self.builder.get_object("diskStore") self._addDisksButton = self.builder.get_object("addDisksButton") @@ -568,7 +573,15 @@ class FilterSpoke(NormalSpoke): self.refresh() def on_add_fcoe_clicked(self, widget, *args): - pass + dialog = FCoEDialog(self.data, self.storage) + + with enlightbox(self.window, dialog.window): + dialog.refresh() + dialog.run() + + # We now need to refresh so any new disks picked up by adding advanced + # storage are displayed in the UI. + self.refresh() def on_add_zfcp_clicked(self, widget, *args): pass -- 1.8.1.2

3 4

[PATCH blivet] Fix fipvlan -f argument once more and for good (#836321)
by Radek Vykydal 29 Apr '13

29 Apr '13

Port from rhel6-branch --- blivet/fcoe.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/blivet/fcoe.py b/blivet/fcoe.py index 5dc6f5b..188b41b 100644 --- a/blivet/fcoe.py +++ b/blivet/fcoe.py @@ -119,13 +119,13 @@ class fcoe(object): util.run_program(["dcbtool", "sc", nic, "app:fcoe", "e:1", "a:1", "w:1"]) util.run_program(["fipvlan", "-c", "-s", "-f", - "'-fcoe'", nic]) + "-fcoe", nic]) else: if auto_vlan: # certain network configrations require the VLAN layer module: util.run_program(["modprobe", "8021q"]) util.run_program(["fipvlan", '-c', '-s', '-f', - "'-fcoe'", nic]) + "-fcoe", nic]) else: f = open("/sys/module/libfcoe/parameters/create", "w") f.write(nic) -- 1.7.11.7

2 1

[PATCH 0/5] Driver Disk Support
by Brian C. Lane 29 Apr '13

29 Apr '13

From: "Brian C. Lane" <bcl(a)redhat.com> This set of patches adds support for rhdd3 driver update disks and repositories. Martin did the original pass on this, and I expanded on that. What it does is: 1. Hook into dracut to parse inst.dd/dd cmdline args, look for disks with OEMDRV labels. If neither of these are present it doesn't do anything. 2. Runs a python driver disk UI during dracut's pre-trigger stage. This checks for driver repos on the OEMDRV disks (and user specified disks). It searches the disk for repos, eliminating the need for a filesystem browser. If inst.dd/dd is passed with no args it will let the user select which drivers to install. 3. If a network URL is passed to inst.dd/dd it will download that rpm and re-run the UI and rescan for new OEMDRV devices. I have tested these with a set of dummy driver files and installer enhancement binaries and it works. The .ko files, etc. all end up in the expected places and depmod complains that they don't have symbols. A couple extra patches are included here. One to add a scratch-bumpver make target which is useful when building full scratch packages without editing the .spec by hand. It does the po-pull and bumpver part of make bumpver but doesn't push the po back to transifex. And the last is a total hack to make curl happy with the file:/// urls for the driver repos. It should go away once curl/urlgrabber get themselves sorted out. *** BLURB HERE *** Brian C. Lane (5): Port driver update utilities from loader Add Driver Update Disk support to anaconda-dracut Add Driver Update Disk repo handling to Anaconda Add scratch-bumpver target Stupid hack to make curl happy Makefile.am | 14 + anaconda.spec.in | 6 +- configure.ac | 3 + dracut/Makefile.am | 11 +- dracut/README-dd | 51 ++++ dracut/anaconda-depmod.sh | 5 + dracut/anaconda-lib.sh | 11 + dracut/anaconda-modprobe.sh | 0 dracut/anaconda-pre-shutdown.sh | 0 dracut/driver-updates | 587 +++++++++++++++++++++++++++++++++++++ dracut/driver-updates-net.sh | 19 ++ dracut/driver-updates-net@.service | 17 ++ dracut/driver-updates.sh | 31 ++ dracut/driver-updates@.service | 17 ++ dracut/fetch-driver-net.sh | 31 ++ dracut/module-setup.sh | 17 +- dracut/parse-anaconda-dd.sh | 19 ++ dracut/parse-anaconda-options.sh | 3 + dracut/python-deps | 30 +- pyanaconda/packaging/yumpayload.py | 36 +++ utils/Makefile.am | 4 +- utils/dd/Makefile.am | 29 ++ utils/dd/dd_extract.c | 236 +++++++++++++++ utils/dd/dd_list.c | 245 ++++++++++++++++ utils/dd/dd_utils.h | 31 ++ utils/dd/rpmutils.c | 437 +++++++++++++++++++++++++++ utils/dd/rpmutils.h | 88 ++++++ 27 files changed, 1954 insertions(+), 24 deletions(-) create mode 100644 dracut/README-dd create mode 100755 dracut/anaconda-depmod.sh mode change 100644 => 100755 dracut/anaconda-modprobe.sh mode change 100644 => 100755 dracut/anaconda-pre-shutdown.sh create mode 100755 dracut/driver-updates create mode 100755 dracut/driver-updates-net.sh create mode 100644 dracut/driver-updates-net@.service create mode 100755 dracut/driver-updates.sh create mode 100644 dracut/driver-updates@.service create mode 100755 dracut/fetch-driver-net.sh create mode 100755 dracut/parse-anaconda-dd.sh create mode 100644 utils/dd/Makefile.am create mode 100644 utils/dd/dd_extract.c create mode 100644 utils/dd/dd_list.c create mode 100644 utils/dd/dd_utils.h create mode 100644 utils/dd/rpmutils.c create mode 100644 utils/dd/rpmutils.h -- 1.8.1.4

2 9

[PATCH] Only check mandatory spokes in automated install (#956960, 895258, )
by Brian C. Lane 29 Apr '13

29 Apr '13

From: "Brian C. Lane" <bcl(a)redhat.com> This should fix up the various bugs related to automated install in text and cmdline mode getting stuck waiting for user input. --- pyanaconda/ui/tui/hubs/summary.py | 2 +- pyanaconda/ui/tui/spokes/user.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pyanaconda/ui/tui/hubs/summary.py b/pyanaconda/ui/tui/hubs/summary.py index 412735d..6f6ad5c 100644 --- a/pyanaconda/ui/tui/hubs/summary.py +++ b/pyanaconda/ui/tui/hubs/summary.py @@ -53,7 +53,7 @@ class SummaryHub(TUIHub): # where all the data is in hand. If not in hand, do the actual prompt. def prompt(self, args=None): if flags.automatedInstall and \ - all(spoke.completed for spoke in self._keys.values()): + all(spoke.completed for spoke in self._keys.values() if spoke.mandatory): self.close() return None if not flags.ksprompt: diff --git a/pyanaconda/ui/tui/spokes/user.py b/pyanaconda/ui/tui/spokes/user.py index 138733e..83a1440 100644 --- a/pyanaconda/ui/tui/spokes/user.py +++ b/pyanaconda/ui/tui/spokes/user.py @@ -67,7 +67,7 @@ class UserSpoke(FirstbootSpokeMixIn, EditTUISpoke): @property def completed(self): - return self.data.user.userList + return len(self.data.user.userList) > 0 @property def mandatory(self): -- 1.8.1.4

2 1

[PATCH] Do not translate a blank window name.
by Chris Lumens 29 Apr '13

29 Apr '13

This should prevent us from getting the .po file header displayed on the screen again in the future. --- widgets/src/BaseWindow.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/widgets/src/BaseWindow.c b/widgets/src/BaseWindow.c index 7493ca4..5aa8420 100644 --- a/widgets/src/BaseWindow.c +++ b/widgets/src/BaseWindow.c @@ -313,7 +313,14 @@ static void anaconda_base_window_set_property(GObject *object, guint prop_id, co } case PROP_WINDOW_NAME: { - char *markup = g_markup_printf_escaped("%s", _(g_value_get_string(value))); + char *markup; + + /* Do not translate an empty string here. */ + if (strcmp(g_value_get_string(value), "") == 0) + markup = g_markup_printf_escaped(""); + else + markup = g_markup_printf_escaped("%s", _(g_value_get_string(value))); + gtk_label_set_markup(GTK_LABEL(priv->name_label), markup); g_free(markup); -- 1.8.1.2

2 1

[PATCH 1/3] Remove the unused LanguageSpoke.
by Chris Lumens 29 Apr '13

29 Apr '13

This functionality is now handled by the LangsupportSpoke class. --- pyanaconda/ui/gui/spokes/welcome.py | 45 ++----------------------------------- 1 file changed, 2 insertions(+), 43 deletions(-) diff --git a/pyanaconda/ui/gui/spokes/welcome.py b/pyanaconda/ui/gui/spokes/welcome.py index f981464..c46741c 100644 --- a/pyanaconda/ui/gui/spokes/welcome.py +++ b/pyanaconda/ui/gui/spokes/welcome.py @@ -29,9 +29,8 @@ N_ = lambda x: x # pylint: disable-msg=E0611 from gi.repository import AnacondaWidgets, Gtk, Pango from pyanaconda.ui.gui.hubs.summary import SummaryHub -from pyanaconda.ui.gui.spokes import StandaloneSpoke, NormalSpoke +from pyanaconda.ui.gui.spokes import StandaloneSpoke from pyanaconda.ui.gui.utils import enlightbox -from pyanaconda.ui.gui.categories.localization import LocalizationCategory from pyanaconda.localization import Language, LOCALE_PREFERENCES, expand_langs from pyanaconda.product import distributionText, isFinal, productName, productVersion @@ -43,7 +42,7 @@ from pyanaconda import geoloc import logging log = logging.getLogger("anaconda") -__all__ = ["WelcomeLanguageSpoke", "LanguageSpoke"] +__all__ = ["WelcomeLanguageSpoke"] class LanguageMixIn(object): builderObjects = ["languageStore", "languageStoreFilter"] @@ -333,43 +332,3 @@ class WelcomeLanguageSpoke(LanguageMixIn, StandaloneSpoke): sys.exit(0) else: StandaloneSpoke._on_continue_clicked(self, cb) - - -class LanguageSpoke(LanguageMixIn, NormalSpoke): - mainWidgetName = "languageSpokeWindow" - uiFile = "spokes/welcome.glade" - builderObjects = LanguageMixIn.builderObjects + [mainWidgetName, WelcomeLanguageSpoke.mainWidgetName] - - category = LocalizationCategory - - icon = "accessories-character-map-symbolic" - title = N_("LANGUAGE") - - def __init__(self, *args): - NormalSpoke.__init__(self, *args) - LanguageMixIn.__init__(self) - - def initialize(self): - LanguageMixIn.initialize(self) - NormalSpoke.initialize(self) - - def refresh(self): - NormalSpoke.refresh(self) - LanguageMixIn.refresh(self, "languageSpokeWindowContentBox") - - @property - def completed(self): - # The language spoke is always completed, as it does not require you do - # anything. There's always a default selected. - return True - - @property - def status(self): - selected = self.builder.get_object(self._selectionName) - (store, itr) = selected.get_selected() - - return store[itr][0] - - @property - def showable(self): - return False -- 1.8.1.2

2 3

[PATCH 1/2] Move where the password quality checker is created (#956049).
by Chris Lumens 29 Apr '13

29 Apr '13

It needs to be created before we set text in the password fields, or it'll get called then and not yet exist. --- pyanaconda/ui/gui/spokes/user.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/pyanaconda/ui/gui/spokes/user.py b/pyanaconda/ui/gui/spokes/user.py index cd2384a..646bbdb 100644 --- a/pyanaconda/ui/gui/spokes/user.py +++ b/pyanaconda/ui/gui/spokes/user.py @@ -175,6 +175,13 @@ class UserSpoke(FirstbootSpokeMixIn, NormalSpoke): self.username: True } + # set up passphrase quality checker + self._pwq = pwquality.PWQSettings() + self._pwq.read_config() + + self.pw_bar = self.builder.get_object("password_bar") + self.pw_label = self.builder.get_object("password_label") + # indicate when the password was set by kickstart self._user.password_kickstarted = self.data.user.seen if self._user.password_kickstarted: @@ -187,13 +194,6 @@ class UserSpoke(FirstbootSpokeMixIn, NormalSpoke): self.pw.set_placeholder_text(_("The password was set by kickstart.")) self.confirm.set_placeholder_text(_("The password was set by kickstart.")) - # set up passphrase quality checker - self._pwq = pwquality.PWQSettings() - self._pwq.read_config() - - self.pw_bar = self.builder.get_object("password_bar") - self.pw_label = self.builder.get_object("password_label") - self._advanced = AdvancedUserDialog(self._user, self._groupDict, self.data) self._advanced.initialize() -- 1.8.1.2

2 2

[master] More patches for the multiple disk selection
by Vratislav Podzimek 26 Apr '13

26 Apr '13

With these patches applied, the behaviour is as shown in this video preview: http://vpodzime.fedorapeople.org/disks_multiple_selection.webm I'm not sure if everybody agrees with what the PATCH 1/3 does, but I think it less confusing that what we have now. If we want to keep the blue background marking the selected disks, we would need a different patch that fixes it, because it got broken with the grab_focus() I added to make Ctrl-A work. Vratislav Podzimek (3): Don't change DiskOverview's background on 'chosen' changed Select all disks in the box with advanced storage as well Allow multiple disk selection with Shift-click (#864707) pyanaconda/ui/gui/spokes/storage.glade | 2 ++ pyanaconda/ui/gui/spokes/storage.py | 54 +++++++++++++++++++++++++++++++++- widgets/src/DiskOverview.c | 5 ---- 3 files changed, 55 insertions(+), 6 deletions(-) -- 1.7.11.7

2 8

[PATCH] Fix number of arguments for languageGroups (liveDVD class) (#957038)
by Radek Vykydal 26 Apr '13

26 Apr '13

--- pyanaconda/packaging/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyanaconda/packaging/__init__.py b/pyanaconda/packaging/__init__.py index fb72e82..27de538 100644 --- a/pyanaconda/packaging/__init__.py +++ b/pyanaconda/packaging/__init__.py @@ -272,7 +272,7 @@ class Payload(object): def groups(self): raise NotImplementedError() - def languageGroups(self, lang): + def languageGroups(self): return [] def groupDescription(self, groupid): -- 1.7.11.7

2 1

[PATCH 0/2 v2] Mounting patches
by Jan Safranek 26 Apr '13

26 Apr '13

The first patch helps with bug #914898. The second one is more interesting, if two devices are mounted to the same place, OpenLMI needs to know which mount was mounted first and which next, in order to display which fs is really visible at the mount point. rootfs / rootfs rw 0 0 /dev/vda2 / ext4 rw,seclabel,relatime,data=ordered 0 0 Jan

1 2

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

anaconda-patches April 2013