anaconda-patches July 2014

anaconda-patches@lists.fedorahosted.org

14 participants
107 discussions

[blivet:master 00/14] Miscellaneous mostly RAID patches (v2)
by Anne Mulhern 18 Jul '14

18 Jul '14

More things I ran into while looking at the things from review. New or substantially changed patches are: * Remove all references to mdMinor... * Remove DeviceFormat.probe() ... * Be more robust... * Extend mdadm()... * Add a method to extract... and all following except Split mdadd() into two... I'm only sending the changed ones. mulhern (14): Make docstring more precise. Remove commented out import. Use super() instead of explicit parent name Generalize the error message for the array level Remove all references to mdMinor in current code base. Remove DeviceFormat.probe() method Add a docstring to mdraid.mdexamine Factor canonicalizeUUID() into separate method. Be more robust in the face of possible changes to mdadm's UUIDs. Extend mdadm() to capture output in the same way as btrfs() Add a method to extract information about an mdraid array Refactor mdraid tests. Change mdadm() so that it raises an exception when the command fails Split mdadd into separate functions. blivet/devicelibs/mdraid.py | 134 ++++++++++--- blivet/devices.py | 6 +- blivet/fcoe.py | 1 - blivet/formats/__init__.py | 4 - blivet/formats/luks.py | 7 - blivet/formats/lvmpv.py | 11 -- blivet/formats/mdraid.py | 15 -- blivet/udev.py | 4 +- tests/devicelibs_test/mdraid_interrogate_test.py | 236 +++++++++++++++++++++++ tests/devicelibs_test/mdraid_test.py | 169 +++++++--------- 10 files changed, 423 insertions(+), 164 deletions(-) create mode 100755 tests/devicelibs_test/mdraid_interrogate_test.py -- 1.9.3

3 12

[f21/master] Restrict the selected and insensitive style rules to anaconda widgets
by David Shea 18 Jul '14

18 Jul '14

The wildcard selectors for the :selected rules were causing untoggled toggles on selected rows to appear the same as toggled toggles. --- data/anaconda-gtk.css | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/data/anaconda-gtk.css b/data/anaconda-gtk.css index ce6c987..8d71f60 100644 --- a/data/anaconda-gtk.css +++ b/data/anaconda-gtk.css @@ -158,17 +158,22 @@ AnacondaSpokeWindow #nav-box { } /* These rules were removed when the Adwaita theme moved from - * gnome-themes-standard to gtk, and they were replaced with much more specific - * selectors. We need something like this for the selection highlights and - * shading for insensitivity to appear on the MountpointSelector, DiskOverview - * and SpokeSelector widgets. We could probably be specific to the Anaconda - * widgets, but on the other hand gtk can go to hell. + * gnome-themes-standard to gtk. The selectors had been wildcards, but after + * the move they were replaced with more specific selectors, because gtk is + * maintained by garbage people who don't care about how anyone else's + * applications look. We need to apply the old style to anconda's custom + * widgets in order for the selection highlight and insensitive shading to + * appear. */ @define-color anaconda_selected_bg_color #4a90d9; @define-color anaconda_selected_fg_color #ffffff; -*:selected, -*:selected:focus { +AnacondaMountpointSelector:selected, +AnacondaDiskOverview:selected, +AnacondaSpokeSelector:selected, +AnacondaMountpointSelector:selected:focus, +AnacondaDiskOverview:selected:focus, +AnacondaSpokeSelector:selected:focus { background-color: @anaconda_selected_bg_color; color: @anaconda_selected_fg_color; } @@ -178,7 +183,9 @@ AnacondaSpokeWindow #nav-box { @define-color anaconda_internal_element_color #888a85; @define-color anaconda_insensitive_borders shade(@anaconda_internal_element_color, 1.37); -*:insensitive { +AnacondaMountpointSelector:insensitive, +AnacondaDiskOverview:insensitive, +AnacondaSpokeSelector:insensitive { background-color: @anaconda_insensitive_bg_color; color: @anaconda_insensitive_fg_color; border-color: @anaconda_insensitive_borders; -- 2.0.0

2 2

[blivet] allow API docs generation w/o pyparted, &c
by David Lehman 18 Jul '14

18 Jul '14

The build environment can't handle modules built from C code, so their FAQ suggested this exact hack to allow the import to succeed. It worked for me, but it will have to be in git to find out if that's all we need to get API docs on rtd.

4 8

[master] Patch fixing ~50% reproducible early crash
by Vratislav Podzimek 18 Jul '14

18 Jul '14

However it may look scary, the PATCH only moves the XklWrapper class and all it needs to a separate module so that it is not imported from a non-GUI code as part of the keyboard.py module, it makes the join_layout_variant function public, it decorates some of the XklWrapper's methods to make sure they run in the main-loop thread together with XklWrapper's initialization that was previously run in background. Vratislav Podzimek (1): Prevent crashes due to accessing X server from multiple threads anaconda | 2 - pyanaconda/keyboard.py | 371 +------------------------------ pyanaconda/ui/gui/spokes/keyboard.py | 9 +- pyanaconda/ui/gui/spokes/welcome.py | 3 +- pyanaconda/ui/gui/xkl_wrapper.py | 383 ++++++++++++++++++++++++++++++++ tests/pyanaconda_tests/keyboard_test.py | 6 +- 6 files changed, 400 insertions(+), 374 deletions(-) create mode 100644 pyanaconda/ui/gui/xkl_wrapper.py -- 1.9.3

3 5

[f21/master] Log more details about collect failure
by Brian C. Lane 18 Jul '14

18 Jul '14

--- pyanaconda/ui/common.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyanaconda/ui/common.py b/pyanaconda/ui/common.py index b151afe..e4f994e 100644 --- a/pyanaconda/ui/common.py +++ b/pyanaconda/ui/common.py @@ -657,7 +657,7 @@ def collect(module_pattern, path, pred): if module_path and "pyanaconda" in module_path: # failure when importing our own module: raise - log.error("Failed to import module in collect: %s", imperr) + log.error("Failed to import module %s from path %s in collect: %s", mod_name, module_path, imperr) continue finally: imp.release_lock() -- 1.9.3

2 1

[anaconda][master][PATCH] Remove a commented out import
by Martin Kolman 17 Jul '14

17 Jul '14

Signed-off-by: Martin Kolman <mkolman(a)redhat.com> --- pyanaconda/packaging/__init__.py | 1 - 1 file changed, 1 deletion(-) diff --git a/pyanaconda/packaging/__init__.py b/pyanaconda/packaging/__init__.py index 713e6dd..c368e0d 100644 --- a/pyanaconda/packaging/__init__.py +++ b/pyanaconda/packaging/__init__.py @@ -61,7 +61,6 @@ from blivet.errors import StorageError import blivet.util import blivet.arch from blivet.platform import platform -#from pyanaconda.progress import progress from pyanaconda.product import productName, productVersion import urlgrabber -- 1.9.3

3 3

[lorax] livemedia-creator: close the socket when done
by Brian C. Lane 17 Jul '14

17 Jul '14

In some cases the socket may not be closed, so make sure it is to prevent hangs when shutting down the virt. --- src/sbin/livemedia-creator | 1 + 1 file changed, 1 insertion(+) diff --git a/src/sbin/livemedia-creator b/src/sbin/livemedia-creator index be34061..e25d422 100755 --- a/src/sbin/livemedia-creator +++ b/src/sbin/livemedia-creator @@ -128,6 +128,7 @@ class LogRequestHandler(SocketServer.BaseRequestHandler): break def finish(self): + self.request.close() self.fp.close() def iserror(self, line): -- 1.9.3

2 1

[blivet:master 0/8] Miscellaneous mostly RAID patches
by Anne Mulhern 17 Jul '14

17 Jul '14

Some things I ran into while trying (and failing) to achieve much greater things. The first six are utterly trivial. Of the remaining three... * Add a method... The method mddetail is not actually used in blivet now, but I think it has potential. Obviously I had a plan for using it. * Refactor mdraid tests It was the smart thing to do, and very informative about mdadm's operation, which lead to: * Split mdadd into separate functions... I would like this change to be part of the specification of the libblockdev plugin. mulhern (8): Make docstring more precise. Remove commented out import. Factor canonicalizeUUID() into separate method. Use super() instead of explicit parent name Generalize the error message for the array level Add a method to extract information about an mdraid array Refactor mdraid tests. Split mdadd into separate functions. blivet/devicelibs/mdraid.py | 85 +++++++-- blivet/devices.py | 6 +- blivet/fcoe.py | 1 - blivet/udev.py | 4 +- tests/devicelibs_test/mdraid_interrogate_test.py | 220 +++++++++++++++++++++++ tests/devicelibs_test/mdraid_test.py | 169 ++++++++--------- 6 files changed, 365 insertions(+), 120 deletions(-) create mode 100755 tests/devicelibs_test/mdraid_interrogate_test.py -- 1.9.3

3 18

[PATCH 0/8] Fix DNF installation support
by Brian C. Lane 16 Jul '14

16 Jul '14

This started out as 'simply' moving the addDriverRepo up into PackagePayload so it could be used by both yum and dnf. It ended up being a bunch of little fixes for problems that were preventing a dnf installation to work at all. Brian C. Lane (8): Rename some dnf items to match yum Move addDriverRepo into PackagePayload class Fix dnf base repo setup to fall back to default gracefully Reset dnf package sack Do not prefer /tmp for dnf downloads dnf should report that it supports Closest Mirror Make sure the software listboxes are shown dnf should put its logs in /tmp/ data/post-scripts/99-copy-logs.ks | 2 + pyanaconda/exception.py | 1 + pyanaconda/packaging/__init__.py | 62 +++++++++++++++++++++++++---- pyanaconda/packaging/dnfpayload.py | 75 ++++++++++++++++++++++++++---------- pyanaconda/packaging/yumpayload.py | 61 +++-------------------------- pyanaconda/ui/gui/spokes/software.py | 2 + 6 files changed, 119 insertions(+), 84 deletions(-) -- 1.9.3

4 23

[PATCH] Fix the custom accelerators in custom partitioning (#1118999(
by David Shea 16 Jul '14

16 Jul '14

The widget receiving the key-release-event signal is no longer a GtkWindow, so we need to look elsewhere to determine which widget is focused. --- pyanaconda/ui/gui/spokes/custom.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pyanaconda/ui/gui/spokes/custom.py b/pyanaconda/ui/gui/spokes/custom.py index 58c4f35..45ab6de 100644 --- a/pyanaconda/ui/gui/spokes/custom.py +++ b/pyanaconda/ui/gui/spokes/custom.py @@ -1429,7 +1429,7 @@ class CustomPartitioningSpoke(NormalSpoke, StorageChecker): ### SIGNAL HANDLERS ### - def on_key_pressed(self, window, event, *args): + def on_key_pressed(self, widget, event, *args): if not event or event and event.type != Gdk.EventType.KEY_RELEASE: return @@ -1437,12 +1437,12 @@ class CustomPartitioningSpoke(NormalSpoke, StorageChecker): # But we only want delete to work if you have focused a MountpointSelector, # and not just any random widget. For those, it's likely the user wants # to delete a character. - if isinstance(window.get_focus(), MountpointSelector): + if isinstance(self.main_window.get_focus(), MountpointSelector): self._removeButton.emit("clicked") elif event.keyval == Gdk.KEY_plus: # And we only want '+' to work if you don't have a text entry focused, since # the user might be entering some free-form text that can include a plus. - if not isinstance(window.get_focus(), Gtk.Entry): + if not isinstance(self.main_window.get_focus(), Gtk.Entry): self._addButton.emit("clicked") def _do_check(self): -- 2.0.0

2 2

← Newer
1
2
3
4
5
6
7
8
...
11
Older →

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

anaconda-patches July 2014