anaconda-patches July 2014

anaconda-patches@lists.fedorahosted.org

14 participants
107 discussions

[PATCH 0/3] Fix some issues with the advanced user options
by David Shea 15 Jul '14

15 Jul '14

The home directory checkbox didn't actually do anything, the UID & GID spin buttons didn't spin, and whatever was in the home directory entry the first time around was used as the home directory, even if you hit cancel. David Shea (3): Remove the "Create a home directory" checkbox Set an upper limit on uids and gids. Ignore the home directory setting if no change was requested (#1119900) pyanaconda/ui/gui/spokes/advanced_user.glade | 92 ++++------------------------ pyanaconda/ui/gui/spokes/user.py | 28 +++++---- 2 files changed, 29 insertions(+), 91 deletions(-) -- 2.0.0

3 5

[master] zRAM swap for anaconda, version 2
by Vratislav Podzimek 15 Jul '14

15 Jul '14

See the commit message for details about zRAM and its benefits for the installation process. This is version 2 of the patch with checks for forcing/disabling zRAM. There should also be a follow-up patch tweaking our code checking memory limits and documentation, but I'd like to test and investigate it a bit further before commiting to some number like 320 MB of RAM (which seems to work without issues). The lorax patch adds utilities the zramswapon/off scripts need. They are ~70KiB altogether and by some miracle decrease the squashfs.img size. Vratislav Podzimek (1): zRAM swap for Anaconda data/systemd/Makefile.am | 3 +- data/systemd/anaconda.target | 1 + data/systemd/zram.service | 11 ++++++++ pyanaconda/ui/lib/disks.py | 3 +- scripts/Makefile.am | 2 +- scripts/makeupdates | 2 +- scripts/zramswapoff | 38 +++++++++++++++++++++++++ scripts/zramswapon | 66 ++++++++++++++++++++++++++++++++++++++++++++ 8 files changed, 122 insertions(+), 4 deletions(-) create mode 100644 data/systemd/zram.service create mode 100755 scripts/zramswapoff create mode 100755 scripts/zramswapon -- 1.9.3

2 3

[anaconda][master][rhel7-branch][PATCH 0/2] Don't create configured.ini & fix typos
by Martin Kolman 15 Jul '14

15 Jul '14

The first patch drops some old code we probably wanted to use early in the Initial Setup development but never did in the end. The end result is that we will no longer needlessly create the configured.ini file in the /var/lib/inital_setup folder (yes, there is even a spelling mistake in the path - we would probably never know about it if the mistake was not there, as the typo is what triggered the bug report :) ). The second patch fixes a few typos I've discovered while working on the first patch. Martin Kolman (2): Don't create the configured.ini file (#1119166) Fix a typo: inital -> initial pyanaconda/install.py | 1 - pyanaconda/kickstart.py | 26 -------------------------- pyanaconda/ui/tui/simpleline/base.py | 2 +- pyanaconda/users.py | 2 +- tests/pyanaconda_tests/timezone_test.py | 2 +- 5 files changed, 3 insertions(+), 30 deletions(-) -- 1.9.3

2 3

[PATCH rhel7-branch] Port of rpmostreepayload patches from master
by Radek Vykydal 15 Jul '14

15 Jul '14

Patches porting current ostree/atomic support from master to rhel7-branch. The https://bugzilla.redhat.com/show_bug.cgi?id=1113535 is not acked yet but I believe we should be able to have Atomic (ostree) patches in rhel7-branch (ie not create a special branch for Atomic).

4 23

[PATCH blivet] Minor fix of a docstring.
by Radek Vykydal 15 Jul '14

15 Jul '14

Discovered during review of port to rhel7-branch, so fix it in master too. --- blivet/__init__.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/blivet/__init__.py b/blivet/__init__.py index 0bb66a2..d033d3a 100644 --- a/blivet/__init__.py +++ b/blivet/__init__.py @@ -159,8 +159,6 @@ def setSysroot(storageRoot, sysroot=None): """Change the OS root path. :param storageRoot: The root of physical storage :param sysroot: An optional chroot subdirectory of storageRoot - - Change the """ global _storageRoot global _sysroot -- 1.9.0

2 1

[PATCH pykickstart blivet rhel7-branch] Port of
by Radek Vykydal 15 Jul '14

15 Jul '14

The https://bugzilla.redhat.com/show_bug.cgi?id=1113535 is not acked yet, pykickstart is not approved component for 7.1 yet I think.

3 7

[PATCH] Split kickstart arg handling
by Brian C. Lane 15 Jul '14

15 Jul '14

When inst.ks is used the Anaconda dracut module downloads it and partially processes it, writing it to /run/install/ks.cfs so --ks indicates a file at this location should be used. When --kickstart <path> is used from the cmdline it means use that kickstart file directly. No URL handling is done when this argument is passed. --- anaconda | 4 +++- data/anaconda_options.txt | 6 +++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/anaconda b/anaconda index f25bfae..e9a9dfa 100755 --- a/anaconda +++ b/anaconda @@ -427,8 +427,10 @@ def parseArguments(argv=None, boot_cmdline=None): # Method of operation ap.add_argument("-d", "--debug", dest="debug", action="store_true", default=False, help=help_parser.help_text("debug")) - ap.add_argument("--ks", "--kickstart", dest="ksfile", nargs="?", + ap.add_argument("--ks", dest="ksfile", action="store_const", metavar="KICKSTART_URL", const="/run/install/ks.cfg", + help=help_parser.help_text("ks")) + ap.add_argument("--kickstart", dest="ksfile", metavar="KICKSTART_PATH", help=help_parser.help_text("kickstart")) ap.add_argument("--rescue", dest="rescue", action="store_true", default=False, help=help_parser.help_text("rescue")) diff --git a/data/anaconda_options.txt b/data/anaconda_options.txt index 1944c0d..a1e3143 100644 --- a/data/anaconda_options.txt +++ b/data/anaconda_options.txt @@ -22,12 +22,16 @@ debug Show debug level messages in the log watching consoles. This basically a shortcut for for loglevel=debug. -kickstart +ks Gives the location of the kickstart file to be used for installation. The KICKSTART_URL supports fetching kickstarts from HTTP/S, FTP, NFS, from a local file, from a local harddrive, from an optical disk and from BIOS RAID sets. For details on the KICKSTART_URL syntax see the Anaconda options wiki page: http://fedoraproject.org/wiki/Anaconda_Boot_Options +kickstart +Gives the local file path to use for kickstart. Normally only used when running anaconda +from the cmdline. + rescue Start the rescue environment instead of installation. -- 1.9.3

2 1

[lorax] Allow _ in isolabel (#1118955)
by Brian C. Lane 15 Jul '14

15 Jul '14

--- share/live/x86.tmpl | 5 ++++- share/x86.tmpl | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/share/live/x86.tmpl b/share/live/x86.tmpl index eb67bbf..3d5b2c5 100644 --- a/share/live/x86.tmpl +++ b/share/live/x86.tmpl @@ -8,7 +8,10 @@ KERNELDIR=PXEBOOTDIR LIVEDIR="LiveOS" ## Don't allow spaces or escape characters in the iso label -isolabel = ''.join(ch if ch.isalnum() else '-' for ch in isolabel) +def valid_label(ch): + return ch.isalnum() or ch == '_' + +isolabel = ''.join(ch if valid_label(ch) else '-' for ch in isolabel) %> mkdir ${LIVEDIR} diff --git a/share/x86.tmpl b/share/x86.tmpl index cdd7477..02117cd 100644 --- a/share/x86.tmpl +++ b/share/x86.tmpl @@ -8,7 +8,10 @@ KERNELDIR=PXEBOOTDIR LIVEDIR="LiveOS" ## Don't allow spaces or escape characters in the iso label -isolabel = ''.join(ch if ch.isalnum() else '-' for ch in isolabel) +def valid_label(ch): + return ch.isalnum() or ch == '_' + +isolabel = ''.join(ch if valid_label(ch) else '-' for ch in isolabel) %> mkdir ${LIVEDIR} -- 1.9.3

2 1

[PATCH] Python's octals changed; mount's didn't.
by Peter Jones 14 Jul '14

14 Jul '14

Signed-off-by: Peter Jones <pjones(a)redhat.com> --- pyanaconda/kickstart.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyanaconda/kickstart.py b/pyanaconda/kickstart.py index 654213a..d5cefff 100644 --- a/pyanaconda/kickstart.py +++ b/pyanaconda/kickstart.py @@ -1085,7 +1085,7 @@ class PartitionData(commands.partition.F18_PartData): ty = "macefi" else: ty = "EFI System Partition" - self.fsopts = "defaults,uid=0,gid=0,umask=0o077,shortname=winnt" + self.fsopts = "defaults,uid=0,gid=0,umask=077,shortname=winnt" else: if self.fstype != "": ty = self.fstype -- 1.9.3

2 1

[PATCH] add an anaconda+ostree test
by Chris Lumens 14 Jul '14

14 Jul '14

This patch set adds a test case for checking anaconda+ostree installs. It's different from the previous version in that it also reboots the image, writes out a file to indicate it did so, and then checks for that file afterwards. I could easily add extra checks - either at %post time when anaconda is running, or afterwards when the system reboots. All I need are ideas. Note that running this test will require virt-cat, which is yet another thing I will need to install on jenkins builders. - Chris

2 6

← Newer
1
2
3
4
5
6
7
8
9
10
11
Older →

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

anaconda-patches July 2014