anaconda-patches January 2015

anaconda-patches@lists.fedorahosted.org

16 participants
122 discussions

[rhel6-branch] Detect and show a warning for LDL DASDs. (#1144979)
by Samantha N. Bueno 05 Jan '15

05 Jan '15

Check if any of the DASDs on an s390x system are LDL formatted. If they are, show a warning to users and give them the option to run dasdfmt against them, which will (re-)format them as CDL DASDs. Resolves: rhbz#1144979 --- installinterfacebase.py | 4 ++-- storage/dasd.py | 21 +++++++++++++++------ 2 files changed, 17 insertions(+), 8 deletions(-) diff --git a/installinterfacebase.py b/installinterfacebase.py index d4f20fa..6d454e0 100644 --- a/installinterfacebase.py +++ b/installinterfacebase.py @@ -80,12 +80,12 @@ class InstallInterfaceBase(object): title = P_("Unformatted DASD Device Found", "Unformatted DASD Devices Found", c) msg = P_("Format uninitialized DASD device?\n\n" - "There is %d uninitialized DASD device on this " + "There is %d uninitialized or LDL DASD device on this " "system. To continue installation, the device must " "be formatted. Formatting will remove any data on " "this device." % c, "Format uninitialized DASD devices?\n\n" - "There are %d uninitialized DASD devices on this " + "There are %d uninitialized or LDL DASD devices on this " "system. To continue installation, the devices must " "be formatted. Formatting will remove any data on " "these devices." % c, diff --git a/storage/dasd.py b/storage/dasd.py index 3a20b16..1576048 100644 --- a/storage/dasd.py +++ b/storage/dasd.py @@ -20,6 +20,7 @@ # import iutil +import isys import sys import os from storage.errors import DasdFormatError @@ -59,6 +60,9 @@ class DASD: def startup(self, intf, exclusiveDisks, zeroMbr): """ Look for any unformatted DASDs in the system and offer the user the option for format them with dasdfmt or exit the installer. + + Also check if any DASDs are LDL formatted and show a warning to + users, since these disks will not be usable during installation. """ if self.started: return @@ -73,7 +77,7 @@ class DASD: # Trigger udev data about the dasd devices on the system udev_trigger(action="change", name="dasd*") - log.info("Checking for unformatted DASD devices:") + log.info("Checking for unformatted and LDL DASD devices:") for device in os.listdir("/sys/block"): if not device.startswith("dasd"): @@ -87,18 +91,23 @@ class DASD: status = f.read().strip() f.close() - if status in ["unformatted"] and device not in exclusiveDisks: - bypath = deviceNameToDiskByPath(device) - if not bypath: - bypath = "/dev/" + device + bypath = deviceNameToDiskByPath(device) + if not bypath: + bypath = "/dev/" + device + if status in ["unformatted"] and device not in exclusiveDisks: log.info(" %s (%s) status is %s, needs dasdfmt" % (device, bypath, status,)) self._dasdlist.append((device, bypath)) + elif isys.isLdlDasd(device): + log.info(" %s (%s) is an LDL DASD, needs dasdfmt" % (device, + bypath)) + self._dasdlist.append((device, bypath)) + if not len(self._dasdlist): - log.info(" no unformatted DASD devices found") + log.info(" no unformatted or LDL DASD devices found") return askUser = True -- 1.9.3

2 1

[PATCH] Mount efivarfs under /mnt/sysimage on appropriate platforms
by Peter Jones 02 Jan '15

02 Jan '15

Bug 1129435 was fixed in the efibootmgr code, but that code only works if we've got the newer kernel interface available, which requires mounting it. If we don't mount it, we hit the old code path, which doesn't allow us to create device paths > 1024 bytes. Signed-off-by: Peter Jones <pjones(a)redhat.com> --- blivet/__init__.py | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/blivet/__init__.py b/blivet/__init__.py index 210d3c6..2c8d26b 100644 --- a/blivet/__init__.py +++ b/blivet/__init__.py @@ -85,6 +85,7 @@ from . import util from . import arch from .flags import flags from .platform import platform as _platform +from .platform import EFI from .size import Size from .i18n import _ @@ -2260,6 +2261,7 @@ class FSSet(object): self._devshm = None self._usb = None self._selinux = None + self._efivars = None self._run = None self._fstab_swaps = set() self.preserveLines = [] # lines we just ignore and preserve @@ -2310,6 +2312,12 @@ class FSSet(object): return self._selinux @property + def efivars(self): + if not self._efivars: + self._efivars = NoDevice(fmt=getFormat("efivarfs", device="efivarfs", mountpoint="/sys/firmware/efi/efivars")) + return self._efivars + + @property def run(self): if not self._run: self._run = DirectoryDevice("/run", @@ -2386,7 +2394,8 @@ class FSSet(object): device=device.path, exists=True) elif mountpoint in ("/proc", "/sys", "/dev/shm", "/dev/pts", - "/sys/fs/selinux", "/proc/bus/usb"): + "/sys/fs/selinux", "/proc/bus/usb", + "/sys/firmware/efi/efivars"): # drop these now -- we'll recreate later return None else: @@ -2554,6 +2563,8 @@ class FSSet(object): devices = list(self.mountpoints.values()) + self.swapDevices devices.extend([self.dev, self.devshm, self.devpts, self.sysfs, self.proc, self.selinux, self.usb, self.run]) + if isinstance(_platform, EFI): + devices.append(self.efivars) devices.sort(key=lambda d: getattr(d.format, "mountpoint", None)) for device in devices: @@ -2611,6 +2622,8 @@ class FSSet(object): devices = list(self.mountpoints.values()) + self.swapDevices devices.extend([self.dev, self.devshm, self.devpts, self.sysfs, self.proc, self.usb, self.selinux, self.run]) + if isinstance(_platform, EFI): + devices.append(self.efivars) devices.sort(key=lambda d: getattr(d.format, "mountpoint", None)) devices.reverse() for device in devices: -- 2.1.0

3 2

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

anaconda-patches January 2015