anaconda-patches January 2015

anaconda-patches@lists.fedorahosted.org

16 participants
122 discussions

[PATCH] Do not include dd_list and dd_extract in the anaconda-core package.
by Chris Lumens 29 Jan '15

29 Jan '15

This results in file conflicts with anaconda-dracut. --- anaconda.spec.in | 1 + 1 file changed, 1 insertion(+) diff --git a/anaconda.spec.in b/anaconda.spec.in index ad89e44..0800cd9 100644 --- a/anaconda.spec.in +++ b/anaconda.spec.in @@ -267,6 +267,7 @@ update-desktop-database &> /dev/null || : %{_sbindir}/handle-sshpw %{_datadir}/anaconda %{_prefix}/libexec/anaconda +%exclude %{_prefix}/libexec/anaconda/dd_* %{_libdir}/python*/site-packages/pyanaconda/* %exclude %{_libdir}/python*/site-packages/pyanaconda/rescue.py* %exclude %{_libdir}/python*/site-packages/pyanaconda/text.py* -- 2.2.1

2 1

[anaconda][master][PATCH 0/9] More Python 3 compatibility
by Martin Kolman 29 Jan '15

29 Jan '15

Most of the easy to change, non-invasive Python 3 compatibility changes have been done a while ago. This patch set contains more complicated and invasive changes, but still without breaking Python 2 support. Also while working on the patch set I've made a preliminary list of the *invasive* changes that *do* break Python 2 compatibility, but are needed to make Anaconda Python 3 compatible: - switch to Python 3 versions of dependencies in spec file - switch to use python3 in the main anaconda script: - #!/usr/bin/python3 - replace types.StringType with str or bytes (depending on data being processed) - replace types.UnicodeType with str - replace all unicode() calls with str() - import Queue -> import queue - import ConfigParser -> import configparser - remove from __future__ import print_function - adapt metaclass usage - 2to3 -f metaclass . - replace xrange with range - replace next() with __next__() for custom iterators - replace raw_input() with input() These two together + dropping of the few remaining Python 2-only dependencies (pyblock, something else ?) should more or less give us a Python 3 Anaconda. Martin Kolman (9): Make the iter*() dictionary methods Python 3 compatible (#1014220) Replace StandardError with Exception (#1014220) Make filter() usage Python 3 compatible (#1014220) Replace urllib with python-requests for network access (#1014220) Make map() usage Python 3 compatible (#1014220) Do not use sys.exc_type (#1014220) Replace long usage with int (#1014220) Replace callable with collections.Callable (#1014220) Make range usage Python 3 compatible (#1014220) pyanaconda/addons.py | 6 +-- pyanaconda/anaconda.py | 2 +- pyanaconda/anaconda_argparse.py | 6 +-- pyanaconda/bootloader.py | 4 +- pyanaconda/geoloc.py | 66 +++++++++++++++--------------- pyanaconda/installclass.py | 4 +- pyanaconda/iutil.py | 4 +- pyanaconda/keyboard.py | 6 ++- pyanaconda/kickstart.py | 6 +-- pyanaconda/localization.py | 2 +- pyanaconda/network.py | 3 +- pyanaconda/packaging/dnfpayload.py | 4 +- pyanaconda/packaging/livepayload.py | 11 +++-- pyanaconda/rescue.py | 2 +- pyanaconda/threads.py | 2 +- pyanaconda/ui/__init__.py | 4 +- pyanaconda/ui/gui/__init__.py | 2 +- pyanaconda/ui/gui/hubs/__init__.py | 2 +- pyanaconda/ui/gui/spokes/custom.py | 6 +-- pyanaconda/ui/gui/spokes/datetime_spoke.py | 2 +- pyanaconda/ui/gui/spokes/filter.py | 4 +- pyanaconda/ui/gui/spokes/lib/resize.py | 2 +- pyanaconda/ui/gui/spokes/source.py | 2 +- pyanaconda/ui/gui/spokes/storage.py | 7 ++-- pyanaconda/ui/gui/xkl_wrapper.py | 4 +- pyanaconda/ui/tui/hubs/__init__.py | 4 +- pyanaconda/ui/tui/spokes/__init__.py | 5 ++- pyanaconda/ui/tui/spokes/time_spoke.py | 3 +- pyanaconda/users.py | 5 +-- scripts/makeupdates | 2 +- tests/pyanaconda_tests/ks_version_test.py | 4 +- tests/pyanaconda_tests/timezone_test.py | 4 +- 32 files changed, 96 insertions(+), 94 deletions(-) -- 2.1.0

4 26

[master] Remove unused version macros from anaconda.spec.in
by Vratislav Podzimek 29 Jan '15

29 Jan '15

They could only lead to confusion. Signed-off-by: Vratislav Podzimek <vpodzime(a)redhat.com> --- anaconda.spec.in | 2 -- 1 file changed, 2 deletions(-) diff --git a/anaconda.spec.in b/anaconda.spec.in index 6427025..60fec06 100644 --- a/anaconda.spec.in +++ b/anaconda.spec.in @@ -26,12 +26,10 @@ Source0: %{name}-%{version}.tar.bz2 %define dnfver 0.4.18 %define partedver 1.8.1 %define pypartedver 2.5-2 -%define pythonpyblockver 0.45 %define nmver 0.9.9.0-10.git20130906 %define dbusver 1.2.3 %define yumutilsver 1.1.11-3 %define mehver 0.23-1 -%define sckeyboardver 1.3.1 %define firewalldver 0.3.5-1 %define utillinuxver 2.15.1 %define dracutver 034-7 -- 2.1.0

2 1

[PATCH] Don't allow weak LUKS passwords either
by Brian C. Lane 29 Jan '15

29 Jan '15

Be consistent about password strength, make sure LUKS also passes the minimum libpwquality requirements. --- pyanaconda/ui/gui/spokes/lib/passphrase.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pyanaconda/ui/gui/spokes/lib/passphrase.py b/pyanaconda/ui/gui/spokes/lib/passphrase.py index 89c2c64..8241ce1 100644 --- a/pyanaconda/ui/gui/spokes/lib/passphrase.py +++ b/pyanaconda/ui/gui/spokes/lib/passphrase.py @@ -146,7 +146,8 @@ class PassphraseDialog(GUIObject, GUIInputCheckHandler): # The save button should only be sensitive if the match check passes if self._passphrase_match_check.check_status == InputCheck.CHECK_OK and \ - self._confirm_match_check.check_status == InputCheck.CHECK_OK: + self._confirm_match_check.check_status == InputCheck.CHECK_OK and \ + self._strength_check.check_status == InputCheck.CHECK_OK: self._save_button.set_sensitive(True) else: self._save_button.set_sensitive(False) -- 1.9.3

2 1

[anaconda] Use %license in anaconda.spec.in
by Brian C. Lane 28 Jan '15

28 Jan '15

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text --- anaconda.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/anaconda.spec.in b/anaconda.spec.in index 6427025..f510109 100644 --- a/anaconda.spec.in +++ b/anaconda.spec.in @@ -259,10 +259,10 @@ update-desktop-database &> /dev/null || : %endif %files -%doc COPYING +%license COPYING %files core -f %{name}.lang -%doc COPYING +%license COPYING %{_unitdir}/* %{_prefix}/lib/systemd/system-generators/* %{_bindir}/instperf -- 1.9.3

2 5

[anaconda/blivet][master] Move installation specific code to anaconda's codebase
by Vratislav Podzimek 28 Jan '15

28 Jan '15

These four patches move installation specific code from blivet to anaconda. Being used only as part of the installation process such code doesn't belong to blivet's codebase. The GH Blivet issue [0] suggests moving also shouldClear and clearPartitions, but clearPartitions is used by blivet's tests to initialize loop devices for running tests and shouldClear is used by clearPartitions and getFreeSpace. It would be possible to pass shouldClear-type-of-function as a parameter to clearPartitions and getFreeSpace with a default value of None meaning nothing (or everything?) should be cleared, but I'm leaving that for future patch set. [0] https://github.com/rhinstaller/blivet/issues/25 This is the first step, the other two are dealing with shouldClear as mentioned above and cleaning up the new code in pyanaconda/autopart.py and storage_utils.py so that it better matches coding style etc. Although it is quite a big number of added/changed lines, it's mainly just a copy-paste from blivet sources with fixed imports and Blivet's _sysroot replaced by iutil.getSysroot(). I ran several autopart installations and everything seems to be okay. Vratislav Podzimek (2): Move autopart and swap suggesting functionality to anaconda Move code related to finding existing installations to anaconda anaconda | 4 +- pyanaconda/autopart.py | 497 ++++++++++++++++++++++++++++++++ pyanaconda/installclass.py | 4 +- pyanaconda/kickstart.py | 10 +- pyanaconda/rescue.py | 6 +- pyanaconda/storage_utils.py | 218 ++++++++++++++ pyanaconda/ui/gui/spokes/custom.py | 4 +- pyanaconda/ui/gui/spokes/lib/refresh.py | 5 +- pyanaconda/ui/gui/spokes/storage.py | 6 +- pyanaconda/ui/tui/spokes/storage.py | 3 +- 10 files changed, 738 insertions(+), 19 deletions(-) create mode 100644 pyanaconda/autopart.py -- 2.1.0

2 10

[PATCH 1/4] Increase minimum password length to 8
by Brian C. Lane 27 Jan '15

27 Jan '15

In order to promote a more secure default installation increse the password length needed for root and user passwords in the GUI. --- pyanaconda/constants.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyanaconda/constants.py b/pyanaconda/constants.py index 1aa7f9d..0bd23d3 100644 --- a/pyanaconda/constants.py +++ b/pyanaconda/constants.py @@ -134,7 +134,7 @@ FIRSTBOOT_ENVIRON = "firstboot" UNSUPPORTED_HW = 1 << 28 # Password validation -PASSWORD_MIN_LEN = 6 +PASSWORD_MIN_LEN = 8 PASSWORD_EMPTY_ERROR = N_("The password is empty.") PASSWORD_CONFIRM_ERROR_GUI = N_("The passwords do not match.") PASSWORD_CONFIRM_ERROR_TUI = N_("The passwords you entered were different. Please try again.") -- 1.9.3

4 9

[blivet][rhel7-branch,master] revert problematic commit
by David Lehman 27 Jan '15

27 Jan '15

The commit being reverted was not critical to resolving the bug it was related to. I should have known to leave it out for that reason. The conditions necessary for the new (see bug referenced in commit msg) problem to manifest are not totally clear to me. I am hoping to refactor the devicetree populate method as part of the uevent handling work, and this kind of tangle is exactly what I'll be hoping to get a grip on, if not eliminate.

2 2

[blivet][master/rhel7-branch][PATCH] Shrink the last of the biggest implicit partitions if needed (#1171116)
by Vratislav Podzimek 27 Jan '15

27 Jan '15

If there is a big partition requested to be allocated on a disk with basically the same size (e.g. 1.8 GiB swap on a 2 GiB DASD with BTRFS autopart) we need to make one of the implicit partitions smaller (they default to 500 MiB) to fit into the disk. We choose the last of the biggest ones because the biggest ones have the biggest chance to "survive" shrinking and last of them won't collide with /boot being on the same disk (there's one implicit partition per disk so the first one will likely end up on the same disk as /boot when doing autopart). Signed-off-by: Vratislav Podzimek <vpodzime(a)redhat.com> --- blivet/partitioning.py | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/blivet/partitioning.py b/blivet/partitioning.py index 9f6eea8..ff744cf 100644 --- a/blivet/partitioning.py +++ b/blivet/partitioning.py @@ -130,6 +130,7 @@ def _schedulePartitions(storage, disks, implicit_devices, min_luks_entropy=0): :returns: None :rtype: None """ + # basis for requests with requiredSpace is the sum of the sizes of the # two largest free regions all_free = (Size(reg.getLength(unit="B")) for reg in getFreeRegions(disks)) @@ -238,10 +239,16 @@ def _schedulePartitions(storage, disks, implicit_devices, min_luks_entropy=0): if storage.autoPartType in (AUTOPART_TYPE_LVM, AUTOPART_TYPE_LVM_THINP, AUTOPART_TYPE_BTRFS): - # doing LVM/BTRFS -- make sure the newly created partition fits in some - # free space together with one of the implicitly requested partitions - smallest_implicit = sorted(implicit_devices, key=lambda d: d.size)[0] - if (request.size + smallest_implicit.size) > all_free[0]: + # doing LVM/BTRFS -- make sure the newly created partition fits in + # some free space together with one of the implicitly requested + # partitions (the last of the biggest ones because the biggest ones + # have the biggest chance to "survive" shrinking and last of them + # won't collide with /boot being on the same disk) + # HINT: sorted().reverse() is different from sorted(reverse=True) + sorted_implicits = sorted(implicit_devices, key=lambda d: d.size) + sorted_implicits.reverse() + biggest_last_implicit = sorted_implicits[0] + if (request.size + biggest_last_implicit.size) > all_free[0]: # not enough space to allocate the smallest implicit partition # and the request, make the implicit partition smaller with # fixed size in order to make space for the request @@ -253,10 +260,10 @@ def _schedulePartitions(storage, disks, implicit_devices, min_luks_entropy=0): all_free.sort(reverse=True) if new_size > Size(0): - smallest_implicit.size = new_size + biggest_last_implicit.size = new_size / 2 else: - implicit_devices.remove(smallest_implicit) - storage.destroyDevice(smallest_implicit) + implicit_devices.remove(biggest_last_implicit) + storage.destroyDevice(biggest_last_implicit) return implicit_devices -- 2.1.0

3 6

[PATCH rhel7-branch] network: add teamd package if team is used during installation (#1185670)
by Radek Vykydal 26 Jan '15

26 Jan '15

Resolves: rhbz#1185670 --- pyanaconda/install.py | 3 +++ pyanaconda/network.py | 3 +++ 2 files changed, 6 insertions(+) diff --git a/pyanaconda/install.py b/pyanaconda/install.py index 51c42b9..d1ed6bb 100644 --- a/pyanaconda/install.py +++ b/pyanaconda/install.py @@ -213,6 +213,9 @@ def doInstall(storage, payload, ksdata, instClass): if not ksdata.bootloader.disabled: packages += storage.bootloader.packages + if network.is_using_team_device: + packages.append("teamd") + # don't try to install packages from the install class' ignored list and the # explicitly excluded ones (user takes the responsibility) packages = [p for p in packages diff --git a/pyanaconda/network.py b/pyanaconda/network.py index f86b0c2..7a74b90 100644 --- a/pyanaconda/network.py +++ b/pyanaconda/network.py @@ -1371,3 +1371,6 @@ def status_message(): def default_ks_vlan_interface_name(parent, vlanid): return "%s.%s" % (parent, vlanid) + +def is_using_team_device(): + return any(nm.nm_device_type_is_team(d) for d in nm.nm_devices()) -- 1.9.3

2 1

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

anaconda-patches January 2015